From nobody Mon Feb 9 21:21:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595514625; cv=none; d=zohomail.com; s=zohoarc; b=hWPT7wUfbzNAzfk9iT1FY/2KrZTTwYRQnznOhxo10ilwi3iV0WptL36Y3r9PXJL37uwiviUTW/c4Sbg/io+w4NX+tP0nQYlTCwQujpfCjo8Hd4eYLRe5RbK8HsAJjX31R3c4UFzKWh94OepjrH/olIqnz5eaGIUVtH/BoF+e1/o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595514625; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SxgpzSARUKg0APZeWeak/iVUy1+FhCYqHcriF0jmv2s=; b=mCzW+1NbAMxgD5nVb5fdbsQfW8pMudh7Cx6QA3SWNBAVuucmr7HUGp2UF4r7Rjgz4n5SAbajQss5Rw0GBVNebmML/xCfyjYKdradtg6A05EZjwmOtlbW9IU/FQfZ3hW7j6QywZf9lsEtvSqqcODsMHELXvCs14hWXNlil/CvMEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595514625827548.6401077952235; Thu, 23 Jul 2020 07:30:25 -0700 (PDT) Received: from localhost ([::1]:52148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jycEp-00025F-Dl for importer@patchew.org; Thu, 23 Jul 2020 10:30:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jycCH-0006Ts-Sx for qemu-devel@nongnu.org; Thu, 23 Jul 2020 10:27:45 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:51017 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jycCG-0006x2-27 for qemu-devel@nongnu.org; Thu, 23 Jul 2020 10:27:45 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-cEPslwJ9N_W8pw3ZMJydGg-1; Thu, 23 Jul 2020 10:27:40 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EAF9C1DE9 for ; Thu, 23 Jul 2020 14:27:39 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD75919D7B; Thu, 23 Jul 2020 14:27:39 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 58EAC10A5B7A; Thu, 23 Jul 2020 16:27:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595514462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SxgpzSARUKg0APZeWeak/iVUy1+FhCYqHcriF0jmv2s=; b=Hgfpyk96xtxf8zHcmVmdTMzYQiWJ3dw9w3avu9io3iYGSrxPUZP9aBcp0lxARKpEiFyTTW NNIWMWN5wwumvcfVN+3quYUOhR/hCIEtEfZ7CEmYtVgtFp0Vq6XiCjnw9mFnTUzwKPJbmI pvmtZMvXiPmo2VnUS73H2A3qXOvUsrk= X-MC-Unique: cEPslwJ9N_W8pw3ZMJydGg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 3/3] scripts/qmp/qom-fuse: Fix getattr(), read() for files in / Date: Thu, 23 Jul 2020 16:27:38 +0200 Message-Id: <20200723142738.1868568-4-armbru@redhat.com> In-Reply-To: <20200723142738.1868568-1-armbru@redhat.com> References: <20200723142738.1868568-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/23 02:33:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jsnow@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" path, prop =3D "type".rsplit('/', 1) sets path to "", which doesn't work. Correct to "/". Signed-off-by: Markus Armbruster Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scripts/qmp/qom-fuse | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse index 405e6ebd67..7c7cff8edf 100755 --- a/scripts/qmp/qom-fuse +++ b/scripts/qmp/qom-fuse @@ -45,8 +45,10 @@ class QOMFS(Operations): return False =20 def is_property(self, path): + path, prop =3D path.rsplit('/', 1) + if path =3D=3D '': + path =3D '/' try: - path, prop =3D path.rsplit('/', 1) for item in self.qmp.command('qom-list', path=3Dpath): if item['name'] =3D=3D prop: return True @@ -55,8 +57,10 @@ class QOMFS(Operations): return False =20 def is_link(self, path): + path, prop =3D path.rsplit('/', 1) + if path =3D=3D '': + path =3D '/' try: - path, prop =3D path.rsplit('/', 1) for item in self.qmp.command('qom-list', path=3Dpath): if item['name'] =3D=3D prop: if item['type'].startswith('link<'): @@ -71,6 +75,8 @@ class QOMFS(Operations): return -ENOENT =20 path, prop =3D path.rsplit('/', 1) + if path =3D=3D '': + path =3D '/' try: data =3D self.qmp.command('qom-get', path=3Dpath, property=3Dp= rop) data +=3D '\n' # make values shell friendly --=20 2.26.2