From nobody Thu May 9 03:20:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595511164; cv=none; d=zohomail.com; s=zohoarc; b=HeY6vnPgebG1iTiYw+I4jtDw/rLsKA9xsm8hJK3kxQBXkjXLiQZhkwinp3xDMEtoVY6iPvqDDSR9vjwGbvOsu0jCFNB/vyVtYdUp5UUW9zMZWh6NQPF3w2cpOkAaA4vIs/Oevz+cak8p9Upl1JLQnB0p37GRdPe8sIeyRB318cQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595511164; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=69upIEPR5Rocv0K1dpgi2tOtNkX5hv5N+Y3yZWXm1yc=; b=a4bdUZ1vSKIZ1cfUjX1noXywIR/XR3rPLXoyWjfX1MivLzPHSuzg42NMiRB2Um7a1QXZBlqPeuPy2OoZT9/VEqs+Aa9LLj3fCCDZ9FKjPNuM+HHhKfm8WDtl7WQeW7hkRrAp9l7RYpiODJ5fqpYQ406/DRldTn+5oTbw5c11I8g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595511164547501.1224731655378; Thu, 23 Jul 2020 06:32:44 -0700 (PDT) Received: from localhost ([::1]:51568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jybL1-0006oD-78 for importer@patchew.org; Thu, 23 Jul 2020 09:32:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jybHs-0003LS-Fn for qemu-devel@nongnu.org; Thu, 23 Jul 2020 09:29:28 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:20109 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jybHo-0005PW-73 for qemu-devel@nongnu.org; Thu, 23 Jul 2020 09:29:28 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-449-RvDGOi_xOhG01FzAFjr62g-1; Thu, 23 Jul 2020 09:29:19 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C7F48014D7; Thu, 23 Jul 2020 13:29:18 +0000 (UTC) Received: from turbo.com (ovpn-113-141.ams2.redhat.com [10.36.113.141]) by smtp.corp.redhat.com (Postfix) with ESMTP id 801D85DEBA; Thu, 23 Jul 2020 13:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595510963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69upIEPR5Rocv0K1dpgi2tOtNkX5hv5N+Y3yZWXm1yc=; b=QrxhBLBSSGAs1RMHQfHcuLLQV+FcGUz7A9E0Pe55jF8BrUe209pUvSt/w0aJg7LyXX6oy1 9Dz7Hg9kkXktxOWHxXatlJtKeK++bIkaqnZk9bpuy1qQWdxgtpa17qXtLyuks5+lolUD4y c/IeU0psgXch//0ltYNYHyg/fJwBa2s= X-MC-Unique: RvDGOi_xOhG01FzAFjr62g-1 From: Christophe de Dinechin To: qemu-devel@nongnu.org Subject: [PATCH v4 1/2] trace: Add support for recorder back-end Date: Thu, 23 Jul 2020 15:29:02 +0200 Message-Id: <20200723132903.1980743-2-dinechin@redhat.com> In-Reply-To: <20200723132903.1980743-1-dinechin@redhat.com> References: <20200723132903.1980743-1-dinechin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=dinechin@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/23 02:26:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Tokarev , Markus Armbruster , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Christophe de Dinechin , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The recorder library provides support for low-cost continuous recording of events, which can then be replayed. This makes it possible to collect data after the fact, for example to show the events that led to a crash or unexpected condition. In this series, minimal recorder support in qemu is implemented using the existing tracing interface. For each trace, a corresponding recorder is created with a generic name and a default size of 8 entries. In addition, it is possible to explicitly enable recorders that are not qemu traces, for example in order to use actually record events rather than trace them, or to use the real-time graphing capabilities. For that reason, a limited set of recorder-related macros are defined as no-ops even if the recorder trace backend is not configured. Recorder-specific features, notably the ability to perform a post-mortem dump and to group traces by topic, are not integrated in this series, as doing so would require modifying the trace infrastructure, which is a non-objective here. This may be the topic of later series if there is any interest for it. HMP COMMAND: The 'recorder' hmp command has been added, which supports two sub-commands: * recorder dump: Dump the current state of the recorder. You can give that command a recorder name, to only dump that recorder. * recorder trace: Set traces using the recorder_trace_set() syntax. You can use "recorder trace help" to list all available recorders. Signed-off-by: Christophe de Dinechin --- MAINTAINERS | 1 + configure | 14 ++++++++ hmp-commands.hx | 23 +++++++++++- monitor/misc.c | 25 +++++++++++++ scripts/tracetool/backend/recorder.py | 52 +++++++++++++++++++++++++++ trace/Makefile.objs | 1 + trace/control.c | 5 +++ trace/recorder.c | 27 ++++++++++++++ trace/recorder.h | 32 +++++++++++++++++ util/module.c | 6 ++++ 10 files changed, 185 insertions(+), 1 deletion(-) create mode 100644 scripts/tracetool/backend/recorder.py create mode 100644 trace/recorder.c create mode 100644 trace/recorder.h diff --git a/MAINTAINERS b/MAINTAINERS index 3395abd4e1..764b5915d7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2484,6 +2484,7 @@ F: stubs/ Tracing M: Stefan Hajnoczi S: Maintained +R: Christophe de Dinechin F: trace/ F: trace-events F: docs/qemu-option-trace.rst.inc diff --git a/configure b/configure index 4bd80ed507..3770ff873d 100755 --- a/configure +++ b/configure @@ -7761,6 +7761,20 @@ fi if have_backend "log"; then echo "CONFIG_TRACE_LOG=3Dy" >> $config_host_mak fi +if have_backend "recorder"; then + recorder_minver=3D"1.0.10" + if $pkg_config --atleast-version=3D$recorder_minver recorder ; then + recorder_cflags=3D"$($pkg_config --cflags recorder)" + recorder_libs=3D"$($pkg_config --libs recorder)" + LIBS=3D"$recorder_libs $LIBS" + libs_qga=3D"$recorder_libs $libs_qga" + QEMU_CFLAGS=3D"$QEMU_CFLAGS $recorder_cflags" + zstd=3D"yes" + echo "CONFIG_TRACE_RECORDER=3Dy" >> $config_host_mak + else + feature_not_found "recorder" "Install recorder-devel package" + fi +fi if have_backend "ust"; then echo "CONFIG_TRACE_UST=3Dy" >> $config_host_mak fi diff --git a/hmp-commands.hx b/hmp-commands.hx index d548a3ab74..f164ff6d65 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -302,6 +302,28 @@ SRST Open, close, or flush the trace file. If no argument is given, the status of the trace file is displayed. ERST +#endif + +#if defined(CONFIG_TRACE_RECORDER) + { + .name =3D "recorder", + .args_type =3D "op:s?,arg:s?", + .params =3D "trace|dump [arg]", + .help =3D "trace selected recorders or print recorder dump", + .cmd =3D hmp_recorder, + }, + +SRST +``trace`` *cmds* + Activate or deactivate tracing for individual recorder traces. + See recorder_trace_set(3) for the syntax of *cmds* + For example, to activate trace ``foo`` and disable alll traces + ending in ``_warning``, use ``foo:.*_warning=3D0``. + Using ``help`` will list available traces and their current setting. +``dump`` [*name*] + Dump the recorder. If *name* is given, only the specific named recorder + will be dumped. +ERST #endif =20 { @@ -1828,4 +1850,3 @@ ERST .sub_table =3D hmp_info_cmds, .flags =3D "p", }, - diff --git a/monitor/misc.c b/monitor/misc.c index e847b58a8c..aff72158d7 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -60,6 +60,7 @@ #ifdef CONFIG_TRACE_SIMPLE #include "trace/simple.h" #endif +#include "trace/recorder.h" #include "exec/memory.h" #include "exec/exec-all.h" #include "qemu/option.h" @@ -226,6 +227,30 @@ static void hmp_trace_file(Monitor *mon, const QDict *= qdict) } #endif =20 +#ifdef CONFIG_TRACE_RECORDER +static void hmp_recorder(Monitor *mon, const QDict *qdict) +{ + const char *op =3D qdict_get_try_str(qdict, "op"); + const char *arg =3D qdict_get_try_str(qdict, "arg"); + + if (!op) { + monitor_printf(mon, "missing recorder command\"%s\"\n", op); + help_cmd(mon, "recorder"); + } else if (!strcmp(op, "trace")) { + recorder_trace_set(arg); + } else if (!strcmp(op, "dump")) { + if (!arg || !*arg) { + recorder_dump(); + } else { + recorder_dump_for(arg); + } + } else { + monitor_printf(mon, "unexpected recorder command \"%s\"\n", op); + help_cmd(mon, "recorder"); + } +} +#endif + static void hmp_info_help(Monitor *mon, const QDict *qdict) { help_cmd(mon, "info"); diff --git a/scripts/tracetool/backend/recorder.py b/scripts/tracetool/back= end/recorder.py new file mode 100644 index 0000000000..82d983ff31 --- /dev/null +++ b/scripts/tracetool/backend/recorder.py @@ -0,0 +1,52 @@ +# -*- coding: utf-8 -*- + +""" +Trace back-end for recorder library +""" + +__author__ =3D "Christophe de Dinechin " +__copyright__ =3D "Copyright 2020, Christophe de Dinechin and Red Hat" +__license__ =3D "GPL version 2 or (at your option) any later version" + +__maintainer__ =3D "Christophe de Dinechin" +__email__ =3D "christophe@dinechin.org" + + +from tracetool import out + +PUBLIC =3D True + +def generate_h_begin(events, group): + out('#include ', '') + + for event in events: + out('RECORDER_DECLARE(%(name)s);', name=3Devent.name) + + +def generate_h(event, group): + argnames =3D ", ".join(event.args.names()) + if len(event.args) > 0: + argnames =3D ", " + argnames + + out(' record(%(event)s, %(fmt)s %(argnames)s);', + event=3Devent.name, + fmt=3Devent.fmt.rstrip("\n"), + argnames=3Dargnames) + + +def generate_h_backend_dstate(event, group): + out(' RECORDER_TWEAK(%(event_id)s) || \\', event_id=3Devent.name) + +def generate_c_begin(events, group): + out('#include "qemu/osdep.h"', + '#include "trace/control.h"', + '#include "trace/simple.h"', + '#include ', + '') + + for event in events: + out('RECORDER_DEFINE(%(name)s, 8,', + ' "Tracetool recorder for %(api)s(%(args)s)");', + name=3Devent.name, + api=3Devent.api(), + args=3Devent.args) diff --git a/trace/Makefile.objs b/trace/Makefile.objs index c544509adf..13667e98d5 100644 --- a/trace/Makefile.objs +++ b/trace/Makefile.objs @@ -54,6 +54,7 @@ $(obj)/generated-tcg-tracers.h-timestamp: $(SRC_PATH)/tra= ce-events $(BUILD_DIR)/ =20 util-obj-$(CONFIG_TRACE_SIMPLE) +=3D simple.o util-obj-$(CONFIG_TRACE_FTRACE) +=3D ftrace.o +util-obj-$(CONFIG_TRACE_RECORDER) +=3D recorder.o util-obj-y +=3D control.o obj-y +=3D control-target.o util-obj-y +=3D qmp.o diff --git a/trace/control.c b/trace/control.c index 2ffe000818..71f170f73b 100644 --- a/trace/control.c +++ b/trace/control.c @@ -23,6 +23,7 @@ #ifdef CONFIG_TRACE_SYSLOG #include #endif +#include "trace/recorder.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "qemu/config-file.h" @@ -282,6 +283,10 @@ bool trace_init_backends(void) openlog(NULL, LOG_PID, LOG_DAEMON); #endif =20 +#ifdef CONFIG_TRACE_RECORDER + recorder_trace_init(); +#endif + return true; } =20 diff --git a/trace/recorder.c b/trace/recorder.c new file mode 100644 index 0000000000..c47abc363c --- /dev/null +++ b/trace/recorder.c @@ -0,0 +1,27 @@ +/* + * Recorder-based trace backend + * + * Copyright Red Hat 2020 + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + * + */ + +#include "qemu/osdep.h" +#include "trace/recorder.h" + +RECORDER_CONSTRUCTOR +void recorder_trace_init(void) +{ + const char *traces =3D getenv("RECORDER_TRACES"); + recorder_trace_set(traces); + + /* + * Allow a dump in case we receive some unhandled signal + * For example, send USR2 to a hung process to get a dump + */ + if (traces) { + recorder_dump_on_common_signals(0, 0); + } +} diff --git a/trace/recorder.h b/trace/recorder.h new file mode 100644 index 0000000000..e69f633437 --- /dev/null +++ b/trace/recorder.h @@ -0,0 +1,32 @@ +/* + * Recorder-based trace backend + * + * Copyright Red Hat 2020 + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + * + */ + +#ifndef TRACE_RECORDER_H +#define TRACE_RECORDER_H + +#ifdef CONFIG_TRACE_RECORDER + +#include + +extern void recorder_trace_init(void); + +#else + +/* Disable recorder macros */ +#define RECORDER(Name, Size, Description) +#define RECORDER_DEFINE(Name, Size, Description) +#define RECORDER_DECLARE(Name) +#define RECORD(Name, ...) +#define record(Name, ...) +#define recorder_trace_init() + +#endif /* CONFIG_TRACE_RECORDER */ + +#endif /* TRACE_RECORDER_H */ diff --git a/util/module.c b/util/module.c index 0ab00851f0..03179a09aa 100644 --- a/util/module.c +++ b/util/module.c @@ -22,6 +22,8 @@ #ifdef CONFIG_MODULE_UPGRADES #include "qemu-version.h" #endif +#include "trace/recorder.h" + =20 typedef struct ModuleEntry { @@ -150,6 +152,10 @@ static int module_load_file(const char *fname) g_module_close(g_module); ret =3D -EINVAL; } else { +#ifdef CONFIG_TRACE_RECORDER + /* New recorders may have been pulled in, activate them if necessa= ry */ + recorder_trace_init(); +#endif QTAILQ_FOREACH(e, &dso_init_list, node) { e->init(); register_module_init(e->init, e->type); --=20 2.26.2 From nobody Thu May 9 03:20:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595511095; cv=none; d=zohomail.com; s=zohoarc; b=enOJ3HUX83e4iyHdAo1PawAD5lToWOW1RBE3b7rw8iYzOkFL18I4LUQ5ZNQIndPA2swRPKla3kRAnbjR8AIJ1hekr7QSao/rpc4gW9oEDmbFlp4BuOE7kxsmeQI4RVCoiXWVnf3Atd/ECWfSAQIjcQuK4j10oOdhrqSBIceGArk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595511095; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3X7RJpzUMPF8J+wdkMnhsqm3/0vtWeM8YRC6/Q+/O3E=; b=n8pCuGseYvjB4/vrKSaIUHfKqAxQJo/xBw6HzXM1WR533J64OqWK/qC6swbpOybUM4Cix8RMB79VkFCRP2U4tozp/TqjCoLXJH8hWDfp5E9EpCC9Xy91jaivBqDy87H0X744AgSagd59JlsELZ5tDHOWEgDpKx51E4NYlD0T25Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595511095036561.1816332430894; Thu, 23 Jul 2020 06:31:35 -0700 (PDT) Received: from localhost ([::1]:47114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jybJp-00050C-NF for importer@patchew.org; Thu, 23 Jul 2020 09:31:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jybHr-0003Kj-QF for qemu-devel@nongnu.org; Thu, 23 Jul 2020 09:29:27 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:51758 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jybHo-0005PV-5k for qemu-devel@nongnu.org; Thu, 23 Jul 2020 09:29:27 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-B1yugL9gP_OgJH_uaqwYoA-1; Thu, 23 Jul 2020 09:29:21 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C2A057; Thu, 23 Jul 2020 13:29:20 +0000 (UTC) Received: from turbo.com (ovpn-113-141.ams2.redhat.com [10.36.113.141]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE6B85D9D3; Thu, 23 Jul 2020 13:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595510963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3X7RJpzUMPF8J+wdkMnhsqm3/0vtWeM8YRC6/Q+/O3E=; b=FtCXdq6DSutXnjdgIH9Z3PKO84j6wLqbjRD4YcM5lPkVuZl3F4sUAFiivKL2po+llUsFFM E5aVuyRLZpDUKHuhyyBLpnQuBrMpKk5yfeXUGmAanblf9JxCQBsfxxF8g7SIbobMTWPK98 0++qxYfUCUThqOC2nmNd6/nOTXVrkNI= X-MC-Unique: B1yugL9gP_OgJH_uaqwYoA-1 From: Christophe de Dinechin To: qemu-devel@nongnu.org Subject: [PATCH v4 2/2] trace: Example of non-tracing recorder use Date: Thu, 23 Jul 2020 15:29:03 +0200 Message-Id: <20200723132903.1980743-3-dinechin@redhat.com> In-Reply-To: <20200723132903.1980743-1-dinechin@redhat.com> References: <20200723132903.1980743-1-dinechin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dinechin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=dinechin@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/23 02:26:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Tokarev , Markus Armbruster , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Christophe de Dinechin , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This patch is a simple example showing how the recorder can be used to have one "topic" covering multiple entries. Here, the topic is "lock", the idea being to have the latest lock changes for instance in case of a crash or hang. Here are a few use cases: * Tracing lock updates: RECORDER_TRACES=3Dlock qemu * Showing lock changes prior to a hang RECORDER_TRACES=3Dlock qemu & # Wait until hang killall -USR2 qemu # This will trigger a dump * Graphic visualization of lock states: RECORDER_TRACES=3D"lock=3Dstate,id" qemu & recorder_scope state # Hit the 't' key to toggle timing display # Hit the 'c' key to dump the screen data as CSV cat recorder_scope_data-1.csv Signed-off-by: Christophe de Dinechin --- util/qemu-thread-common.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/util/qemu-thread-common.h b/util/qemu-thread-common.h index 2af6b12085..0de07a471f 100644 --- a/util/qemu-thread-common.h +++ b/util/qemu-thread-common.h @@ -15,6 +15,9 @@ =20 #include "qemu/thread.h" #include "trace.h" +#include "trace/recorder.h" + +RECORDER_DEFINE(lock, 16, "Lock state"); =20 static inline void qemu_mutex_post_init(QemuMutex *mutex) { @@ -23,12 +26,14 @@ static inline void qemu_mutex_post_init(QemuMutex *mute= x) mutex->line =3D 0; #endif mutex->initialized =3D true; + record(lock, "Init state %d for %p", -1, mutex); } =20 static inline void qemu_mutex_pre_lock(QemuMutex *mutex, const char *file, int line) { trace_qemu_mutex_lock(mutex, file, line); + record(lock, "Locking state %d for %p", 1, mutex); } =20 static inline void qemu_mutex_post_lock(QemuMutex *mutex, @@ -39,6 +44,7 @@ static inline void qemu_mutex_post_lock(QemuMutex *mutex, mutex->line =3D line; #endif trace_qemu_mutex_locked(mutex, file, line); + record(lock, "Locked state %d for %p", 2, mutex); } =20 static inline void qemu_mutex_pre_unlock(QemuMutex *mutex, @@ -49,6 +55,7 @@ static inline void qemu_mutex_pre_unlock(QemuMutex *mutex, mutex->line =3D 0; #endif trace_qemu_mutex_unlock(mutex, file, line); + record(lock, "Unkocked state %d for %p", 0, mutex); } =20 #endif --=20 2.26.2