From nobody Tue Feb 10 11:32:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1595399526; cv=none; d=zohomail.com; s=zohoarc; b=firo+Ob9udyn7lyPb0u6xvzGO3om/ALqRPnK/RYLsk5oxJWk8yx8NpveguvReSqn00iUqQAwnXcrHr5/WPhr0uMrhNrytCmCkfX+CSk9x2Wr9qxyEitd+QpUrUtEnpO0LWkUMvUkSgU808lfFt8B5smCf5+H+wR6dXsxByzTvD8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595399526; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wrFjogpJXlZ8LOQmtibpdguwXtzA6ik1VNS/5s1gAM8=; b=SCBJPhj6IX4HBAddQwieJ3suXE6EMI/uAuGEjXJDJIwtD2rJuHgyCERet8xvGVqDNoUVlt7xtzKYsZFJL3gE1YXD2CgwnLx2Lchc4Qxla0O1mC2c62AEpakDdH5j2CgZNiJ7Jd+bt0eOZMZIQl/cAVwgYxelqaEt7Ztj2rNTK+U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595399526494170.05684644657197; Tue, 21 Jul 2020 23:32:06 -0700 (PDT) Received: from localhost ([::1]:34958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jy8IP-0003Yl-9d for importer@patchew.org; Wed, 22 Jul 2020 02:32:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jy8Ff-00077Z-7k for qemu-devel@nongnu.org; Wed, 22 Jul 2020 02:29:15 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:46836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jy8Fd-0006v4-MF for qemu-devel@nongnu.org; Wed, 22 Jul 2020 02:29:14 -0400 Received: by mail-wr1-x441.google.com with SMTP id r12so676771wrj.13 for ; Tue, 21 Jul 2020 23:29:13 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f17sm6701806wme.14.2020.07.21.23.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 23:29:09 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8882A1FF92; Wed, 22 Jul 2020 07:29:03 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wrFjogpJXlZ8LOQmtibpdguwXtzA6ik1VNS/5s1gAM8=; b=hRWEUNjqFBP8p5+ZNl8s0EYl7uuSwwoO9YMjiG7lWAPH0Tc2v1EMZr0GOmChzGkVNh lnCAw6oLFnsEJ3roFRYkzXYYh/jNwKjHg0ZNAiAJPS+Hz+WbkX5uLcbyFKS4zV44nLzi DG+6PcsPdAr4l9x4MXyuouAtj6nJ/DXOOFp7bUCm5NGuzEQ6G6xYIkxO7GJ4cLy/3BUv fThc2YHKb+u9Bs//8m2QcxwbeEomnhO5DtAA8DBiEVxLjcdasZyBXv8u3191SHFWlxeC bmFk8eMKwuSVEXXhVWa6FEXnBkPJVbQTmc++eF6yXoXesYeigr7Tp7xCeuXco9x3vRmw pTYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wrFjogpJXlZ8LOQmtibpdguwXtzA6ik1VNS/5s1gAM8=; b=daYGmU5hRCtl1FTWxA/qk0xNOwR12OVPVLycLylXowyOIFogkbvxqpLAGgaNgFV9mM Hs96yPNgLtl++rkQ+MrzkgGGHI97f5KxjaqLkd32LutcaD6fBLpwDXnj1YipXHfzEdHz R2VXkv45ndjR6U6hXuw/z0FvveS2e9GRowWxYshwspd4Ti8yLMTD9jnPlxENgsonIDy4 tEhjDqe1gdC/SELoWOFOMwzcK1zGJPGj8soxOB3iG38648bVBcw53C1W3EwPDx9Zsx6V mm9IXPqQfCkW1gK4A0uYbTxmDUeZlvM4NhdHgunVQUHwrEf7Fu/V+zch8emO7ZVjnLdQ vxmQ== X-Gm-Message-State: AOAM533Fu95WKuwJc1UhF/5ul4zYPYNO6+ITKQYHrbtvKL60qYI7TV0t r+ga6pxzoX3Y3nap6lczptfzcg== X-Google-Smtp-Source: ABdhPJwBZuHuioDSq4Uh41Ngc8FuZgbRE/c46PCq0SgpYwEVXo2TRpaMOMG39WHPJSAuNX71sxChrQ== X-Received: by 2002:a5d:4649:: with SMTP id j9mr28136859wrs.270.1595399352430; Tue, 21 Jul 2020 23:29:12 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems Date: Wed, 22 Jul 2020 07:28:56 +0100 Message-Id: <20200722062902.24509-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200722062902.24509-1-alex.bennee@linaro.org> References: <20200722062902.24509-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , richard.henderson@linaro.org, f4bug@amsat.org, Christian Ehrhardt , cota@braap.org, Paolo Bonzini , aurelien@aurel32.net, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) It turns out there are some 64 bit systems that have relatively low amounts of physical memory available to them (typically CI system). Even with swapping available a 1GB translation buffer that fills up can put the machine under increased memory pressure. Detect these low memory situations and reduce tb_size appropriately. Fixes: 600e17b261 Signed-off-by: Alex Benn=C3=A9e Cc: BALATON Zoltan Cc: Christian Ehrhardt Message-Id: <20200717105139.25293-6-alex.bennee@linaro.org> --- v2 - /4 to /8 as suggested by Christian --- accel/tcg/translate-all.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 2afa46bd2b1..3fe40ec1710 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -976,7 +976,12 @@ static inline size_t size_code_gen_buffer(size_t tb_si= ze) { /* Size the buffer. */ if (tb_size =3D=3D 0) { - tb_size =3D DEFAULT_CODE_GEN_BUFFER_SIZE; + size_t phys_mem =3D qemu_get_host_physmem(); + if (phys_mem > 0 && phys_mem < (2 * DEFAULT_CODE_GEN_BUFFER_SIZE))= { + tb_size =3D phys_mem / 8; + } else { + tb_size =3D DEFAULT_CODE_GEN_BUFFER_SIZE; + } } if (tb_size < MIN_CODE_GEN_BUFFER_SIZE) { tb_size =3D MIN_CODE_GEN_BUFFER_SIZE; --=20 2.20.1