From nobody Mon Feb 9 08:55:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595346570; cv=none; d=zohomail.com; s=zohoarc; b=djueENj2debwWPcGXUvaZXFetkRLuWt23W33k1540yd6Z3J+2HgUyq2DxN31IXEBYHAOxMP3owJ+tgQy4DFkaRu8QfZslMjxcbN0NC4z+6eHhc6OPwfv1KyCG72outpEOUHRrHJl8p/3bqls4KIrN3339JF+Rj5OanETpRfqgyU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595346570; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tpMqYVwIHNV1hPTu7PzOkMnfmYQAMnojlVwxNhz4Fcs=; b=eXZJBOxW2Fkn9RZIVRa6JmRAxEXZRD0gBmPfSPb1C6icoRWpXhGgCZKTQYFkeabNI5ghbHCFuOYdryvujDzxjIBJhXhrodqQu7icEE+PUT27qmvVVwyl9g0zZUq3GYfj933o6czjHGg/ZcDRc7+2B8UtZWdswkRpbPFcrrL7yuo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595346570262471.35361399089504; Tue, 21 Jul 2020 08:49:30 -0700 (PDT) Received: from localhost ([::1]:38960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxuWH-0006UO-1j for importer@patchew.org; Tue, 21 Jul 2020 11:49:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxuTs-0004Wa-Nf for qemu-devel@nongnu.org; Tue, 21 Jul 2020 11:47:01 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:40970 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jxuTn-0001Kc-H9 for qemu-devel@nongnu.org; Tue, 21 Jul 2020 11:47:00 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-444-aPONNmW1NkCID-OsFsgvwg-1; Tue, 21 Jul 2020 11:46:52 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E56191272; Tue, 21 Jul 2020 15:46:51 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-113-97.ams2.redhat.com [10.36.113.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3CD8374F45; Tue, 21 Jul 2020 15:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595346414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tpMqYVwIHNV1hPTu7PzOkMnfmYQAMnojlVwxNhz4Fcs=; b=YFky4Paq5puwTtZvFUep2Cz3I8uJ8nPx8ae3QhBmovSi+EtWrxI30H7yD7UtJiPG/yhfQG H9Db7lIHHLMvZUiLrG5FsDOfz8jze/kcelvNFiua4DwodEZkhxt41YXIoE19vzLKcfHro6 f8bAeJKCHdKTCGt1nRVnQO5I+rYc0Z4= X-MC-Unique: aPONNmW1NkCID-OsFsgvwg-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 3/3] iotests: Test sparseness for qemu-img convert -n Date: Tue, 21 Jul 2020 17:46:37 +0200 Message-Id: <20200721154637.220022-4-kwolf@redhat.com> In-Reply-To: <20200721154637.220022-1-kwolf@redhat.com> References: <20200721154637.220022-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/21 10:17:05 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Kevin Wolf Message-Id: <20200721135520.72355-3-kwolf@redhat.com> Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/122 | 30 ++++++++++++++++++++++++++++++ tests/qemu-iotests/122.out | 17 +++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/tests/qemu-iotests/122 b/tests/qemu-iotests/122 index dfd1cd05d6..0f3d4ca851 100755 --- a/tests/qemu-iotests/122 +++ b/tests/qemu-iotests/122 @@ -281,6 +281,36 @@ $QEMU_IMG convert -O $IMGFMT -n "$TEST_IMG" "$TEST_IMG= ".orig =20 $QEMU_IMG compare "$TEST_IMG" "$TEST_IMG".orig =20 +echo +echo '=3D=3D=3D -n to an empty image =3D=3D=3D' +echo + +TEST_IMG=3D"$TEST_IMG".orig _make_test_img 64M + +# Convert with -n, which should not result in a fully allocated image, not= even +# with compat=3D0.10 (because the target doesn't have a backing file) +for compat in "1.1" "0.10"; do + IMGOPTS=3D"compat=3D$compat" _make_test_img 64M + $QEMU_IMG convert -O $IMGFMT -n "$TEST_IMG".orig "$TEST_IMG" + $QEMU_IMG map --output=3Djson "$TEST_IMG" +done + +echo +echo '=3D=3D=3D -n to an empty image with a backing file =3D=3D=3D' +echo + +TEST_IMG=3D"$TEST_IMG".orig _make_test_img 64M +TEST_IMG=3D"$TEST_IMG".base _make_test_img 64M + +# Convert with -n, which should still not result in a fully allocated imag= e for +# compat=3D1.1 (because it can use zero clusters), but it should be fully +# allocated with compat=3D0.10 +for compat in "1.1" "0.10"; do + IMGOPTS=3D"compat=3D$compat" _make_test_img -b "$TEST_IMG".base -F $IM= GFMT 64M + $QEMU_IMG convert -O $IMGFMT -n "$TEST_IMG".orig "$TEST_IMG" + $QEMU_IMG map --output=3Djson "$TEST_IMG" +done + echo echo '=3D=3D=3D -n -B to an image without a backing file =3D=3D=3D' echo diff --git a/tests/qemu-iotests/122.out b/tests/qemu-iotests/122.out index f1f195ed77..3a3e121d57 100644 --- a/tests/qemu-iotests/122.out +++ b/tests/qemu-iotests/122.out @@ -229,6 +229,23 @@ wrote 65536/65536 bytes at offset 0 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) Images are identical. =20 +=3D=3D=3D -n to an empty image =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT.orig', fmt=3DIMGFMT size=3D67108864 +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864 +[{ "start": 0, "length": 67108864, "depth": 0, "zero": true, "data": false= }] +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864 +[{ "start": 0, "length": 67108864, "depth": 0, "zero": true, "data": false= }] + +=3D=3D=3D -n to an empty image with a backing file =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT.orig', fmt=3DIMGFMT size=3D67108864 +Formatting 'TEST_DIR/t.IMGFMT.base', fmt=3DIMGFMT size=3D67108864 +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864 backing_file= =3DTEST_DIR/t.IMGFMT.base backing_fmt=3DIMGFMT +[{ "start": 0, "length": 67108864, "depth": 0, "zero": true, "data": false= }] +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864 backing_file= =3DTEST_DIR/t.IMGFMT.base backing_fmt=3DIMGFMT +[{ "start": 0, "length": 67108864, "depth": 0, "zero": false, "data": true= , "offset": 327680}] + =3D=3D=3D -n -B to an image without a backing file =3D=3D=3D =20 Formatting 'TEST_DIR/t.IMGFMT.base', fmt=3DIMGFMT size=3D67108864 --=20 2.25.4