From nobody Sat Nov 15 14:14:02 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595345201; cv=none; d=zohomail.com; s=zohoarc; b=Fmq58EFV8bTI295LEu14s28T/voi/3OU5GwFFligAQ1Pi09XzaMTs+nYYBgT7IpK+Qb9Z7Vb/7cMlFcVlaorZ8Uk6q9GMRFEfuuK91C3mZ1LkXIMEoDVjQXAtClFdF67mPGUi3THttuJDcP9SpqWq9XzeH+XpMEOxfsN07BNSCM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595345201; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Kzqnx7M6zwJInVJZpNTEOqJxtMao4B8ECDMsHUb093I=; b=QTspZlBs1vvyPoUuorNmyfiBqGqtsXqGTY+4FvxTRWF41maQGSEx63xoDfLlLy62EeVp5k2Ay1OB2cAmitHFBIBxqgVClexGDpC/kWbRvoq9wufRLBxUQ4PmzWps7r1e6uxBLEAre4GXEsojdF5FzruqUUMWsF45KIhMfHEKWoY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595345201251792.4270671638849; Tue, 21 Jul 2020 08:26:41 -0700 (PDT) Received: from localhost ([::1]:32964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxuAC-0007Un-0V for importer@patchew.org; Tue, 21 Jul 2020 11:26:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxu96-0006Xx-IW for qemu-devel@nongnu.org; Tue, 21 Jul 2020 11:25:32 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:37048 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jxu95-0005ij-1f for qemu-devel@nongnu.org; Tue, 21 Jul 2020 11:25:32 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-pJ1J6_ZgP3ifL5idkoqXDg-1; Tue, 21 Jul 2020 11:25:27 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FADB1005504; Tue, 21 Jul 2020 15:25:26 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D50F76216; Tue, 21 Jul 2020 15:25:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D931010F5AF1; Tue, 21 Jul 2020 17:25:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595345130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kzqnx7M6zwJInVJZpNTEOqJxtMao4B8ECDMsHUb093I=; b=CJNQ+uTNeeZAuS0vSdk/ba3w9CqIhTalWo7GXLDYr4MgAcyUKQH8I2h8DhVqfPOhoSHthJ lMsDp1Een82dcHlQ6qlxBHVqjkfOBqcmuIJ0I10xzfKYVmlLwlAF2x/tpajaQutqKgdS0l 8YrDSnlYxG96tyYPSXFoMGk2WBRnSNI= X-MC-Unique: pJ1J6_ZgP3ifL5idkoqXDg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 1/1] qdev: Fix device_add DRIVER,help to print to monitor Date: Tue, 21 Jul 2020 17:25:21 +0200 Message-Id: <20200721152521.1578693-2-armbru@redhat.com> In-Reply-To: <20200721152521.1578693-1-armbru@redhat.com> References: <20200721152521.1578693-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/21 10:15:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Li Qiang , qemu-stable@nongnu.org, "Dr . David Alan Gilbert" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Help on device properties gets printed to stdout instead of the monitor. If you have the monitor anywhere else, no help for you. Broken when commit e1043d674d "qdev: use object_property_help()" accidentally switched from qemu_printf() to printf(). Switch right back. Fixes: e1043d674d792ff64aebae1a3eafc08b38a8a085 Cc: Marc-Andr=C3=A9 Lureau Cc: qemu-stable@nongnu.org Signed-off-by: Markus Armbruster Message-Id: <20200714160202.3121879-2-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Li Qiang Reviewed-by: Dr. David Alan Gilbert --- qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 71ebce19df..e9b7228480 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -300,7 +300,7 @@ int qdev_device_help(QemuOpts *opts) } g_ptr_array_sort(array, (GCompareFunc)qemu_pstrcmp0); for (i =3D 0; i < array->len; i++) { - printf("%s\n", (char *)array->pdata[i]); + qemu_printf("%s\n", (char *)array->pdata[i]); } g_ptr_array_set_free_func(array, g_free); g_ptr_array_free(array, true); --=20 2.26.2