From nobody Tue Feb 10 03:37:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595340228; cv=none; d=zohomail.com; s=zohoarc; b=L8jZE3R4LOC6DbgJ7FIg3FLtH3HwvlozB4JAd8R1kVA8D5tAqdRDy6NctOy+PdUPmysvkEMiL1f3jybFKnLP2MOHPkrYlvyxFRFrCvs9fjcUS/221iOp/tGsO7XYTzCBHNDL1mhQ3C7cLmgzCWUSEuUY8l7yhViH7F4D5dAh87Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595340228; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1Tvv259nl6Wb3MOWCMuYj/NBbGmBLRDaD8BYDWIbo9U=; b=WnFkmMJWSJlD7tBuxExWYk/csNOlXCa2GDSo6RjZC5XTl6BdrQnxrBaqdLJn1lstAK0KJu5WSXmhFgpc30M4HNugzlrp7YK+A2MrwyVnDfx5ehPiVgYIoZ/gyhUMYxmtbEYP1sKNwhKBKgBii/zmZSvPcjlrR0AelKYJjOFNkFY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595340228900459.168547460911; Tue, 21 Jul 2020 07:03:48 -0700 (PDT) Received: from localhost ([::1]:48434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxsrz-00030j-KK for importer@patchew.org; Tue, 21 Jul 2020 10:03:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxsr9-0001kz-59 for qemu-devel@nongnu.org; Tue, 21 Jul 2020 10:02:55 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:40608 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jxsr7-0008S3-GK for qemu-devel@nongnu.org; Tue, 21 Jul 2020 10:02:54 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-rhCv3QOENKm-OsTMkg0Ruw-1; Tue, 21 Jul 2020 10:02:50 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D95091902EB6 for ; Tue, 21 Jul 2020 14:02:49 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-115-89.ams2.redhat.com [10.36.115.89]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC92A7268D; Tue, 21 Jul 2020 14:02:46 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E60D79DA0; Tue, 21 Jul 2020 16:02:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595340172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Tvv259nl6Wb3MOWCMuYj/NBbGmBLRDaD8BYDWIbo9U=; b=f0MpMGi1HVq9+etiUPG6NJ8WKeHx1DZ8hAb0ceh4LckZOXWDnni/J5SyUlRuipkyfmGwql SMv64kKWZWnNse/2oENhU/tC4Vhp4UDyLj/ngTTdr3AtYtvWq/yibFeFErG7KTgHBV5qJ6 TUqsmHhrJ06RYurIj2KrzLmJH3fMf9I= X-MC-Unique: rhCv3QOENKm-OsTMkg0Ruw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 1/3] xhci: fix valid.max_access_size to access address registers Date: Tue, 21 Jul 2020 16:02:43 +0200 Message-Id: <20200721140245.14634-2-kraxel@redhat.com> In-Reply-To: <20200721140245.14634-1-kraxel@redhat.com> References: <20200721140245.14634-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/21 03:39:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Laurent Vivier QEMU XHCI advertises AC64 (64-bit addressing) but doesn't allow 64-bit mode access in "runtime" and "operational" MemoryRegionOps. Set the max_access_size based on sizeof(dma_addr_t) as AC64 is set. XHCI specs: "If the xHC supports 64-bit addressing (AC64 =3D =E2=80=981=E2=80=99), then= software should write 64-bit registers using only Qword accesses. If a system is incapable of issuing Qword accesses, then writes to the 64-bit address fields shall be performed using 2 Dword accesses; low Dword-first, high-Dword second. If the xHC supports 32-bit addressing (AC64 =3D =E2=80=980=E2=80=99), then the high Dword of registers= containing 64-bit address fields are unused and software should write addresses using only Dword accesses" The problem has been detected with SLOF, as linux kernel always accesses registers using 32-bit access even if AC64 is set and revealed by 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_r= egion_access_valid"") Suggested-by: Alexey Kardashevskiy Signed-off-by: Laurent Vivier Message-id: 20200721083322.90651-1-lvivier@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index b330e36fe6cc..67a18fe2b64c 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -3184,7 +3184,7 @@ static const MemoryRegionOps xhci_oper_ops =3D { .read =3D xhci_oper_read, .write =3D xhci_oper_write, .valid.min_access_size =3D 4, - .valid.max_access_size =3D 4, + .valid.max_access_size =3D sizeof(dma_addr_t), .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 @@ -3200,7 +3200,7 @@ static const MemoryRegionOps xhci_runtime_ops =3D { .read =3D xhci_runtime_read, .write =3D xhci_runtime_write, .valid.min_access_size =3D 4, - .valid.max_access_size =3D 4, + .valid.max_access_size =3D sizeof(dma_addr_t), .endianness =3D DEVICE_LITTLE_ENDIAN, }; =20 --=20 2.18.4