From nobody Sun Feb 8 18:45:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595332340; cv=none; d=zohomail.com; s=zohoarc; b=V35XImq/IGeM7nGIXTgh5RnrBBpvUgJSRobdq9+bAOP35pyFIYDltX+QBvQbQk9uhf0IJxpnc0TcsI1yfVKN1NenCywrbXotI8M6vYrGuFRu4yFfm7TyiyM++U6YaQ2CfAjsjH2TFxJyUwtG/62PUQT9ptxP5MSHKIQdpayT8no= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595332340; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LO2o6iouqBBqtiAy+J1nbi0a6TP3rCZ4xkeB4F6aIr0=; b=mm29Hy31MC7z/0IYyPAiyKHykhI9ZAaFD19tf454Ocv9fYjoizDlkzV77RTZ9oVYdOweIFZ88JkQdmHAlXbTluQLxcyl38C+PvF38b4TPj29IVKVLi9/ILBTnwkUzXoQTtoZp65+5LJeRk4XoQUSlmyUs7L5SQdOFLZ3usXN6Xw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159533234013653.72722449519733; Tue, 21 Jul 2020 04:52:20 -0700 (PDT) Received: from localhost ([::1]:42452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxqok-0000nV-Uq for importer@patchew.org; Tue, 21 Jul 2020 07:52:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxqm7-0005Un-3j for qemu-devel@nongnu.org; Tue, 21 Jul 2020 07:49:35 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:20125 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jxqm4-00064V-5V for qemu-devel@nongnu.org; Tue, 21 Jul 2020 07:49:34 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-2Co-EZb5OdiCTmbyd-PKxQ-1; Tue, 21 Jul 2020 07:49:29 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E0D4100AA44; Tue, 21 Jul 2020 11:49:28 +0000 (UTC) Received: from localhost (ovpn-113-68.ams2.redhat.com [10.36.113.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B71C1872E6; Tue, 21 Jul 2020 11:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595332171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LO2o6iouqBBqtiAy+J1nbi0a6TP3rCZ4xkeB4F6aIr0=; b=cHIObmrI//RpRqDvtaLcusfCrj27e29ghc87lGhlA/+96MPzYdodu4M7xk5hs6zmQQ8L2Q 8rYIFFupcDtOzp/CAAKjnFqpKcRsH0SXTI1jyola3FcIhpgW6EMpH1QzlwvtiucCp/Dqr3 T44ybBI7m932Y7Xn25/wGYLddjnQP/w= X-MC-Unique: 2Co-EZb5OdiCTmbyd-PKxQ-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 1/3] block/crypto: disallow write sharing by default Date: Tue, 21 Jul 2020 13:49:18 +0200 Message-Id: <20200721114920.1174149-2-mreitz@redhat.com> In-Reply-To: <20200721114920.1174149-1-mreitz@redhat.com> References: <20200721114920.1174149-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/21 01:26:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Maxim Levitsky My commit 'block/crypto: implement the encryption key management' accidently allowed raw luks images to be shared between different qemu processes without share-rw=3Don explicit override. Fix that. Fixes: bbfdae91fb ("block/crypto: implement the encryption key management") Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=3D1857490 Signed-off-by: Maxim Levitsky Message-Id: <20200719122059.59843-2-mlevitsk@redhat.com> Signed-off-by: Max Reitz --- block/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/crypto.c b/block/crypto.c index 8725c1bc02..0807557763 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -881,7 +881,7 @@ block_crypto_child_perms(BlockDriverState *bs, BdrvChil= d *c, * For backward compatibility, manually share the write * and resize permission */ - *nshared |=3D (BLK_PERM_WRITE | BLK_PERM_RESIZE); + *nshared |=3D shared & (BLK_PERM_WRITE | BLK_PERM_RESIZE); /* * Since we are not fully a format driver, don't always request * the read/resize permission but only when explicitly --=20 2.26.2