From nobody Sun Feb 8 23:32:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1595261507; cv=none; d=zohomail.com; s=zohoarc; b=eTD2bfZBhbci+8MDIs1xVw5LlVkMCZjdY6liPe5lnEdsWvwXJjLIahRhQ+lfx4pH5hLEO4A+0VfriBc5GLjVOJrqg+q6W5vV4CG3//xtomspIpIncd2HD+f1q1er/6PFi231o8vP4jCF+Gse1Qn1fDuYUs3oeNJ4AdsAw35c1hE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595261507; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ZF+eu0jUIxd21IiaLnr8+1/YgoizOD4uaBV7dz+qcJQ=; b=SJ47SdQyhaTm3OEbzvbxvPbj+kzyOvdT+jKU/FLMaAV4Z2gJPpJYHSi5YrlssjxqwKQ+mmR2cUjzgZKheUI6YsUvRbMZAtVY2NDrtogVeBcrHsvbZE7tfLssqRsH3yI8ikJgawjAKKX+04N3LBcw0HLRs8v3E/kYq4w2BIa5VkE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595261507012123.39827362081337; Mon, 20 Jul 2020 09:11:47 -0700 (PDT) Received: from localhost ([::1]:42546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxYOH-0001Zh-EK for importer@patchew.org; Mon, 20 Jul 2020 12:11:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxYJN-0006cB-DK for qemu-devel@nongnu.org; Mon, 20 Jul 2020 12:06:41 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:37267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxYJL-0002on-4C for qemu-devel@nongnu.org; Mon, 20 Jul 2020 12:06:41 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id B0C2640547; Mon, 20 Jul 2020 19:06:35 +0300 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id 1544DA4; Mon, 20 Jul 2020 19:06:35 +0300 (MSK) Received: (nullmailer pid 15538 invoked by uid 1000); Mon, 20 Jul 2020 16:06:34 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org, "Michael S . Tsirkin" Subject: [PATCH for-5.1] acpi: accept byte and word access to core ACPI registers Date: Mon, 20 Jul 2020 19:06:27 +0300 Message-Id: <20200720160627.15491-1-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/20 10:57:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon John , Michael Tokarev Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" All ISA registers should be accessible as bytes, words or dwords (if wide enough). Fix the access constraints for acpi-pm-evt, acpi-pm-tmr & acpi-cnt registers. Fixes: 5d971f9e67 (memory: Revert "memory: accept mismatching sizes in memo= ry_region_access_valid") Fixes: afafe4bbe0 (apci: switch cnt to memory api) Fixes: 77d58b1e47 (apci: switch timer to memory api) Fixes: b5a7c024d2 (apci: switch evt to memory api) Buglink: https://lore.kernel.org/xen-devel/20200630170913.123646-1-anthony.= perard@citrix.com/T/ Buglink: https://bugs.debian.org/964793 BugLink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D964247 BugLink: https://bugs.launchpad.net/bugs/1886318 Reported-By: Simon John Signed-off-by: Michael Tokarev --- hw/acpi/core.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index f6d9ec4f13..ac06db3450 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -458,7 +458,8 @@ static void acpi_pm_evt_write(void *opaque, hwaddr addr= , uint64_t val, static const MemoryRegionOps acpi_pm_evt_ops =3D { .read =3D acpi_pm_evt_read, .write =3D acpi_pm_evt_write, - .valid.min_access_size =3D 2, + .impl.min_access_size =3D 2, + .valid.min_access_size =3D 1, .valid.max_access_size =3D 2, .endianness =3D DEVICE_LITTLE_ENDIAN, }; @@ -527,7 +528,8 @@ static void acpi_pm_tmr_write(void *opaque, hwaddr addr= , uint64_t val, static const MemoryRegionOps acpi_pm_tmr_ops =3D { .read =3D acpi_pm_tmr_read, .write =3D acpi_pm_tmr_write, - .valid.min_access_size =3D 4, + .impl.min_access_size =3D 4, + .valid.min_access_size =3D 1, .valid.max_access_size =3D 4, .endianness =3D DEVICE_LITTLE_ENDIAN, }; @@ -599,7 +601,8 @@ static void acpi_pm_cnt_write(void *opaque, hwaddr addr= , uint64_t val, static const MemoryRegionOps acpi_pm_cnt_ops =3D { .read =3D acpi_pm_cnt_read, .write =3D acpi_pm_cnt_write, - .valid.min_access_size =3D 2, + .impl.min_access_size =3D 2, + .valid.min_access_size =3D 1, .valid.max_access_size =3D 2, .endianness =3D DEVICE_LITTLE_ENDIAN, }; --=20 2.20.1