From nobody Sat Nov 15 13:23:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1595259831; cv=none; d=zohomail.com; s=zohoarc; b=HcpHh2/jaY4kBkmaZRYmhnEUVwfJC8BX/yqW6TJl1d+mq9dmgQxrkyQD0cVeNU38HeHajMz9aG6hNPYBZFxNd77ghjZqpLgnfBsUIOwdCiR+LFFdDKjl6hTmkJXXr/tbMQFvtjvkRbNCOg8dTXu/Uf/yEK8rKbgSnYO6oVNyZWY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595259831; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=krNQw1D4/VQ4QZINCxDJ1YTUih0FmA9NplhlZ+iz59Y=; b=Vhyn9V2iiTrC6HOwUPvUHWl1gjY1StxeiH0eYfBIRCbNXnGq6H7l3UywxpZvJaQTnK95xFRZGE7h/gyzSqH2qhjswWnZ0fgx1+qcARj3InGLpRn2hI4oe/xulJUU/llyTIU9SKi3KForWFCl/QecFgBAFiTWj51ba4NhywERfzo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159525983188055.99618794147966; Mon, 20 Jul 2020 08:43:51 -0700 (PDT) Received: from localhost ([::1]:54016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxXxE-0006bo-Ee for importer@patchew.org; Mon, 20 Jul 2020 11:43:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxXsw-0005hr-7Y for qemu-devel@nongnu.org; Mon, 20 Jul 2020 11:39:22 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:45077) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxXsu-0007k9-3y for qemu-devel@nongnu.org; Mon, 20 Jul 2020 11:39:21 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 37FA440547; Mon, 20 Jul 2020 18:39:17 +0300 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id C412DA4; Mon, 20 Jul 2020 18:39:17 +0300 (MSK) Received: (nullmailer pid 12314 invoked by uid 1000); Mon, 20 Jul 2020 15:39:17 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org, "Michael S . Tsirkin" Subject: [PATCH for-5.1] acpi: allow accessing acpi-cnt register by byte Date: Mon, 20 Jul 2020 18:39:15 +0300 Message-Id: <20200720153915.12267-1-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/20 10:57:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Tokarev Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From the ACPI spec (4.8.3.2.1 PM1 Control Registers): Register Location: System I/O or Memory Space Default Value: 00h Attribute: Read/Write Size: PM1_CNT_LEN (2 bytes) The PM1 control registers contain the fixed hardware feature control bits. These bits can be split between two registers: PM1a_CNT or PM1b_CNT. Each register grouping can be at a different 32-bit aligned address and is pointed to by the PM1a_CNT_BLK or PM1b_CNT_BLK. The values for these pointers to the register space are found in the FADT. Accesses to PM1 control registers are accessed through byte and word accesses. So allow 1-byte access too, not only 2-byte. Fixes: afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 Fixes: 5d971f9e672507210e77d020d89e0e89165c8fc9 Buglink: https://lore.kernel.org/xen-devel/20200630170913.123646-1-anthony.= perard@citrix.com/T/ Buglink: https://bugs.debian.org/964793 Signed-off-by: Michael Tokarev --- hw/acpi/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index f6d9ec4f13..2c1199d9dc 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -599,7 +599,8 @@ static void acpi_pm_cnt_write(void *opaque, hwaddr addr= , uint64_t val, static const MemoryRegionOps acpi_pm_cnt_ops =3D { .read =3D acpi_pm_cnt_read, .write =3D acpi_pm_cnt_write, - .valid.min_access_size =3D 2, + .impl.min_access_size =3D 2, + .valid.min_access_size =3D 1, .valid.max_access_size =3D 2, .endianness =3D DEVICE_LITTLE_ENDIAN, }; --=20 2.20.1