From nobody Sat Nov 15 14:48:14 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595242984; cv=none; d=zohomail.com; s=zohoarc; b=K3UCQ0aqiUVD+I7+3Om5eQ7Bc10MgOaAmuIC+ndD6e/AzDXhW26ZGM4jmF3tf3YdymVLlAqii9KHmcMLZgA/oD+ILWKj3rADphrUHLWXFwAOXuxJoAXE6jLjBi+lHXPYOgryux1pFwAhOxUs0R7lFrAd3WbD1ie3raN3Q5zZBRA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595242984; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=nkxkRkVdp3nv9/qR/smaXle784CAD1lUo4UnYDeb+6o=; b=aMt9DlQG12HqmomJuEGLE8ahY2+m+nMduiTDn8FoNw9MSat9Ob+7fg1mFnCIzliQPS82ivMhecBHMV+KTCWoy79peTXgwl63DJ03mdV8Ksm9Q8Sjta089Q9bwbPqYVPn6ecTBq2x9JTA/Fv8Rot8vK0tNcBvKXZPLB6RF5+H3R8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595242984455772.8826745729934; Mon, 20 Jul 2020 04:03:04 -0700 (PDT) Received: from localhost ([::1]:52536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxTZW-0005cW-VQ for importer@patchew.org; Mon, 20 Jul 2020 07:03:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxTYF-0004Qw-6e for qemu-devel@nongnu.org; Mon, 20 Jul 2020 07:01:43 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:42953 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jxTYD-0008OU-My for qemu-devel@nongnu.org; Mon, 20 Jul 2020 07:01:42 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-Z2v6h9OVM5S0AWenjWtaiw-1; Mon, 20 Jul 2020 07:01:39 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 66C2E100AA21; Mon, 20 Jul 2020 11:01:38 +0000 (UTC) Received: from thuth.com (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 291705D9E4; Mon, 20 Jul 2020 11:01:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595242901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=nkxkRkVdp3nv9/qR/smaXle784CAD1lUo4UnYDeb+6o=; b=Dr4mAofx8psuvcROCBYO5xVMKgKIgBth0KGPN3uQF8VmNjs/JJhoUeVf5HEdg32e8Q3CzQ ImwKmQ26Q10ak7iLt2trxKlnswsko1HGKp4lUEe9HjUaQ/XTN0EFmXYhhtg/6FDqYaIZR1 VrT2nUQ+ii68gys2S/1djNESBp1oQxk= X-MC-Unique: Z2v6h9OVM5S0AWenjWtaiw-1 From: Thomas Huth To: qemu-devel@nongnu.org, Michael Roth Subject: [PATCH for-5.2 1/3] qga/qapi-schema: Document -1 for invalid PCI address fields Date: Mon, 20 Jul 2020 13:01:31 +0200 Message-Id: <20200720110133.4366-2-thuth@redhat.com> In-Reply-To: <20200720110133.4366-1-thuth@redhat.com> References: <20200720110133.4366-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/19 21:45:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The "guest-get-fsinfo" could also be used for non-PCI devices in the future. And the code in GuestPCIAddress() in qga/commands-win32.c seems to be using "-1" for fields that it can not determine already. Thus let's properly document "-1" as value for invalid PCI address fields. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 --- qga/qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 4be9aad48e..408a662ea5 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -846,7 +846,7 @@ ## # @GuestDiskAddress: # -# @pci-controller: controller's PCI address +# @pci-controller: controller's PCI address (fields are set to -1 if inval= id) # @bus-type: bus type # @bus: bus id # @target: target id --=20 2.18.1