From nobody Tue Oct 7 14:31:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595161340; cv=none; d=zohomail.com; s=zohoarc; b=GuY1AZgbfIXQmN7Rm7QXKRNQ9XgnwQn/lkohAH2lr6sE9FYgx2yq8qgyFWUcM3w3yR4t0bGQz+isfSWRIq10GUSRhDHGyyakOqb7uziXbGcENBAisUFxSPRXBuwNWoYmtrMMfUkPkym771mWKhiiXVVZ4AW4KINoKzN++qidUYs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595161340; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=alYqC84muLQevxZ82fedJnoCADT3nLXoBULMpr364og=; b=Yx7ksXiQda2PFjXvT0NfuZSt9tPvCcn31B3Dpv4att1aY2/gVZPjf8MxU5a5gMYZ2GJ0vSJWu2OPGz1vfG9uJBO/BeB0KLZUR0m/ytAFYr4Wj3nHIWLfxNX/w2aRqcT21RVmjubFdQhbDnLum1wporANsrKL0xbbPp6PvyuSb7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1595161340688418.75910779820845; Sun, 19 Jul 2020 05:22:20 -0700 (PDT) Received: from localhost ([::1]:59488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jx8Kg-0006O9-Vl for importer@patchew.org; Sun, 19 Jul 2020 08:22:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jx8Jd-0005Nd-A5 for qemu-devel@nongnu.org; Sun, 19 Jul 2020 08:21:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:47336 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jx8Ja-0006Yb-13 for qemu-devel@nongnu.org; Sun, 19 Jul 2020 08:21:12 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-454-P11Zs-twMuqhGbdpaiJ9NQ-1; Sun, 19 Jul 2020 08:21:06 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C7FE419057A1; Sun, 19 Jul 2020 12:21:04 +0000 (UTC) Received: from starship.redhat.com (unknown [10.35.206.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EB035D9CC; Sun, 19 Jul 2020 12:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595161268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=alYqC84muLQevxZ82fedJnoCADT3nLXoBULMpr364og=; b=Obls9o5PkZidH1KrLf02hEe6F9CL5Z1EeL3Zsbv8+aNKepVnH1fqcDsSYnJSBPHB6AUqx6 gUqS0j1D4PqjKVKILaWlcFITo3TOLvMEJeaj0v5xJCXQD7s3vUsIcPwojwLmUXb52l+UV0 kKR+OVRVdE0kORtDsGGKklWeVkKJT4A= X-MC-Unique: P11Zs-twMuqhGbdpaiJ9NQ-1 From: Maxim Levitsky To: qemu-devel@nongnu.org Subject: [PATCH 1/2] block/crypto: disallow write sharing by default Date: Sun, 19 Jul 2020 15:20:58 +0300 Message-Id: <20200719122059.59843-2-mlevitsk@redhat.com> In-Reply-To: <20200719122059.59843-1-mlevitsk@redhat.com> References: <20200719122059.59843-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=mlevitsk@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/19 08:21:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Maxim Levitsky , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" My commit 'block/crypto: implement the encryption key management' accidently allowed raw luks images to be shared between different qemu processes without share-rw=3Don explicit override. Fix that. Fixes: bbfdae91fb ("block/crypto: implement the encryption key management") Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=3D1857490 Signed-off-by: Maxim Levitsky --- block/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/crypto.c b/block/crypto.c index 8725c1bc02..0807557763 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -881,7 +881,7 @@ block_crypto_child_perms(BlockDriverState *bs, BdrvChil= d *c, * For backward compatibility, manually share the write * and resize permission */ - *nshared |=3D (BLK_PERM_WRITE | BLK_PERM_RESIZE); + *nshared |=3D shared & (BLK_PERM_WRITE | BLK_PERM_RESIZE); /* * Since we are not fully a format driver, don't always request * the read/resize permission but only when explicitly --=20 2.26.2