From nobody Mon Feb 9 00:02:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594979905; cv=none; d=zohomail.com; s=zohoarc; b=TJKpVAIqhHfEelabeZASD3C449Mzqf1UtlGiDgPMuh0Kx6A3c86sWP5fWVFB6wdmGhV5PVXKKR6i78uZiIdlnOXq1dYSENeM1VrH+E96mUYJQ31J6XM/wNZEsogleNcXP/fYj/kY6LJoVs23m6FgFq0hG+DqOpVa9YcblvXM+ok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594979905; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HMyJ54H0zE5Lwb742MXdkIKrAmqMlGaD0MBhncrOAaY=; b=iBZoKQxSl8es+3Xmx+ypBeU0hXh8fOnByd4ZWPzUX13dlva9Lk2Ui7Z2jGXL3C3Cu0N+iVuAIkoraIZvGuZths/LxzzU36a+PXvIuuUYD8Skx2FqIMxcf/Ls/p0Shb99LnHMPCEl3+KTSLKUgxrA+xGqbf8aidKJAZfCx9qBty4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594979905469599.3759197535502; Fri, 17 Jul 2020 02:58:25 -0700 (PDT) Received: from localhost ([::1]:42538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwN8K-000567-9n for importer@patchew.org; Fri, 17 Jul 2020 05:58:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwN6K-0002Hg-8r for qemu-devel@nongnu.org; Fri, 17 Jul 2020 05:56:20 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:25747 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jwN6H-0001Bb-L9 for qemu-devel@nongnu.org; Fri, 17 Jul 2020 05:56:19 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-_3IbLyppPD6tmYNQ6qHCzg-1; Fri, 17 Jul 2020 05:56:14 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6588800464; Fri, 17 Jul 2020 09:56:13 +0000 (UTC) Received: from thuth.com (ovpn-112-62.ams2.redhat.com [10.36.112.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 086BF5C1D3; Fri, 17 Jul 2020 09:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594979776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HMyJ54H0zE5Lwb742MXdkIKrAmqMlGaD0MBhncrOAaY=; b=IKOnSdhM8s3Tg/IC2a8lpogDBJ/hr6ICSZCvHt5RrCv3kdItAer5hb0dLDeK3Xlf0pfNxY cd8sORthpgjPiw2miT595k64q/4a2lWFRv1u0Zl0VBWyQ81DkDaX7ECtRKBwuyU2P7naoB FvbPvwDHqm1DoF/VD6flgH8yvo3bmmM= X-MC-Unique: _3IbLyppPD6tmYNQ6qHCzg-1 From: Thomas Huth To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [PULL 4/6] configure: Fix for running with --enable-werror on macOS Date: Fri, 17 Jul 2020 11:56:03 +0200 Message-Id: <20200717095605.27589-5-thuth@redhat.com> In-Reply-To: <20200717095605.27589-1-thuth@redhat.com> References: <20200717095605.27589-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/17 01:33:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) The configure script currently refuses to succeed when run on macOS with --enable-werror: ERROR: configure test passed without -Werror but failed with -Werror. The information in config.log indicates: config-temp/qemu-conf.c:3:55: error: control reaches end of non-void function [-Werror,-Wreturn-type] static void *f(void *p) { pthread_setname_np("QEMU"); } ^ And indeed, the return statement is missing here. Fixes: 479a57475e ("util: Implement debug-threads for macOS") Message-Id: <20200716055655.24507-1-thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b751c853f5..e93836aaae 100755 --- a/configure +++ b/configure @@ -4198,7 +4198,7 @@ pthread_setname_np_wo_tid=3Dno cat > $TMPC << EOF #include =20 -static void *f(void *p) { pthread_setname_np("QEMU"); } +static void *f(void *p) { pthread_setname_np("QEMU"); return NULL; } int main(void) { pthread_t thread; --=20 2.18.1