From nobody Sun May 19 09:23:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594977777; cv=none; d=zohomail.com; s=zohoarc; b=ilEMABexDnWeGPY5YJUy9faYg2JoPvNUpzBm7DiaSfG7WRXrEhs9PVIZLbwDil7CGLwR3qLVgzxKZ33nSyAAon0swhikcNco7ALsKdpsEWPcxYqVXev+h027Weq4H/dqpaQdfxZy7WEjUovANTyIJyfc3iaJDSFaJsq1VTCeSgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594977777; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Jmj7D6ZGdLHOXZGqfIGEF4nTu/agMWxMPHXotG2bp+c=; b=Fdtws013r4frlxfFWLeh1ydNBm62HBBRUZHMhTMcis08vOPp9tOMOcQCv5qZNeJhS2r8RPnF8qPMPQB15iI185lCxN/r/RIEv5e/4Gv7S7NDiZQfHu1h8/XkeTtk+HTUuM+ihYC8j7Jdff7IcK7BhG6xDwqBRptrrExBMlwJAx0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594977777269593.0475095057369; Fri, 17 Jul 2020 02:22:57 -0700 (PDT) Received: from localhost ([::1]:59968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwMZz-00034e-5C for importer@patchew.org; Fri, 17 Jul 2020 05:22:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwMYz-0002dn-Rz for qemu-devel@nongnu.org; Fri, 17 Jul 2020 05:21:53 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:42508 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwMYy-0002sb-09 for qemu-devel@nongnu.org; Fri, 17 Jul 2020 05:21:53 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id DC41B6A3423E00541CE2; Fri, 17 Jul 2020 17:21:38 +0800 (CST) Received: from DESKTOP-KKJBAGG.china.huawei.com (10.174.186.75) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Jul 2020 17:21:29 +0800 From: Zhenyu Ye To: Subject: [PATCH v1] migration: tls: unref creds after used Date: Fri, 17 Jul 2020 17:19:43 +0800 Message-ID: <20200717091943.1942-1-yezhenyu2@huawei.com> X-Mailer: git-send-email 2.22.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.186.75] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=yezhenyu2@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/17 05:21:39 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, dgilbert@redhat.com, xiexiangyou@huawei.com, yezhenyu2@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We add the reference of creds in migration_tls_get_creds(), but there was no place to unref it. So the OBJECT(creds) will never be freed and result in memory leak. Unref the creds after creating the tls-channel server/client. Signed-off-by: Zhenyu Ye --- migration/tls.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/migration/tls.c b/migration/tls.c index 5171afc6c4..0740d02976 100644 --- a/migration/tls.c +++ b/migration/tls.c @@ -97,7 +97,7 @@ void migration_tls_channel_process_incoming(MigrationStat= e *s, s->parameters.tls_authz, errp); if (!tioc) { - return; + goto cleanup; } =20 trace_migration_tls_incoming_handshake_start(); @@ -107,6 +107,9 @@ void migration_tls_channel_process_incoming(MigrationSt= ate *s, NULL, NULL, NULL); + +cleanup: + object_unref(OBJECT(creds)); } =20 =20 @@ -146,13 +149,13 @@ void migration_tls_channel_connect(MigrationState *s, } if (!hostname) { error_setg(errp, "No hostname available for TLS"); - return; + goto cleanup; } =20 tioc =3D qio_channel_tls_new_client( ioc, creds, hostname, errp); if (!tioc) { - return; + goto cleanup; } =20 trace_migration_tls_outgoing_handshake_start(hostname); @@ -162,4 +165,7 @@ void migration_tls_channel_connect(MigrationState *s, s, NULL, NULL); + +cleanup: + object_unref(OBJECT(creds)); } --=20 2.19.1