From nobody Sun May 19 04:05:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594905122; cv=none; d=zohomail.com; s=zohoarc; b=AcolOCk2p9yNb8jf3xh8mfQpT8oNNBT+qrV5P4y0CdQ+JJerwwHad0g8+Gq7eC3seB7RN4nGK39GtysjjorEbr6el/U8EMV7BxNsIF64Ud0ttKZypFsdDYf6RwC5FLOYJKayI1F9mxkbypvr4A0A2EN+isTot4ywYxFAN3SbNPk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594905122; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=+UzqOgDd1heW1N0Fj4ypJlrpAiJcLdvsnjXrMdFWkHo=; b=lWgxURduMZ/s6kBouHJj3UYI3yaqye7ZcI8/Bx5iO9A/fI3ay2ul8ntpletJffQv5gOB3jjmnqiOsFEgSxHoaaB8a/axkbkk1Jz+xezLoYXn/R0U1+HRYbk8abCtOi4Wdj7N5AEoLx/qfRHEaV8gQfyiiuiljm9zPUuJZamisq8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594905122783447.0476473217284; Thu, 16 Jul 2020 06:12:02 -0700 (PDT) Received: from localhost ([::1]:56750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw3g8-0008In-Fh for importer@patchew.org; Thu, 16 Jul 2020 09:12:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw3fL-0007Ys-Sy for qemu-devel@nongnu.org; Thu, 16 Jul 2020 09:11:11 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:37322 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jw3fJ-0000B1-Nj for qemu-devel@nongnu.org; Thu, 16 Jul 2020 09:11:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-67lDVYx-NFWpZnfTPmOw_Q-1; Thu, 16 Jul 2020 09:11:06 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76FC919200E8; Thu, 16 Jul 2020 13:11:05 +0000 (UTC) Received: from thuth.com (ovpn-112-234.ams2.redhat.com [10.36.112.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E7E819C4F; Thu, 16 Jul 2020 13:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594905068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type; bh=+UzqOgDd1heW1N0Fj4ypJlrpAiJcLdvsnjXrMdFWkHo=; b=ixwwi5L5VIph7t/HSR9vI3PTDuweYMdORbu2hwBoyypFAamwDAnKoLktDpct+2sBYpuGQ8 1nE0a+aHt2VSVawG4rDRAJ+IZS4D5+IT8Xw31oCqeU5QHyaRFq4eWP9UQsE7grKK4cLgGx l9OKZNRTcg/cL6ims640QGrvwlX02ZQ= X-MC-Unique: 67lDVYx-NFWpZnfTPmOw_Q-1 From: Thomas Huth To: peter.maydell@linaro.org, qemu-devel@nongnu.org Subject: [RFC PATCH] configure: Fix atomic64 test for --enable-werror on macOS Date: Thu, 16 Jul 2020 15:11:01 +0200 Message-Id: <20200716131101.18462-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 04:55:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When using --enable-werror for the macOS builders in the Cirrus-CI, the atomic64 test is currently failing, and config.log shows a bunch of error messages like this: config-temp/qemu-conf.c:6:7: error: implicit declaration of function '__atomic_load_8' is invalid in C99 [-Werror,-Wimplicit-function-declarati= on] y =3D __atomic_load_8(&x, 0); ^ config-temp/qemu-conf.c:6:7: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] Suppress the warnings to make it pass. Signed-off-by: Thomas Huth --- Not sure whether this is the best way to fix this issue ... thus marked as RFC. Even though the compiler warns here, the program links apparently just fine afterwards and CONFIG_ATOMIC64=3Dy gets set in the config-host.mak file on macOS, so the 64-bit atomic operations seem to be available... Any macOS users here who could shed some light on this? configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index e93836aaae..4d50a07b00 100755 --- a/configure +++ b/configure @@ -5939,7 +5939,8 @@ int main(void) return 0; } EOF -if compile_prog "" "" ; then +if compile_prog "-Wno-implicit-function-declaration -Wno-strict-prototypes= " ""; +then atomic64=3Dyes fi =20 --=20 2.18.1