From nobody Tue Feb 10 04:15:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594758181; cv=none; d=zohomail.com; s=zohoarc; b=bGwpNuWBS5FK3Z1KHJ06xZgnEUy4W1Aad72bunJJSKqW6Vz2gytHHCf51tf+w9X0ayUz4/m0qcBJHCsC3R7CXwWmPYNHIWGlU9JeR6RrXMmNclTZm7PWISQ2JE7XuSCuhnEHGaFAAxBPymGix/5qmZCBgcUg/Qz69FfCnH6K2o4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594758181; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DkF/9wd+ad82T0QmLB+VeX5sFi2tBHhmif5Rzh6VSls=; b=HDkQGbfw8pHucbAjM0IR9ee+TTH7ztUGCIBooHADWStdZMi0VKgb3Sk2eALvdTjmww30avuQs6rhU32r27OHBlqADD6Sf+Z2eiAI1B1t4JSc3tV3rDhFFIcpCyOnte0mRpD0CJWRcxlyBkcVTEEyuj3GI5yJtnZz/Vq5ITDWMlA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594758181927215.1831542055521; Tue, 14 Jul 2020 13:23:01 -0700 (PDT) Received: from localhost ([::1]:46684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvRS8-0006KL-Qk for importer@patchew.org; Tue, 14 Jul 2020 16:23:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvRQB-0003DU-6s for qemu-devel@nongnu.org; Tue, 14 Jul 2020 16:20:59 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:42636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jvRQ9-0006UA-Ej for qemu-devel@nongnu.org; Tue, 14 Jul 2020 16:20:58 -0400 Received: by mail-wr1-x434.google.com with SMTP id o11so9057wrv.9 for ; Tue, 14 Jul 2020 13:20:56 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id 138sm7245217wmb.1.2020.07.14.13.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 13:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DkF/9wd+ad82T0QmLB+VeX5sFi2tBHhmif5Rzh6VSls=; b=m1pnhJ8Js7VezUe6KXDfY7rwCcJqidigQKoWkEz9lljXdUeItq4jNSa5uf6l0otUWh efEK66R0204rp2WImk0nqB0iXSunj6PDOLADa1ESCifUNKSeZ4sNzoaPbxmb9SaBj5O4 PNl5m03N2hkyaw9/cv9e/vARI652bYmmWHTu8O7K0VZs1hLc4X7rayAYBaQYAu5PNuTk gg67AVfNd61Md4iJvAcgm2yKbEZMJA8t17j7KVY19aeD2hhqE32mAoN9BoG8VH0Dtf3G BQ0eWuHE4d09sa0WP6sUqnF0LCxk8o1u1LvSS0Tbx5ug3kuuoMly7HoNluvphwjvDvxW V6rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=DkF/9wd+ad82T0QmLB+VeX5sFi2tBHhmif5Rzh6VSls=; b=eFNTU3GeQi3Bbl3VGX6tJSUtKPwQ+2GuespdLgT2rcS/Kqpy7y7FK8MTQ7DqY+g7yr 5iupuU673xdRQezEZCzp3gr5wVpzYoUIExtxkyAZZ0289qrp21ZLd06iwyTeq3yC8meK ORhj/O0tGzdpF0/vFeba4gJvAJdMIhrdHOQ4PLy3rJFRzCCfDg1OXjTHonesWs5GvmO9 Wx3CMxmWyzJSd37g1G9YejQMSumbBLHLJQlm925pmmRMRlnVUN0QZOBi/1ZYb9dHWJVD UITDwldcF1+gdLdvfy2ikx56JzTmr80y35ZyR98wDt3Skiyc3lFnxjsXz+Kznoeqcg5v Kznw== X-Gm-Message-State: AOAM533b2RrngMMLdIRiB7DNIcL4ZSZ9Vy000qZK5vgXat3F4xbRWT3V w02CeEqksLxfNrtjlGR1sEGK3FN7lhc= X-Google-Smtp-Source: ABdhPJwLDLjoeClkbdqNwH0zhXeQy5q7ZDvecEo3SQmCXhF6G+1cuDMWJvlAguJlJx3PNl99r0USEg== X-Received: by 2002:a5d:650e:: with SMTP id x14mr8061161wru.187.1594758055674; Tue, 14 Jul 2020 13:20:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 2/3] target/mips: Fix ADD.S FPU instruction Date: Tue, 14 Jul 2020 22:20:50 +0200 Message-Id: <20200714202051.13549-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200714202051.13549-1-f4bug@amsat.org> References: <20200714202051.13549-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Aleksandar Markovic , Alex Richardson , Huacai Chen , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Alex Richardson After merging latest QEMU upstream into our CHERI fork, I noticed that some of the FPU tests in our MIPS baremetal testsuite [*] started failing. It turns out commit 1ace099f2a accidentally changed add.s into a subtract. [*] https://github.com/CTSRD-CHERI/cheritest Fixes: 1ace099f2a ("target/mips: fpu: Demacro ADD.") Signed-off-by: Alex Richardson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200703161515.25966-1-Alexander.Richardson@cl.cam.ac.uk> Signed-off-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/fpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 7a3a61cab3..56beda49d8 100644 --- a/target/mips/fpu_helper.c +++ b/target/mips/fpu_helper.c @@ -1221,7 +1221,7 @@ uint32_t helper_float_add_s(CPUMIPSState *env, { uint32_t wt2; =20 - wt2 =3D float32_sub(fst0, fst1, &env->active_fpu.fp_status); + wt2 =3D float32_add(fst0, fst1, &env->active_fpu.fp_status); update_fcr31(env, GETPC()); return wt2; } --=20 2.21.3