From nobody Sat May 4 00:39:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594363669; cv=none; d=zohomail.com; s=zohoarc; b=Z6Pa/tUJgZ/wGGXWRe3GAxS51T4cAPHGh6x/tcjuLraQ9yP3obY6N8FdmnkWbWphSqySHDObFIg1xhbo907vIsT5j5/VL/82uJ91hRmauiKctgrY0SeHhzMRh/Istz3q4fyywcoPjmHd7e0WwxXE3nuY6FgCKGvAQemH/TfoDBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594363669; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=J1co7jhKacm7ZhmElNtaoAsJib0guSf82gXuorCixLc=; b=V1Haflx3EKFk+F4sn0gFkfQhxJgp83a/ZGFtKVRAhV0Ya3/CZfHu9vGMtszyjNIUpj7hqYoo8yjDY4fAvz0WCjoSsrtKUxSAssQ/M7d28BR3Ecd15VEzFCftXbQc0eoxxiEmxNc7QerxfA+CfiZXcDCVsZh6DVHD6vd/RmTGf6Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594363669014314.78015000542075; Thu, 9 Jul 2020 23:47:49 -0700 (PDT) Received: from localhost ([::1]:38862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtmp1-0004Yk-Dz for importer@patchew.org; Fri, 10 Jul 2020 02:47:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtmoP-000492-H6 for qemu-devel@nongnu.org; Fri, 10 Jul 2020 02:47:09 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:27304 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jtmoN-0000sN-Uo for qemu-devel@nongnu.org; Fri, 10 Jul 2020 02:47:09 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-29_0nGIkPuG6sLWOaAHLtg-1; Fri, 10 Jul 2020 02:47:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E2C080183C; Fri, 10 Jul 2020 06:47:02 +0000 (UTC) Received: from laptop.redhat.com (ovpn-12-227.pek2.redhat.com [10.72.12.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4239960E1C; Fri, 10 Jul 2020 06:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594363626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J1co7jhKacm7ZhmElNtaoAsJib0guSf82gXuorCixLc=; b=WCogYCPhJsKHZoMyTLoRpUn+OU9eai0tehrk3f3cPY+k8vWLoQRefjQIj2G/1m89/9jsfO BrwHvmU1B4+Q/YngYDWvZY2Q1dQlOFsiOlQdjkZZplqyzsp1K9qpHV6XZFlUJ1w68hUxjD upmekBgPQWUUI5enqnOPOcIIg+y/H7Q= X-MC-Unique: 29_0nGIkPuG6sLWOaAHLtg-1 From: Cindy Lu To: mst@redhat.com, peter.maydell@linaro.org, jasowang@redhat.com Subject: [PATCH v2] vhost-vdpa :Fix Coverity CID 1430270 / CID 1420267 Date: Fri, 10 Jul 2020 14:46:42 +0800 Message-Id: <20200710064642.24505-1-lulu@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lulu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=lulu@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/09 22:08:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mhabets@solarflare.com, qemu-devel@nongnu.org, rob.miller@broadcom.com, saugatm@xilinx.com, lulu@redhat.com, hanand@xilinx.com, hch@infradead.org, eperezma@redhat.com, jgg@mellanox.com, shahafs@mellanox.com, kevin.tian@intel.com, parav@mellanox.com, vmireyno@marvell.com, cunming.liang@intel.com, gdawar@xilinx.com, jiri@mellanox.com, xiao.w.wang@intel.com, stefanha@redhat.com, zhihong.wang@intel.com, ian@iankelling.org, aadam@redhat.com, rdunlap@infradead.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialize= d all its fields. Signed-off-by: Cindy Lu Acked-by: Jason Wang Reviewed-by: Li Qiang Reviewed-by: Peter Maydell --- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index a3d17fe0f9..b9265f3761 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c @@ -38,7 +38,7 @@ static bool vhost_vdpa_listener_skipped_section(MemoryReg= ionSection *section) static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwaddr iova, hwaddr si= ze, void *vaddr, bool readonly) { - struct vhost_msg_v2 msg; + struct vhost_msg_v2 msg =3D {}; int fd =3D v->device_fd; int ret =3D 0; =20 @@ -61,7 +61,7 @@ static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwadd= r iova, hwaddr size, static int vhost_vdpa_dma_unmap(struct vhost_vdpa *v, hwaddr iova, hwaddr size) { - struct vhost_msg_v2 msg; + struct vhost_msg_v2 msg =3D {}; int fd =3D v->device_fd; int ret =3D 0; =20 --=20 2.21.1