From nobody Mon Feb 9 15:11:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=openvz.org ARC-Seal: i=1; a=rsa-sha256; t=1594301278; cv=none; d=zohomail.com; s=zohoarc; b=TBa2f0Rk2NpbRbr3v/S9TTapeOB8cGszZRdfkCBN+RQOR6b3gKiAWEwwsXsiEb6k0bgyjVcNwCwumO2OAcMKO44rlvHHn/qlqeLAbAo/ofqa2N0MmptS5g2oG45k13w3mai5qn+d25IQd8NQlX595oipPk6GaNy5SghRRTCsvQ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594301278; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=LjXemuMXH+ozCsekfM3ss9s62GNQXWdu3G3IiiSmvxo=; b=Xi08c3oiFp+kn3Xi+1Ts5CkO/Nb441v2zs7YBsfIVatFQjyMmJbhmr6tMxE1+/sRifUSMaPeNRhHdH8hFgrhtQZ1lceFSy8+qrMHCyTv7UgQl7lw6Ez/s3jJH6R3Bp7mOOkQ3N93A6r7qloSWF/YFsyUmybQQqUZ55t9EqbabhE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594301278586254.4362633811104; Thu, 9 Jul 2020 06:27:58 -0700 (PDT) Received: from localhost ([::1]:35606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtWai-0006rE-QM for importer@patchew.org; Thu, 09 Jul 2020 09:27:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtWZi-0005JS-QT; Thu, 09 Jul 2020 09:26:54 -0400 Received: from relay.sw.ru ([185.231.240.75]:58692 helo=relay3.sw.ru) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtWZg-0002ZW-1y; Thu, 09 Jul 2020 09:26:54 -0400 Received: from [192.168.15.130] (helo=iris.sw.ru) by relay3.sw.ru with esmtp (Exim 4.93) (envelope-from ) id 1jtWZX-00044k-Lb; Thu, 09 Jul 2020 16:26:43 +0300 From: "Denis V. Lunev" To: qemu-block@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 3/6] block/block-backend: remove always true check from blk_save_vmstate Date: Thu, 9 Jul 2020 16:26:41 +0300 Message-Id: <20200709132644.28470-4-den@openvz.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200709132644.28470-1-den@openvz.org> References: <20200709132644.28470-1-den@openvz.org> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.231.240.75; envelope-from=den@openvz.org; helo=relay3.sw.ru X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/09 09:26:47 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Juan Quintela , "Dr. David Alan Gilbert" , Max Reitz , Denis Plotnikov , Stefan Hajnoczi , "Denis V. Lunev" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" bdrv_save_vmstate() returns either error with negative return value or size. Thus this check is useless. Signed-off-by: Denis V. Lunev Suggested-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Kevin Wolf CC: Max Reitz CC: Stefan Hajnoczi CC: Fam Zheng CC: Juan Quintela CC: "Dr. David Alan Gilbert" CC: Denis Plotnikov --- block/block-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index 6936b25c83..1c6e53bbde 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -2188,7 +2188,7 @@ int blk_save_vmstate(BlockBackend *blk, const uint8_t= *buf, return ret; } =20 - if (ret =3D=3D size && !blk->enable_write_cache) { + if (!blk->enable_write_cache) { ret =3D bdrv_flush(blk_bs(blk)); } =20 --=20 2.17.1