From nobody Fri Dec 19 19:16:14 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594244610; cv=none; d=zohomail.com; s=zohoarc; b=V3BrS2pDI1fmovnJ57bR4a0U9SdunhjcJqjEeCMCZJzo78LPioJO3SX8Il7pXLysBLTXbsiCHMmmGVKA/ijJOCITTcgT7YXuln9G2K//xYKHRd/1tKgcEY/AYddAQZQShuXk+72+PSnHE3QSXaarujYalglMXWlqiN7rytjD76Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594244610; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=s4VbgfcigvKjVtzg09Rg5LLDx63Fu0wt3DTzItKNolg=; b=YUwgP3ENbW8/cdgd41egdO06SP7K6RDVYmRM+himyaYl3pZ5KWe1efhW2UZBih8bauOjB6idqBgg13F4rx6VLLG5WBP1mN28J0cZyEUFzCouvjZdy7XFxfLno3JRCIl6Y9VAOHPN7CinBVU6mj5Fpwo8B+791ek81RZOdtCZO7c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594244610547760.9151080475563; Wed, 8 Jul 2020 14:43:30 -0700 (PDT) Received: from localhost ([::1]:51924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtHqi-00060F-W8 for importer@patchew.org; Wed, 08 Jul 2020 17:43:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtHbs-00006S-S3 for qemu-devel@nongnu.org; Wed, 08 Jul 2020 17:28:08 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:37808 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jtHbp-00026a-6E for qemu-devel@nongnu.org; Wed, 08 Jul 2020 17:28:08 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-351-mfMh8TBJOL2fafwA5JjRjA-1; Tue, 07 Jul 2020 17:25:32 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5251107ACF3 for ; Tue, 7 Jul 2020 21:25:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A624E10013C2; Tue, 7 Jul 2020 21:25:28 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BBEA910C4AE8; Tue, 7 Jul 2020 23:25:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594243684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s4VbgfcigvKjVtzg09Rg5LLDx63Fu0wt3DTzItKNolg=; b=ETy2PK1NuNJfGNHPvRyW+LOVAqX+mUPZEncb5+/QlDsh++MTH/uWVTykDs0JwCL4SPCT2X jXnY2vhjP8cWvUkhQCtOztMpwUaGY0uH+RhXnCdoDD1+s1Uw2AEQcFauYzPFgabPnZy9GY kBdrEPiYRHOfJ5FgDtdpBKk7r8zSP+0= X-MC-Unique: mfMh8TBJOL2fafwA5JjRjA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 44/53] qdev: Ignore Error objects where the return value suffices Date: Tue, 7 Jul 2020 23:24:54 +0200 Message-Id: <20200707212503.1495927-45-armbru@redhat.com> In-Reply-To: <20200707212503.1495927-1-armbru@redhat.com> References: <20200707212503.1495927-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 17:25:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20200707160613.848843-45-armbru@redhat.com> --- hw/core/qdev-properties.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 2bec8a80b8..098298c78e 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -742,7 +742,6 @@ static void set_pci_devfn(Object *obj, Visitor *v, cons= t char *name, Property *prop =3D opaque; int32_t value, *ptr =3D qdev_get_prop_ptr(dev, prop); unsigned int slot, fn, n; - Error *local_err =3D NULL; char *str; =20 if (dev->realized) { @@ -750,9 +749,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, cons= t char *name, return; } =20 - if (!visit_type_str(v, name, &str, &local_err)) { - error_free(local_err); - local_err =3D NULL; + if (!visit_type_str(v, name, &str, NULL)) { if (!visit_type_int32(v, name, &value, errp)) { return; } --=20 2.26.2