From nobody Fri Dec 19 19:15:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594244990; cv=none; d=zohomail.com; s=zohoarc; b=KKDX4pFP9VJ2RMi7+8s3m+3FMxDgoYzbj0VoQcQu9ZkPKfEpIp7hOrCV2Y6CDXDmV/8xdIe/yMviSULE5yOi6zCxnTzbicczdMafc+gpMHzVP59i2anHCnvQyzyHuk65cx0GLfgUmCo92nlykgQus+dB8qMMWunBd+Vh0a2BH+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594244990; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wf+N74XF+t8ceCEFLtaz2qV2ooS19D4t/Fc0AXTZobM=; b=k7UOiwKuu+5S99ofQz9T5rHjIOwqyReNZlq+8uWB17RpkYkYpWyy8HWpuTKXigPzk6lbkXs5TJ8YXgKiTVA1qSwwusQ0DsM84BrPx5Hkn7cb33Bg/Hy7D7i2S7BaLnKGn0LCh8wJ1aucULG265QKFb1YShY3CweEQ2PZdLojcyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159424499054825.957563482726528; Wed, 8 Jul 2020 14:49:50 -0700 (PDT) Received: from localhost ([::1]:48238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtHwr-0007s8-C3 for importer@patchew.org; Wed, 08 Jul 2020 17:49:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtHc0-0000Os-Qi for qemu-devel@nongnu.org; Wed, 08 Jul 2020 17:28:16 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:54994 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jtHby-00029B-Aq for qemu-devel@nongnu.org; Wed, 08 Jul 2020 17:28:16 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-k-7saZqbM6ChKvxdUI1CiA-1; Tue, 07 Jul 2020 17:25:17 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92C9ABFC0; Tue, 7 Jul 2020 21:25:16 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 633BD5C1D0; Tue, 7 Jul 2020 21:25:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 25B681144228; Tue, 7 Jul 2020 23:25:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594243693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wf+N74XF+t8ceCEFLtaz2qV2ooS19D4t/Fc0AXTZobM=; b=e4ndzOEy+iXPpo4PQVcMtCI2fHavtaiDKdl5ET8pZra9fNooKsTHWbiKWN5yjXHXs+5Xjn IKotcVGZHKPCAFRsbP9SmQwQE3kQLYeAsEWoibl44Idia5PmhOlLC+7iyAqRJavQ9UsJ3F v3DwWYsoEeTpXipIjA8jas/j1BQdImA= X-MC-Unique: k-7saZqbM6ChKvxdUI1CiA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 16/53] hmp: Eliminate a variable in hmp_migrate_set_parameter() Date: Tue, 7 Jul 2020 23:24:26 +0200 Message-Id: <20200707212503.1495927-17-armbru@redhat.com> In-Reply-To: <20200707212503.1495927-1-armbru@redhat.com> References: <20200707212503.1495927-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 17:25:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200707160613.848843-17-armbru@redhat.com> --- monitor/hmp-cmds.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 2ec13e4cc3..bb17b1b96c 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1247,7 +1247,6 @@ void hmp_migrate_set_parameter(Monitor *mon, const QD= ict *qdict) MigrateSetParameters *p =3D g_new0(MigrateSetParameters, 1); uint64_t valuebw =3D 0; uint64_t cache_size; - MultiFDCompression compress_type; Error *err =3D NULL; int val, ret; =20 @@ -1343,11 +1342,8 @@ void hmp_migrate_set_parameter(Monitor *mon, const Q= Dict *qdict) break; case MIGRATION_PARAMETER_MULTIFD_COMPRESSION: p->has_multifd_compression =3D true; - visit_type_MultiFDCompression(v, param, &compress_type, &err); - if (err) { - break; - } - p->multifd_compression =3D compress_type; + visit_type_MultiFDCompression(v, param, &p->multifd_compression, + &err); break; case MIGRATION_PARAMETER_MULTIFD_ZLIB_LEVEL: p->has_multifd_zlib_level =3D true; --=20 2.26.2