From nobody Mon May 6 21:42:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594105319; cv=none; d=zohomail.com; s=zohoarc; b=Pn6XEg1BPqynn5YYP6nPaDSZ44zr+iRvQixqPiLu2zJ3GoNjFRkOELsdG88+mVmXIYTJ7whmyrvncLj+V1CWKxLgdYTakjTrMHDHEeI0OBCI45yWiOucVy8ecmfB0B5FSlsyi9x03Zzpfdy6ckmKZu9iY0KtOsnWgl3u8y/sXyU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594105319; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vP24btoO2N26bkXvUhS4wjNttBxYNUYpNRsjcv1D964=; b=d0rk/11mxPZPx9PDmxGcdbXqLrUFl9xdDa7IB8HMM59x9fr1bUq6rIKwu33rzicKpBqcAecWPc5z8affX9a96PZ56Fp3gmUpOZzXMLDjGawvgm3HmoSHPoUkhfxl78pdQ50pFCXRyE47LwCLkpHYBgaxJY4qyGUjgzBrrc5e1xQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594105319898421.2932340585801; Tue, 7 Jul 2020 00:01:59 -0700 (PDT) Received: from localhost ([::1]:55408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jshc6-0007Wv-Bx for importer@patchew.org; Tue, 07 Jul 2020 03:01:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jshaf-00063L-4m for qemu-devel@nongnu.org; Tue, 07 Jul 2020 03:00:29 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:43523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jshad-0002dt-HU for qemu-devel@nongnu.org; Tue, 07 Jul 2020 03:00:28 -0400 Received: by mail-wr1-x441.google.com with SMTP id j4so41529164wrp.10 for ; Tue, 07 Jul 2020 00:00:26 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id r3sm30763634wrg.70.2020.07.07.00.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 00:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vP24btoO2N26bkXvUhS4wjNttBxYNUYpNRsjcv1D964=; b=a+5GuLSMKbT8Bo6jsECDLI8YaJAyjaxNIvB/RJWG2YSWAFiZYwCrpdK9qzyKMkoZhy kcXkvLwP7Agt3tp6oNO8CsH8IJhUddDEF3dsomDYKVbIIlpWXQgNm4iQrWeKGcbW6Wno mtLdFBd20+UNRVlTnbgIfR5d9CpJLSagfGISNyr/QS9ms6a6zPKRkpQEiRz1Uw29IoED ZNAbbEAtvMj24r4KzBbrdl+TIysQWjuBo1cvSlkGXvQ3NfytCq+ToLurrxGYdBrc89i4 oHzgtUQgChNDQLZ8TVVFCCuz2vBI2sz6JJZ8NZiPKgsG9R8jCIvp1xPEEqVhOdY9aNe6 Ug6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vP24btoO2N26bkXvUhS4wjNttBxYNUYpNRsjcv1D964=; b=jisLvxhXl4u7QnseXQouG0FsAZoXCwR4iYV1ZnC2DJ4vNtrXeQ8MVP5AwxQKHbkl1S DV3/GWwfrZNNc9xecotDkGS/vcKmWGU7BkgwPUbegD0wXE/w15NdagNMv/KgJun/riMu 88N8mkQViLsVhqsKNWjhVEXJ4WiJseRUDZ0h0hvrztoDz4y0G71/Dl1vNy5/7cC7ElJv axA+0tmJhjyhZB/3mto0DFR+o8ixybKTnjAyd7Bz11YzWL/5zjlfjXkep7gGxfiQ1ap8 gwG2lieA9pKCZEZJ+SyyOBI1f817LKtQjYHtarXtliHg2afsIr6wgrLun2nxGx8bMrwm +l1A== X-Gm-Message-State: AOAM533AHazxZzZhraiKfGvCdUV8px+zasUYXwmRcyJPHZk0AOIP7vQp y/9sz5pR5sGd/yNe6mDqHuH34Le0 X-Google-Smtp-Source: ABdhPJwrzFFJluwSjkX2DTTFXCvoDjKNbMT2AvGdjZF5Ske3VRQbfVYe/abObPFFg4v5UUx37t4jag== X-Received: by 2002:adf:ebd0:: with SMTP id v16mr46387276wrn.241.1594105225436; Tue, 07 Jul 2020 00:00:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset() Date: Tue, 7 Jul 2020 09:00:18 +0200 Message-Id: <20200707070021.10031-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200707070021.10031-1-f4bug@amsat.org> References: <20200707070021.10031-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , Thomas Huth , Joaquin de Andres , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Rolnik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- target/avr/cpu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 4e4dd4f6aa..50fb1c378b 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -78,8 +78,6 @@ static void avr_cpu_reset(DeviceState *ds) env->skip =3D 0; =20 memset(env->r, 0, sizeof(env->r)); - - tlb_flush(cs); } =20 static void avr_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) --=20 2.21.3 From nobody Mon May 6 21:42:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594105408; cv=none; d=zohomail.com; s=zohoarc; b=neJasMDJLLFi15Q81mnjFF9Ca5IRdJwbNmZzT7T4Lvfcsacgta2Zwa4R8egjhk55Zwuh12reYAZtuyej1kF1AGBDm2LO/Al94A0hdvkWuWFOnI0ays8dY3FvpAXiuLQgm4ChCf5SBYtZn9wtjqMsqMlFL/5RQeuBCmiL/Tm2+cY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594105408; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OAALL/cw7n/+7fM0VWJqcBq9KNUXzDegINtW6gZFwpE=; b=I6du9g7uBrHunA2cux8n46BQS0Q3rugUwb9Ag/ak7QomzvvMeKXrFLLdLVEcb829K3Lfx4RzLGlSj3YSPtV4QOwZTX4ZGuzdGQJC+cQGZTef9K5KvYRweU2YX9syfS7sfHw1GEFD5VDS1rFZKOYfdH1Zza3REfn48AahLMtDvTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594105408957506.39911943362256; Tue, 7 Jul 2020 00:03:28 -0700 (PDT) Received: from localhost ([::1]:60700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jshdW-0001GS-Mp for importer@patchew.org; Tue, 07 Jul 2020 03:03:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jshaf-00063m-Qz for qemu-devel@nongnu.org; Tue, 07 Jul 2020 03:00:29 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:33671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jshae-0002e8-69 for qemu-devel@nongnu.org; Tue, 07 Jul 2020 03:00:29 -0400 Received: by mail-wr1-x434.google.com with SMTP id f18so35882601wrs.0 for ; Tue, 07 Jul 2020 00:00:27 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id r3sm30763634wrg.70.2020.07.07.00.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 00:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OAALL/cw7n/+7fM0VWJqcBq9KNUXzDegINtW6gZFwpE=; b=g4Zp4JqxMQPW8NXDh2LJhXZHDLOUQ189LrGld5JfP8h5zhM6Xd+QkQdlrN9P222zjR BSIZwCgn1DHaFmIDL9K4dzgLPt94oDTQ/d3iCQ/qpTNX1JweFpw3F5utysmWLb0dP7te GIhWpTvc181uBX0ULfohDy9jSU+sZcD9+HLUoauVHKkXZhTZTOi/eHk+tXRXzLaKKbXN xGo9ZIYD8/GwsMX+a9x71slDgsrQqdlHH9elRSEkmhT85xsg4zApN4QlqP6fYxXD/0wf zdkdrs1ieITWFTnI8pTclq+akEJ4xNTv6gWfFUpLDdcReNNMlai0ih5KmNIHTrXDjOBW +FVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=OAALL/cw7n/+7fM0VWJqcBq9KNUXzDegINtW6gZFwpE=; b=jcaeK/nDXbmFYSF86RkrOEnNm/NqFEVd5+wJvz7QqbMqFqOGuj7cvYiy5uc7Skb+qM 8YZBZ8BPrLgbh8XArvGVs8VeGKVCsURQWWUupG3Vooc255+c1ibpIXdW2KtCg0eaGA2S 141xbzllHC6zx6YPPJIsHIn6MwN0UKcPd6PVGsxo+Wt7Wu0zOlWLEqE1ncsrpeMeltfw z5ps5A9lI8Gcf/un+c7q6kIihvZnKwIUN+tqlDq13K8qz1b/L8/lES66tHNPkciC9Z4X 8X7bmXp/B5+duynSTOuFvXd7WddrNieQwBCYWXptwH1Hj8VZ+7444VB0sUVnGSJbHuNi +wYA== X-Gm-Message-State: AOAM531/1xsCpiA359xz1qZuPk36mEBDbBskRxBdqfrO0PCgbrmc1kQI 5QYT1GAQjqB7WfkBejhJZU+q575o X-Google-Smtp-Source: ABdhPJxc//4/PZI0CVaSPHvX5M1mgcsLxzF7/0tKrF5PLqkXGGvI1Bt1TUT9KPVYpktsN3pUtnST7A== X-Received: by 2002:adf:e80d:: with SMTP id o13mr20788802wrm.112.1594105226591; Tue, 07 Jul 2020 00:00:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 2/4] target/avr/cpu: Fix $PC displayed address Date: Tue, 7 Jul 2020 09:00:19 +0200 Message-Id: <20200707070021.10031-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200707070021.10031-1-f4bug@amsat.org> References: <20200707070021.10031-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x434.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , Thomas Huth , Joaquin de Andres , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Rolnik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) $PC is 16-bit wide. Other registers display addresses on a byte granularity. To have a coherent ouput, display $PC using byte granularity too. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- target/avr/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 50fb1c378b..9be464991f 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -151,7 +151,7 @@ static void avr_cpu_dump_state(CPUState *cs, FILE *f, i= nt flags) int i; =20 qemu_fprintf(f, "\n"); - qemu_fprintf(f, "PC: %06x\n", env->pc_w); + qemu_fprintf(f, "PC: %06x\n", env->pc_w * 2); qemu_fprintf(f, "SP: %04x\n", env->sp); qemu_fprintf(f, "rampD: %02x\n", env->rampD >> 16); qemu_fprintf(f, "rampX: %02x\n", env->rampX >> 16); --=20 2.21.3 From nobody Mon May 6 21:42:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594105321; cv=none; d=zohomail.com; s=zohoarc; b=GpnyzYUlXHMMyUeStp9blXVJSHLdRfnaJjVTCCYXvGFlYNv/fbfsHrm12bbQop26iX4n91gsyimK8E+ZG6fFOipHWzbQOe3QkJ+BGHho1Uocw0kQhLdFY/DV0XrVe6oBLd6smnic8xzcJJyVBIoLpYgXQLYZeJPOJCY3ssNmJbw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594105321; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a5MgrqzC2j1JrtNr8erhFYvekzCWdPEqkZHuGtykIIg=; b=fu6Az4mPWIIMP/ad1/3e1BzPrUVpqhyuDg9fWi7b0SYL/iyVPtlqIW/AHjE4Wh7xc0PQ8omKb5sWt/UZnYt0R0+uF8SMWybGf9Tg/RB1klSFQYXXzDm5Twu0QfiPmIxpQg2wVUh7I8R9HRgDzZJS1FK+9gbRr1TCkC/2wQJ9KZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594105321052505.36391539582905; Tue, 7 Jul 2020 00:02:01 -0700 (PDT) Received: from localhost ([::1]:55518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jshc7-0007ZW-QE for importer@patchew.org; Tue, 07 Jul 2020 03:01:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jshah-00064k-1i for qemu-devel@nongnu.org; Tue, 07 Jul 2020 03:00:31 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:36686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jshaf-0002eO-Fw for qemu-devel@nongnu.org; Tue, 07 Jul 2020 03:00:30 -0400 Received: by mail-wr1-x443.google.com with SMTP id k6so43965257wrn.3 for ; Tue, 07 Jul 2020 00:00:29 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id r3sm30763634wrg.70.2020.07.07.00.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 00:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a5MgrqzC2j1JrtNr8erhFYvekzCWdPEqkZHuGtykIIg=; b=nN09WyT99UK2pikA1PQ+Zw1eR6b4vo7QjNq2+4T9ODHTwCFcrpUnUFaTq2LwcSdU+z ZAh/adPSekLjJwmVhxuTtPtVtrp9FUyhQbA32hcvNZ60XyV5ixBo1/FLTc1NXwht5xY7 6TWRQfzyO/hap/vjD6nJ63Uuo6Rdphrbq36VURhz9cqEwYEBV0M5QDirIHZJA6wbvtfM 8XkqRL7J7Fv92Evv617mmCddWFa14CplVjqSi2US2XYl2b6D+nW/ITuxxg5g4XnCMSBu RFzNXqoju0+2TSwxd92s+7s5o26vXoLCvR+FxvOAe4ecBlbfL+MHDF7RKmx+/cNrNLLy 585A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=a5MgrqzC2j1JrtNr8erhFYvekzCWdPEqkZHuGtykIIg=; b=Frx6nfJ+b1g4f+as6j3EegPq/fqPis3QLM2kxoTKaSNcNPl6LE0a5RljzLk/g1q/pS g2LtA5zSp1HfEczaLdN7N4gz+c5F/cnV4s+0XQoCoTTj7dd0utGT4zQFRfwTzmzMkPxO nveebncjUSssOHWxrzTkJTjDKRZbmJXxNYXla3jfqWn+5KC9m/xW2r5kTao90Hurq9lg eXHuWut3yMJpuLAK8LsmsCIErCS+8tiM86v/6P9bMinrWjO37Gnd9RCSDQxspkUNNX+h Qs+FDanHESrgu9xTCEMycm2k59LXE8S8x5gFzbXHZ5YkEwUe7p3ZYNEdren+/UWu56Hl PlYg== X-Gm-Message-State: AOAM5330uYrcgGmTyy2vrwhgJ8tlzC9Ohas2Ni1OwE6rJ/E+42IsFjMz MhBtWH11GDH42CGArzUv+h92NzPV X-Google-Smtp-Source: ABdhPJxAdcNEEclM0ge116U4jeobjXnmgwlbTmhwy0hNpMxphwr/CZ6xnoFUQRKQqHJ/DXFQJtxwvA== X-Received: by 2002:adf:e801:: with SMTP id o1mr53302655wrm.54.1594105227895; Tue, 07 Jul 2020 00:00:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/4] target/avr/disas: Fix store instructions display order Date: Tue, 7 Jul 2020 09:00:20 +0200 Message-Id: <20200707070021.10031-4-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200707070021.10031-1-f4bug@amsat.org> References: <20200707070021.10031-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , Thomas Huth , Joaquin de Andres , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Rolnik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) While LOAD instructions use the target register as first argument, STORE instructions use it as second argument: LD Rd, X // Rd <- (X) ST Y, Rd // (Y) <- Rr Reported-by: Joaquin de Andres Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/avr/disas.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/target/avr/disas.c b/target/avr/disas.c index 23bd9919ed..7fa6e8711b 100644 --- a/target/avr/disas.c +++ b/target/avr/disas.c @@ -196,16 +196,16 @@ INSN(LDZ2, "r%d, Z+", a->rd) INSN(LDZ3, "r%d, -Z", a->rd) INSN(LDDY, "r%d, Y+%d", a->rd, a->imm) INSN(LDDZ, "r%d, Z+%d", a->rd, a->imm) -INSN(STS, "r%d, %d", a->rd, a->imm) -INSN(STX1, "r%d, X", a->rr) -INSN(STX2, "r%d, X+", a->rr) -INSN(STX3, "r%d, -X", a->rr) -INSN(STY2, "r%d, Y+", a->rd) -INSN(STY3, "r%d, -Y", a->rd) -INSN(STZ2, "r%d, Z+", a->rd) -INSN(STZ3, "r%d, -Z", a->rd) -INSN(STDY, "r%d, Y+%d", a->rd, a->imm) -INSN(STDZ, "r%d, Z+%d", a->rd, a->imm) +INSN(STS, "%d, r%d", a->imm, a->rd) +INSN(STX1, "X, r%d", a->rr) +INSN(STX2, "X+, r%d", a->rr) +INSN(STX3, "-X, r%d", a->rr) +INSN(STY2, "Y+, r%d", a->rd) +INSN(STY3, "-Y, r%d", a->rd) +INSN(STZ2, "Z+, r%d", a->rd) +INSN(STZ3, "-Z, r%d", a->rd) +INSN(STDY, "Y+%d, r%d", a->imm, a->rd) +INSN(STDZ, "Z+%d, r%d", a->imm, a->rd) INSN(LPM1, "") INSN(LPM2, "r%d, Z", a->rd) INSN(LPMX, "r%d, Z+", a->rd) --=20 2.21.3 From nobody Mon May 6 21:42:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594105410; cv=none; d=zohomail.com; s=zohoarc; b=BYf/b4DCSqCrdup/NsI7QcDYd+T6WnGLJtnECyYpUY/DvDd3uR1kLJQURbsEEVQ0znnk6z6AhCxo/+5RcTUydiVmgY5qqzyl8vOanY9+Aq8tcp3gObox9QJTg1QjkBgzwNvitXM3YzrWhyT8Ve7/bQIHu5Hh7R9fBdE8vqDQwDU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594105410; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=45gqo128NQDtIYcxM1tYqwMqbUrJDll0ND7eZVJPFlA=; b=Ehn+lTuX8vF5NRREe/mHQWoJaLy9PB64lpUOW6zbezXFCdKi/wh16Cc1WeLEzALnyzMOVahsZbvDh8KJEDsDVohrNpmhXAXlcC8sNsPIAvg7xNyybXoomiEJfrcy3WrO3x3xXqUW7T0XeEdglPxhqiISvF0heaS8897lrT28wN8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594105410014647.66971085637; Tue, 7 Jul 2020 00:03:30 -0700 (PDT) Received: from localhost ([::1]:60796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jshdY-0001Iy-Jp for importer@patchew.org; Tue, 07 Jul 2020 03:03:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jshai-00066i-NX for qemu-devel@nongnu.org; Tue, 07 Jul 2020 03:00:32 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:42553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jshah-0002ef-2L for qemu-devel@nongnu.org; Tue, 07 Jul 2020 03:00:32 -0400 Received: by mail-wr1-x442.google.com with SMTP id o11so43978385wrv.9 for ; Tue, 07 Jul 2020 00:00:30 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id r3sm30763634wrg.70.2020.07.07.00.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 00:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=45gqo128NQDtIYcxM1tYqwMqbUrJDll0ND7eZVJPFlA=; b=s/vESHtA/E+Lp4gI5IxOHzz4B17ntJwloQS/a1hgz7Wd7XmBusi463fP90FtEo2rFE lxVZrweP/+zQ67D3gSsgWEzD+adacl5CiGTBGZZCsYVrg0JZttxJN9ebcxROueOVKXE9 wPLuAar4jc3R0qXyFhu+S115nyB5KbcgtvSgkfvXN3We3E1Owv0WCyIh4HT+haVoQYbL R5ZQToheGyXq3vRxafXSJFhCfUDcGGBwFCWW6kU4YcyjhjZs6wv1R82dJzTsQx4/PMhd Nbx9KBzLl70DHLKFMff0uwLMHlrzkJQH9C4JMWRm34dk5XanmNPlmCs/ifA92QwlwLRX WQhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=45gqo128NQDtIYcxM1tYqwMqbUrJDll0ND7eZVJPFlA=; b=j46fgk0kMNkVyvKeNkFHLcSUFnKMEjuNVcWyA54mxV2fDlWL7XQIFdpu6orebDyJyO OsTEnR/tjlrJnWMZz7M5BZ2Cm/zmkQFlGyYXZf+33UugsBhZABPqQKce8fab2Ed2FOtz jdyJEsOj3zKTBvvjPyIytJx9clB88W7G9vgp6MVrOLMKfuDOV11HcOMReGilV6HAIbPl ezwYHRWyncFq4hzlVm6JxcqmUNDQ7dOFZWMiHcZ4sHjX6B11SBcRwMrSMbJVpTL39OTo cTGve9jyD90aUpMfCMAIdqG4KcyC5mFO3+kgEtAv4ZLSozI6h2ojIQnQPwr8rswLrY5P 7rbA== X-Gm-Message-State: AOAM532l7ht3hjq0qpyUzwI1XQRXamfRL5Kwv8LY2cIrRWjApzfgYhFh 8AL7CxEwF+eTHmTRXhxNzh4p0xQU X-Google-Smtp-Source: ABdhPJyXA7YPh2gl8el151cF4s7uObplwwGfgZ2f+0Tw+bCWP/PurkPeL0dkN3vPSTgoNq2Gb+ab1Q== X-Received: by 2002:a5d:4b4f:: with SMTP id w15mr51197461wrs.84.1594105229575; Tue, 07 Jul 2020 00:00:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 4/4] target/avr/translate: Fix SBRC/SBRS instructions Date: Tue, 7 Jul 2020 09:00:21 +0200 Message-Id: <20200707070021.10031-5-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200707070021.10031-1-f4bug@amsat.org> References: <20200707070021.10031-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , Thomas Huth , Joaquin de Andres , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Rolnik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) SBRC/SBRS instructions seem to be inverted. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/avr/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index fe03e676df..2f77fe3ba7 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -1385,7 +1385,7 @@ static bool trans_SBRC(DisasContext *ctx, arg_SBRC *a) { TCGv Rr =3D cpu_r[a->rr]; =20 - ctx->skip_cond =3D TCG_COND_EQ; + ctx->skip_cond =3D TCG_COND_NE; ctx->skip_var0 =3D tcg_temp_new(); ctx->free_skip_var0 =3D true; =20 @@ -1401,7 +1401,7 @@ static bool trans_SBRS(DisasContext *ctx, arg_SBRS *a) { TCGv Rr =3D cpu_r[a->rr]; =20 - ctx->skip_cond =3D TCG_COND_NE; + ctx->skip_cond =3D TCG_COND_EQ; ctx->skip_var0 =3D tcg_temp_new(); ctx->free_skip_var0 =3D true; =20 --=20 2.21.3