From nobody Mon Apr 29 06:42:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594104494; cv=none; d=zohomail.com; s=zohoarc; b=Jaj0ZJd696F3BzxDYIlLGnfoszu9xYk5wU2A5WDrqEaUw5ZlVkSL+C3WtAkuYRxiq/3cIrD+zYeH/wfelUfoQZtFNgJcRMuv42G4ByTB1XpQa66pHjN+x/G3pfEBGhGgBn4OTBF6WypnQrjdaGvg2RCPzCiOTrpRFpTNwaoPoKM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594104494; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vP24btoO2N26bkXvUhS4wjNttBxYNUYpNRsjcv1D964=; b=CixIP7JgtJ3Cw8c6V1iF5pKUeCaAYxyHbVVMwo/iEZpMe9BL/5KCEsHlOdTxolunyC9Avoa5cV1gclR+6OGrNEb8dpPRh/PpSIj/4R12hS7bzQmPlb2HK94d1lT3AmhP6G78iEkFH5B/a/G+vRgQZkiV/9T6t9T8oR9xZ0txBog= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594104494696815.8155038152595; Mon, 6 Jul 2020 23:48:14 -0700 (PDT) Received: from localhost ([::1]:39654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jshOn-0007TC-6s for importer@patchew.org; Tue, 07 Jul 2020 02:48:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jshNV-0005wB-2S for qemu-devel@nongnu.org; Tue, 07 Jul 2020 02:46:53 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:35374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jshNT-0000cA-E0 for qemu-devel@nongnu.org; Tue, 07 Jul 2020 02:46:52 -0400 Received: by mail-wm1-x342.google.com with SMTP id l2so43767775wmf.0 for ; Mon, 06 Jul 2020 23:46:51 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id 5sm2172545wmk.9.2020.07.06.23.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 23:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vP24btoO2N26bkXvUhS4wjNttBxYNUYpNRsjcv1D964=; b=KzHyPr/cKIrdvveEuO2OAf7eUvo9MxJBWnn8fvSGVoYurYFhqMrb34vRqY3rEWAoLI V37cTqKovpX1epcBjM/UO6LxX0hHynQfCJx+g4QDV6yTMnJeBubZwSMQpP4rIXPvgXLT TJsRQhQd+zkjEhz6uBfYbNpwstlyJxNS2GWqeInbPqG/jfHJkKoB0ocx35dFzsmpnKP2 9YFCePmpoNs3L/qxy4RT76Uc49+XLO2vWlH+Brvn8DWzz8lPIRKLUyB8A4bdi0uPYof2 r8D9kAmBxjUkJFU9nadx6LzG8FMf77YGfpCOS1EX8Eexv17xcHXtpbYXdOZp6KFKJft0 qBTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vP24btoO2N26bkXvUhS4wjNttBxYNUYpNRsjcv1D964=; b=nzAxtNTd2V9A04yib5bHPLdTEZ4W8fK1EpKTulELKgelI53q0YiiBQo1zxiVg796kz RvrZd99k0DrdQcsOijxIcQf4qryfEhdVpNDmx9pPtae0dbr+w/KvlMQlqLY+UiKxxRAW AOfLZcaUPZ1FJ5CQO1vD/+JD42h30FEwmNiiqacUtB16CBnKN3T9ngYnVhvXadQgZxfj WagOXBZE0XoEC98EcdVBopD1HIwHwBjAN7flladsQ+Qzhc5UM7IJQyenfQ2uRd3uliAb Wa0b0fD5Wrcr03VAiWPqdlEeHX1/vMaJW35v1PTvyzDLoS2o8dNOZIso8TkRsVn4Dah0 ZXnQ== X-Gm-Message-State: AOAM533UshlmKbWWpPmvmuthHqYQDTgDl1bpDXPwcvgc/CzCCw6LRfMA QhWxzp9PDOs0qq5poGOqvW7rtOxy X-Google-Smtp-Source: ABdhPJxLBh6XMrhAjGhjiI+BJza8VJpb0Gnuf4BQC4VdhDRc6FT6kZFtw8sxVBTY4EVhCRIf5yv7eA== X-Received: by 2002:a1c:4444:: with SMTP id r65mr2463826wma.129.1594104409883; Mon, 06 Jul 2020 23:46:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] target/avr: Drop tlb_flush() in avr_cpu_reset() Date: Tue, 7 Jul 2020 08:46:44 +0200 Message-Id: <20200707064646.7603-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200707064646.7603-1-f4bug@amsat.org> References: <20200707064646.7603-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , Thomas Huth , Joaquin de Andres , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Rolnik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e --- target/avr/cpu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 4e4dd4f6aa..50fb1c378b 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -78,8 +78,6 @@ static void avr_cpu_reset(DeviceState *ds) env->skip =3D 0; =20 memset(env->r, 0, sizeof(env->r)); - - tlb_flush(cs); } =20 static void avr_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) --=20 2.21.3 From nobody Mon Apr 29 06:42:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594104497; cv=none; d=zohomail.com; s=zohoarc; b=aMli1zdhAqEwnZBH3+QasJpLeV6SQ7zWzpsyarD43VTWKqIJ9QRmzybnwXgD2oxeS/jA3dAHicHfR0anLZX/cGIGxdsTpIpCjnw3a54Z2rri0hETgvBUQok+zl3bIpGN5vKhDOJNSSV1GxNAdW+0OcE9xQ+waQgHa05prxdRzxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594104497; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OAALL/cw7n/+7fM0VWJqcBq9KNUXzDegINtW6gZFwpE=; b=G9VCATTFjrWfaZwBBEbO0ae/BzSypEW44AVB9orB/xVtNByI9ocsiFn+iSN4Cct2ILtvTfYCOZtaXV2KS7Akfd1xmQxi2/OL807g2RLnAcjSwclSGduIFVuekpzsmCb7YfGMdOllpK85PbhnW6V/lZbnXrk87T6eGBApM8QU+PY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159410449723539.92207862566568; Mon, 6 Jul 2020 23:48:17 -0700 (PDT) Received: from localhost ([::1]:39952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jshOp-0007aT-NW for importer@patchew.org; Tue, 07 Jul 2020 02:48:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jshNV-0005wP-OS for qemu-devel@nongnu.org; Tue, 07 Jul 2020 02:46:53 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:36070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jshNU-0000cE-Fc for qemu-devel@nongnu.org; Tue, 07 Jul 2020 02:46:53 -0400 Received: by mail-wm1-x332.google.com with SMTP id 17so45206812wmo.1 for ; Mon, 06 Jul 2020 23:46:52 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id 5sm2172545wmk.9.2020.07.06.23.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 23:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OAALL/cw7n/+7fM0VWJqcBq9KNUXzDegINtW6gZFwpE=; b=gJZsYghd9IMqY6Xpzg4t1DXJxI4iLNVJsRsfTuB+J6fsNNt8zB9sLvbXRysZr+VhqX H6rtbbyXrEnqVTN9zmYmHmGpeXPaxY3z01s8mw4iLSqbn2ZtpdjNjEIi2R3Ro5p6wIOR v5Q7od1EXZgFPAT/cAzABR5xNN08wLogQt7zohgPHTrBJNeZTBTHAEE0xUo3rDJIF2kx 2/cFnazRgANFJybh1wlTJhk99KK7XBczT+Y9fSj32APOYxk4Nq8E87hNx1mycdd9+nb3 kVWNoJFVWv/OCQI9WsGOatiszOWTiFy5gF7uWTpgTY4q0DQspfgOZZlJ7+xfuRwt3LlR njZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=OAALL/cw7n/+7fM0VWJqcBq9KNUXzDegINtW6gZFwpE=; b=l2wY+si0E8JFuGWpOVX8lyuTZTKKmXjYpa35iMM25s14jDZjLyq0wW/rcnwwls90AO yOY4U0A77avXlpTrcMQGZMqxKmbXzuD+7QcBk2r5m5MER8wo98MuPVJhDLzc3u84ixwi 4QXn77NBiMcuqd2rbiA8IEMCzN5DUmioyJ+gjEFpbDe6OByJa1QudtmfXtOkmat2Pbir Ak/QpzbIQUlmunEIC3dieG/XAJSfg6tl2BMBBaw2YSKXGcS2SuAEAhITyoC/EDMlBLX8 dkx+dWbVQtvEL8g3fZ6fhXWnEjCxkbmWEyRPVTXi5iv5mOFAL6xIiysTl451RiqbE5yW 4Hgw== X-Gm-Message-State: AOAM531SksvJwLmVNHvEMkIh3K7lUpkJM95kN5ZpfrFM5Brrplkf3Ye0 EA0jpUVA3eCObjZHdQeLP/SBzYkr X-Google-Smtp-Source: ABdhPJyFEDx+NByKlEgjZnpSWjc+gK2vB1pJBtONnNTJJxU4TgBxHNYJ6Zdr1fRLhyDfwNPmFMjVTQ== X-Received: by 2002:a05:600c:2116:: with SMTP id u22mr2512882wml.82.1594104410976; Mon, 06 Jul 2020 23:46:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/3] target/avr: Fix $PC displayed address Date: Tue, 7 Jul 2020 08:46:45 +0200 Message-Id: <20200707064646.7603-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200707064646.7603-1-f4bug@amsat.org> References: <20200707064646.7603-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , Thomas Huth , Joaquin de Andres , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Rolnik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) $PC is 16-bit wide. Other registers display addresses on a byte granularity. To have a coherent ouput, display $PC using byte granularity too. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e --- target/avr/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 50fb1c378b..9be464991f 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -151,7 +151,7 @@ static void avr_cpu_dump_state(CPUState *cs, FILE *f, i= nt flags) int i; =20 qemu_fprintf(f, "\n"); - qemu_fprintf(f, "PC: %06x\n", env->pc_w); + qemu_fprintf(f, "PC: %06x\n", env->pc_w * 2); qemu_fprintf(f, "SP: %04x\n", env->sp); qemu_fprintf(f, "rampD: %02x\n", env->rampD >> 16); qemu_fprintf(f, "rampX: %02x\n", env->rampX >> 16); --=20 2.21.3 From nobody Mon Apr 29 06:42:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594104606; cv=none; d=zohomail.com; s=zohoarc; b=Eseeku9N6enJwgbbTToKiFi2t0jGJbRtp1ZMA+uWzLOT5GEmPu9WezrApZwmAa5r/JJQVfT07qkIESwC1/DWkYGcI/JTJxrrdaAtdz3iXNDekCVCQCVsY/c7Ct23Z9slyx6y32731j9T/TeJSiT2kJEXISbONejHnZElQ4akbws= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594104606; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=45gqo128NQDtIYcxM1tYqwMqbUrJDll0ND7eZVJPFlA=; b=HaK+G0i+UUn/0dXZbMSrhw/2/UpRR/leOhBnalMu857IMQn7LwCfBh+YiDlIlaeq9MVpG0YGlcktotCucfooDMkldhpAd7xLGHNIgQR2w+2kwdJBszgGVgaq+fsKuYRirL7OcngsG0fH/SeTBCSgtFFF01d6dtSpS5Q6WzknrQ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594104606403357.6302168722151; Mon, 6 Jul 2020 23:50:06 -0700 (PDT) Received: from localhost ([::1]:46144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jshQb-0001s6-82 for importer@patchew.org; Tue, 07 Jul 2020 02:50:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jshNX-0005yp-8m for qemu-devel@nongnu.org; Tue, 07 Jul 2020 02:46:55 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:38936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jshNV-0000cS-Q2 for qemu-devel@nongnu.org; Tue, 07 Jul 2020 02:46:54 -0400 Received: by mail-wr1-x441.google.com with SMTP id q5so43876161wru.6 for ; Mon, 06 Jul 2020 23:46:53 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id 5sm2172545wmk.9.2020.07.06.23.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 23:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=45gqo128NQDtIYcxM1tYqwMqbUrJDll0ND7eZVJPFlA=; b=CbIRTfP5fVKDPO1sN6Nm0ogTmJfT+Dfo1iIcerZgjhiH0iDVsjz/5QNznQnTdGf5wx 9Eim4CkUeEGTObMUz3StaGabfv+uehIX/ldfUu6HSEO9wRsrQB1WClui423ZkxwjMlmc yXhXbdSCKU1955OjD+8mOdh48gsLLUZZFOQbV+Z++9Bd0RPsdvTEyBfSqaiN0Z3Msgz7 Zz05Ru18w/H/e22aPE8s5BqikwBf+ddHdE4X2esNJ6tHs64Q8xViTjKwjJcMtEjN0O7j rkUAj1uQA5Gj6eurEWlglgS4EbwYDAIm88nky5xj+9IDgOT6WqCleEa+QVGCbz8xOO07 fEcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=45gqo128NQDtIYcxM1tYqwMqbUrJDll0ND7eZVJPFlA=; b=RZcjijMt5LlA8my42YNe6xu53z6hNm3RbA4oB+o7tdSlqvC5I2DTKNR0fRNHULuJns mRzkgjxmaxDyth3Vxieoo5M3MPPm0HdbQpb0BFPKRxO82lmDZgYLRUnBlMQKLLx/HA6u jrDLCvVuNtCx3Jh55QXJ602lQ9zMhrzAyAf/3HcXcs6GYr/o1SJQmdaMzBqfB9ixwlvy 5042i037yfMCW1aGa89uLLDNO5JK6npOIV5dkP6vFYoETmGdw8IT1zN9LJ3MWpvKAE0N DcHC7qcFitmeiop7Us2U4ZaIMoepfpjwC0kxDVQSMoBht2uF2YUBP7ukhItBgrURNnx/ DPjg== X-Gm-Message-State: AOAM5300WCeqZSxVTusOZEcOFDj+qxmol8OdpbI4a3ABVW5rFDa1so+H uj6cLsAJY8224oB0yZ+VJxYvj3AA X-Google-Smtp-Source: ABdhPJz1e+iyP5oeF2NLNfiia5QAPkhVTinWNpZs7ATzEslZOrqFFWpj7t81XolHzMqqHHmhCo/GOQ== X-Received: by 2002:a5d:518a:: with SMTP id k10mr51088210wrv.316.1594104412217; Mon, 06 Jul 2020 23:46:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 3/3] target/avr: Fix SBRC/SBRS instructions Date: Tue, 7 Jul 2020 08:46:46 +0200 Message-Id: <20200707064646.7603-4-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200707064646.7603-1-f4bug@amsat.org> References: <20200707064646.7603-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Harris , Thomas Huth , Joaquin de Andres , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Rolnik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) SBRC/SBRS instructions seem to be inverted. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/avr/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index fe03e676df..2f77fe3ba7 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -1385,7 +1385,7 @@ static bool trans_SBRC(DisasContext *ctx, arg_SBRC *a) { TCGv Rr =3D cpu_r[a->rr]; =20 - ctx->skip_cond =3D TCG_COND_EQ; + ctx->skip_cond =3D TCG_COND_NE; ctx->skip_var0 =3D tcg_temp_new(); ctx->free_skip_var0 =3D true; =20 @@ -1401,7 +1401,7 @@ static bool trans_SBRS(DisasContext *ctx, arg_SBRS *a) { TCGv Rr =3D cpu_r[a->rr]; =20 - ctx->skip_cond =3D TCG_COND_NE; + ctx->skip_cond =3D TCG_COND_EQ; ctx->skip_var0 =3D tcg_temp_new(); ctx->free_skip_var0 =3D true; =20 --=20 2.21.3