From nobody Sat May 4 10:12:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594092029; cv=none; d=zohomail.com; s=zohoarc; b=DrXDQXLcD5n7O6OxGHus9fMsVrCWfSZagiJzPhxp3pb7LU/isfgh7V4+3SuBnzsP6Tg/8g8XwHezwYWXyUWAJJLtxg3mSR3n9YCKGy9DOUgSt/3LLfL4d3Ps/mPGWrtQPl2r91BS8mSgU9ZN4wyPTsu/B+eIWC5RaMRJcT8/5Bs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594092029; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=XMQcln6beIWM2wCoIS7T1da/Ok91kBytCDOiJC9/fuA=; b=YR8xGhO/riQNhNI99gHK5ul6vUffgIVsUN7242NcF/1WXcRycPiLDAv9YbWxTbLpTv7dH711agMX6GVknVPVYp/m/aMYW+9dU8N3xblmMcXQwd9BTKOuZ97lVRDwwpccjyFQsoKS5huGV8ik0GZJv0GLxyYb8J6vETkT+dkQXB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594092029237248.11913152105706; Mon, 6 Jul 2020 20:20:29 -0700 (PDT) Received: from localhost ([::1]:45548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jse9i-0004DL-5O for importer@patchew.org; Mon, 06 Jul 2020 23:20:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jse96-0003mR-79 for qemu-devel@nongnu.org; Mon, 06 Jul 2020 23:19:48 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:55314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jse94-0002J0-Fm for qemu-devel@nongnu.org; Mon, 06 Jul 2020 23:19:47 -0400 Received: by mail-wm1-x341.google.com with SMTP id g75so41508251wme.5 for ; Mon, 06 Jul 2020 20:19:24 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id 30sm27832456wrm.74.2020.07.06.20.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 20:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XMQcln6beIWM2wCoIS7T1da/Ok91kBytCDOiJC9/fuA=; b=iBkjIO+W+clGkH17LPtEMc5AA55jA/McoWHT/9QCWQa3/QTFbFJJnPRKW7jmq5P2nM wFnK17r7B9NwkKs3lLUAn8w3iKV+HSiZ+jp8NVxEfL/blScvkHU1P66FvnyxBCL9eejE rydaMbL1KXR3qkinCpJGhcEvtfhg5pFtNZusz2EcoCatkgV3ZA4UkK+Je6bXbgmLEYCI C41F/4TN3wLHX9CrxmaPcX0ySun7feFGtPHPYovI30ap7J2uYWlzNvzxENiP94NwFRd/ XnEotC/1uFs6fwX0wvFgQU9lkkYdiY+1BV2rgo5Fq7Wxtqq1i+WbkBWhgoKZYJ/urX0I DkBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=XMQcln6beIWM2wCoIS7T1da/Ok91kBytCDOiJC9/fuA=; b=mYgCWu3JUfH//O4grxbwVVz9/Sm8/ATJyb1gUgx5WBh3K1q2hOIhnSUdMYspyqJikQ NTtw85qcv6Ev2Tznn06Iijiqyo6kVvDCFZOVsCK0to1tk4delKZxdlrgmv1LOGV9oCo8 gzfmC2Xtyg+fIgGI1/jkWy5RKEA5mAMc3RyyyQPh2DgAVaeQ/7OYGqVvd9WanUD7Rtgn EkbZ3sM4tHGVo4AKfWicEqol9eVuLpJzURiI+lFAYPqePFa3NBl50/eqc1Z0mUMq5Iub yaPHb8xDw96nW6sBXgxpc2u41JMfWJkmt6CqF1Rd2Bx4p7FiTcl+TOGGqRqggRumcypQ m89w== X-Gm-Message-State: AOAM531Y2eeENcxA6qOphW+r+xK/k9zhvKSau6JLRKnZ1gibmeouQOvJ rzuq23IwHUXPUVkfjdqb5hc7PlXc X-Google-Smtp-Source: ABdhPJwjyHPIY68153KOxAfk6W6fhxBJByAW3dx+vq133f701X8I2hEAWta8yA3Dr13bW3vFxc512A== X-Received: by 2002:a7b:ca52:: with SMTP id m18mr1888210wml.92.1594091962946; Mon, 06 Jul 2020 20:19:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] tests/qtest/libqtest: Do not overwrite child coredump Date: Tue, 7 Jul 2020 05:19:20 +0200 Message-Id: <20200707031920.17428-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Richard Henderson , Markus Armbruster , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yury Kotov , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) We are interested by the coredump of the child, not the qtest parent. If the child generated a coredump, simply call exit(EXIT_FAILURE) in the parent to avoid overwriting the child coredump. Fixes: 71a268a5fd ("tests/libqtest: Improve kill_qemu()") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/libqtest.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 49075b55a1..bd85d01145 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -173,7 +173,12 @@ static void kill_qemu(QTestState *s) fprintf(stderr, "%s:%d: kill_qemu() detected QEMU death " "from signal %d (%s)%s\n", __FILE__, __LINE__, sig, signame, dump); - abort(); + if (WCOREDUMP(wstatus)) { + /* Preserve child coredump */ + exit(1); + } else { + abort(); + } } } =20 --=20 2.21.3