From nobody Wed May 8 15:05:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1594070116; cv=none; d=zohomail.com; s=zohoarc; b=YqOcxu3em7+IxAVhoEicoE1VGbqCT+gvm6KxWGD/LfYCDIVipqpKm5FsM/5i/toKMJhE7IOWOrbG/c1aKbWsB+QNRIHzYui3amuGbWNhxq0naZOYCoY+rHZmcE5c5DYN4n+4iiVIhgD/k7hCQKH2lAzv86Y2sRLEa/NMxX9/rK8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594070116; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=acjGGWgKUJvrZGoxpYJl7P/XI7BGZw5IGivnyAMuxD8=; b=LWL4+qeNAhGpVqaYUnsvAjzHzSG53DtMRtBZzLmWgMnI0ROgia5NoBbyWs6We7vX6Ir75sges6V0cqckru9vB9MV0xZS8JXh4V/wIbMUw2VXkM4DeYi5ZE+/jBp5ENr/O6MceV7GtQbQtNGbDGaW0DmXOaFvJbknSpn1QLCPc9A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159407011635786.72672828752684; Mon, 6 Jul 2020 14:15:16 -0700 (PDT) Received: from localhost ([::1]:33438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsYSJ-0007nx-2S for importer@patchew.org; Mon, 06 Jul 2020 17:15:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsYRB-0006ch-Ea for qemu-devel@nongnu.org; Mon, 06 Jul 2020 17:14:05 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:37209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsYR9-0000F0-Nl for qemu-devel@nongnu.org; Mon, 06 Jul 2020 17:14:05 -0400 Received: by mail-pf1-x444.google.com with SMTP id s26so3843159pfm.4 for ; Mon, 06 Jul 2020 14:14:03 -0700 (PDT) Received: from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0]) by smtp.gmail.com with ESMTPSA id n137sm20577800pfd.194.2020.07.06.14.14.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jul 2020 14:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=acjGGWgKUJvrZGoxpYJl7P/XI7BGZw5IGivnyAMuxD8=; b=WBCFCdSTS3kipc8fbgW8GzB75GMLoJmpDVAmvzyUTZWCvY6bJ+ODidOlfygSGV8r2R WuilLDpX6mwnw7CH8yJXTHOyX4FzUY5Khi0EYxjNzxMWZSXY8QAIaq1RWNhU362nzN45 iNPK2fsrsmAXLiKW1LdAEjmENbaOMT426KRywzNQR/W6vRsyE8NqEmFJDiOnjrH616Nz BHYaWD4z+9NtaUmm9hKHn3De/kXRitq/ZQxmKTx88yYuZy6pUf4trdKjy/FVKqykiY7g mzVlZrUnsLar1/MVSjwLfGDNE/PUgJKdWN5fAL1B0CH0/vXeCZGW7VBQs0L4PoYG1kFI wjZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=acjGGWgKUJvrZGoxpYJl7P/XI7BGZw5IGivnyAMuxD8=; b=IzRkKZaauxs9YFDvKbayI5fPw+XX4a2DR1N5U2xgN6qNtlJ+8NZZRRCxrYJ5HS4MVT cdHWEda1KiGpGezBnVUOWLXvqkjl1BoRFkPrzb78NvFmVzcIiHBS6I62DNoVflLOvSKb 2OYTOlda8PrJRSRgzMOzuiqfrdkaDE3+yrULoxpvV68/OgLAu/Sb5uza3wVnNZjHsKlb CVqwqwwvPFNe+GC9itrCGoRuchgILVimVk+t3ES01pKrq1kpQP4CMyGn9hjP+lwxZTNU XL2dHuGIb0xmTsVMS5iYEsIHxPryrFff9GWMwNeZU+A2kblmXotxVUAm9MT16zQM4Bdw xKsA== X-Gm-Message-State: AOAM532nDYt8FFjhOxCZwbWFS/jZeahjZoP0jMmk+8FB54BzfwhjvUde L2ZXXHxk+C15zFS8VCghtv4= X-Google-Smtp-Source: ABdhPJzhNEioIrZdCtWVT1ZFkq8HYSmAOHrT3tnC+6B+k9bDH9Kd/0EYXS/E3xjF+ZY9duaK9bzJsg== X-Received: by 2002:a63:6e4c:: with SMTP id j73mr40789500pgc.182.1594070041844; Mon, 06 Jul 2020 14:14:01 -0700 (PDT) Subject: [PATCH v2 1/3] virtio-balloon: Prevent guest from starting a report when we didn't request one From: Alexander Duyck To: david@redhat.com, mst@redhat.com Date: Mon, 06 Jul 2020 14:14:00 -0700 Message-ID: <20200706211400.20018.89031.stgit@localhost.localdomain> In-Reply-To: <20200706211314.20018.89695.stgit@localhost.localdomain> References: <20200706211314.20018.89695.stgit@localhost.localdomain> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::444; envelope-from=alexander.duyck@gmail.com; helo=mail-pf1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) From: Alexander Duyck Based on code review it appears possible for the driver to force the device out of a stopped state when hinting by repeating the last ID it was provided. Prevent this by only allowing a transition to the start state when we are in the requested state. This way the driver is only allowed to send one descriptor that will transition the device into the start state. All others will leave it in the stop state once it has finished. Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Acked-by: David Hildenbrand Signed-off-by: Alexander Duyck --- hw/virtio/virtio-balloon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 10507b2a430a..0c0fd7114799 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -527,7 +527,8 @@ static bool get_free_page_hints(VirtIOBalloon *dev) ret =3D false; goto out; } - if (id =3D=3D dev->free_page_report_cmd_id) { + if (dev->free_page_report_status =3D=3D FREE_PAGE_REPORT_S_REQUEST= ED && + id =3D=3D dev->free_page_report_cmd_id) { dev->free_page_report_status =3D FREE_PAGE_REPORT_S_START; } else { /* From nobody Wed May 8 15:05:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1594070125; cv=none; d=zohomail.com; s=zohoarc; b=hVyLMBIF+eVEceevSAj+WrQP/7RoYKNQMMhgLP5GOOg8bbckP8CSfftUsv16wZftem4prtoZZYaydLNkz9CEsP6baIYOHkyHlFa+XHth1zeyxu1MXlesozuC97oNiFyF2QxQ+ZgKFEmcHaF+sA1j+MgbAcEJvkrfkp7dxOSVIoA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594070125; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uMeY2M7/mS/0n1w9o0LfcRh5FR+KNB3RWjicNkUWe8A=; b=V+mtm6DZdcaFUO61XUQdhdP0ta4DN4NAEUjXLo0WAQLzxf2k7ycpl83oU/MneVmVGTHPqxWXCT//zDvNMS79rRpUH13ftPEb7bDqA/CmManwn6Kvd8hsqxAP8SLegCRgE+t9vCybG/BpmS0SaHrxbAYy6HJdxEoHRqlHbvUNEeY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594070125043315.94792578529757; Mon, 6 Jul 2020 14:15:25 -0700 (PDT) Received: from localhost ([::1]:34106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsYSR-00085U-Ki for importer@patchew.org; Mon, 06 Jul 2020 17:15:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsYRJ-0006oP-5K for qemu-devel@nongnu.org; Mon, 06 Jul 2020 17:14:13 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:34421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsYRH-0000HF-89 for qemu-devel@nongnu.org; Mon, 06 Jul 2020 17:14:12 -0400 Received: by mail-pl1-x644.google.com with SMTP id o1so9253230plk.1 for ; Mon, 06 Jul 2020 14:14:09 -0700 (PDT) Received: from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0]) by smtp.gmail.com with ESMTPSA id v28sm20397808pgc.44.2020.07.06.14.14.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jul 2020 14:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=uMeY2M7/mS/0n1w9o0LfcRh5FR+KNB3RWjicNkUWe8A=; b=BAjdhT1Hj7d1jWsXXdDMb/DFYgBg6VUnvd9jGpOujAnNH5rNO4phu2cxMLwdHjmfhU ul9ud4S7DRBm5pZ4HUSMylrSSDAYNO6JvmXY93so/aZyVvA36aNZXtaNE6FcjH47qgoX JeKCqjNYmhyLTBTARFm1lNQIFMSmklvma062taCg2uCuzS3FoBISQ5ofzize4vDEiY/H X3mVETwbl9HIMDYH++na2QnWftpragMnsj1J3KZS5pDbFFDoW98xQ56Ab53up3e+PX9u pwL3t1khkbenifVvuVhR3vqmKm+Lx3iv2hIGKRl6Gf1Mp/s0iG4fxYHj0Ov7MdWtzUq3 t34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=uMeY2M7/mS/0n1w9o0LfcRh5FR+KNB3RWjicNkUWe8A=; b=InWkS6auqE2ZKNAZGgWtHy+6zbSwVfZ4wMoX2guYngq01Sfb6BYwAvDUA9VhiLET82 iOGCMyrILMwmFUzgpnUFCUfqgmPlIYWr8jI/ZDYo5HieTsS7QTHrauD3MoQR9LZDkdmY ajYOhp64vSEScllKSBa3VncJvWGlWJxmXT8Z4yP8q+zNdXzWt8ZvitbscQSmsofUw4xU dTBjL5kYh1ZX+g2ouHDhCP9nToxKBxjRaClvYRgn7epP3y1bFJ8H/V9B2CyNcws9QWty Xi74ZtE2y8Md3LWcMZstvcF9mYfNqjj0c9fSgEEcPwIVC98iqV4lXvvFGFfy37UMmpuQ 0pvg== X-Gm-Message-State: AOAM531TT1ffjFvY6z1o1+6Y2QP1v4AJtQEWl89ZzG6882joMsneGa0R 8Y+P4+/biCrtJr48vfxs9SQ= X-Google-Smtp-Source: ABdhPJxeOxhLlr8JHQ4IBGLFjw5G3q/E2zn5t9OnC1a/HRP/HxgxSIgooJOifd1hle4T/+1RIHiq4w== X-Received: by 2002:a17:90a:e7cd:: with SMTP id kb13mr1016385pjb.138.1594070048882; Mon, 06 Jul 2020 14:14:08 -0700 (PDT) Subject: [PATCH v2 2/3] virtio-balloon: Add locking to prevent possible race when starting hinting From: Alexander Duyck To: david@redhat.com, mst@redhat.com Date: Mon, 06 Jul 2020 14:14:07 -0700 Message-ID: <20200706211407.20018.51061.stgit@localhost.localdomain> In-Reply-To: <20200706211314.20018.89695.stgit@localhost.localdomain> References: <20200706211314.20018.89695.stgit@localhost.localdomain> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=alexander.duyck@gmail.com; helo=mail-pl1-x644.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) From: Alexander Duyck There is already locking in place when we are stopping free page hinting but there is not similar protections in place when we start. I can only assume this was overlooked as in most cases the page hinting should not be occurring when we are starting the hinting, however there is still a chance we could be processing hints by the time we get back around to restarting the hinting so we are better off making sure to protect the state with the mutex lock rather than just updating the value with no protections. Signed-off-by: Alexander Duyck Acked-by: David Hildenbrand --- hw/virtio/virtio-balloon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 0c0fd7114799..b3e96a822b4d 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -593,6 +593,8 @@ static void virtio_balloon_free_page_start(VirtIOBalloo= n *s) return; } =20 + qemu_mutex_lock(&s->free_page_lock); + if (s->free_page_report_cmd_id =3D=3D UINT_MAX) { s->free_page_report_cmd_id =3D VIRTIO_BALLOON_FREE_PAGE_REPORT_CMD_ID_MIN; @@ -601,6 +603,8 @@ static void virtio_balloon_free_page_start(VirtIOBalloo= n *s) } =20 s->free_page_report_status =3D FREE_PAGE_REPORT_S_REQUESTED; + qemu_mutex_unlock(&s->free_page_lock); + virtio_notify_config(vdev); } =20 From nobody Wed May 8 15:05:22 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1594070196; cv=none; d=zohomail.com; s=zohoarc; b=T3Cr4tghFAdDOzX3o4KUw71LurjHHBcbuiNYMvX/oXa6ITkdQK6qFFTx8sccM+WsHXUWXiauv0idtZJXklIl0j6M4os52/lKsEcZnJNjtkNcAoDdYaYvfcuYRTXaLk7LcQgZXXX48O3fI/Nr1uKXJW59dbzhgQ9R/k/OzLH3MHc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594070196; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4o19OsDe9oFfHbhDQkXw6x1QFNSe+TGuSxA03xPCfOE=; b=KfWzejcE41UjVWJosbBy3xnv3ug1zJ+QSk/KAtRbv5gr3iZeIHyLMAN8348ZBuXnT2DDaKNs0YBfHdoanhGdY8q6xBkiRR5zqzLxeGUR/7czTHW0yXw2ulSHk9OYmO2gXuoaSXXyXTUgHdzBfh1wKfQmD/gVIJdTu2xzh4KOP6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594070196601840.4138260855516; Mon, 6 Jul 2020 14:16:36 -0700 (PDT) Received: from localhost ([::1]:37804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsYTb-0001Ft-AZ for importer@patchew.org; Mon, 06 Jul 2020 17:16:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsYRP-000719-GM for qemu-devel@nongnu.org; Mon, 06 Jul 2020 17:14:19 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:44276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsYRN-0000Hx-6g for qemu-devel@nongnu.org; Mon, 06 Jul 2020 17:14:19 -0400 Received: by mail-pg1-x543.google.com with SMTP id j19so12095675pgm.11 for ; Mon, 06 Jul 2020 14:14:16 -0700 (PDT) Received: from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0]) by smtp.gmail.com with ESMTPSA id w18sm19966888pgj.31.2020.07.06.14.14.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jul 2020 14:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=4o19OsDe9oFfHbhDQkXw6x1QFNSe+TGuSxA03xPCfOE=; b=u3FcFbSlcQQnZArg02xCOwy+LL1DZC8HOmQAmltihMRoJvo0dwUWOp2qfo18v9KClK kGP6Qws6WOOXokSo1EyXD4I1SA8MQRD05GUK8YkoQvao8Am2qJsdNv8bkrikJj7/lAQ6 vzIRZywP0sCgbUXRxcVwA4NLxBeIJJwnm8YIpS6umyOiicG/OTBgLKhr1krNi25KJqkr Qrv0X/Ul8uLHFRWSTbwV5zUuZsfjGVYOAWnmUSSwrcLw3DM7w5+y75v+DMJhi6i6wbLH elJVJt+r99CG26erLZu3jtMuPEeSJLdJhzDvsrZF9agfvTwAkRkh5cb4LUKV8U91+2rJ +CEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4o19OsDe9oFfHbhDQkXw6x1QFNSe+TGuSxA03xPCfOE=; b=QOJbvZBu9Nyzz25Baj4fA1sy6RzecO0sOhtFzBQuoyiOPoLo/iloku4+ycjycxp2Fm 23iKDXRc70rOtEzlu1mO7clmOfoGbIUmGTvjDaRUmAeNJBLsceRlrUJLDcfUlVzyN9pI BRG9fXtVVNfOTOQEilrkA+/FEi6uTZaG9B2TONiiFuMY/LiDW/LFxmgBqySvcHRLQe4z 3ryfy3J3/PxrXDt++9prY9Hg1l99CyDgqpD88240sHg9UzpzNTBdxGLZFT2/VDpP/kKd kk0Bcu+SkVoglIKaYvBd4DVlFywXT4LbvJr9MfAZoCerISsTmRHJh0xPHqNBtyBdMg+b UNZQ== X-Gm-Message-State: AOAM530fJ3Q9hkkfUWRNtJnUEnt5q3XUh6L9L8tAm6d19yB+fYVI73xa 1yUDRdToyN0ZfUw2zPkvb4s= X-Google-Smtp-Source: ABdhPJy1hFn/LIfoNhWMTkpno1bp3vqYyA0PoIlmSj+Hlu+T0DIQXgPety0IPybGCq9dyFrh0lubDA== X-Received: by 2002:a63:6744:: with SMTP id b65mr22083667pgc.42.1594070055646; Mon, 06 Jul 2020 14:14:15 -0700 (PDT) Subject: [PATCH v2 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint' From: Alexander Duyck To: david@redhat.com, mst@redhat.com Date: Mon, 06 Jul 2020 14:14:14 -0700 Message-ID: <20200706211414.20018.89815.stgit@localhost.localdomain> In-Reply-To: <20200706211314.20018.89695.stgit@localhost.localdomain> References: <20200706211314.20018.89695.stgit@localhost.localdomain> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=alexander.duyck@gmail.com; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) From: Alexander Duyck Recently a feature named Free Page Reporting was added to the virtio balloon. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report' with 'hint" when we are referring to free page hinting. Acked-by: David Hildenbrand Signed-off-by: Alexander Duyck --- hw/virtio/virtio-balloon.c | 74 ++++++++++++++++++--------------= ---- include/hw/virtio/virtio-balloon.h | 20 +++++----- 2 files changed, 47 insertions(+), 47 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index b3e96a822b4d..a21e7c3db538 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -527,22 +527,22 @@ static bool get_free_page_hints(VirtIOBalloon *dev) ret =3D false; goto out; } - if (dev->free_page_report_status =3D=3D FREE_PAGE_REPORT_S_REQUEST= ED && - id =3D=3D dev->free_page_report_cmd_id) { - dev->free_page_report_status =3D FREE_PAGE_REPORT_S_START; + if (dev->free_page_hint_status =3D=3D FREE_PAGE_HINT_S_REQUESTED && + id =3D=3D dev->free_page_hint_cmd_id) { + dev->free_page_hint_status =3D FREE_PAGE_HINT_S_START; } else { /* * Stop the optimization only when it has started. This * avoids a stale stop sign for the previous command. */ - if (dev->free_page_report_status =3D=3D FREE_PAGE_REPORT_S_STA= RT) { - dev->free_page_report_status =3D FREE_PAGE_REPORT_S_STOP; + if (dev->free_page_hint_status =3D=3D FREE_PAGE_HINT_S_START) { + dev->free_page_hint_status =3D FREE_PAGE_HINT_S_STOP; } } } =20 if (elem->in_num) { - if (dev->free_page_report_status =3D=3D FREE_PAGE_REPORT_S_START) { + if (dev->free_page_hint_status =3D=3D FREE_PAGE_HINT_S_START) { qemu_guest_free_page_hint(elem->in_sg[0].iov_base, elem->in_sg[0].iov_len); } @@ -568,11 +568,11 @@ static void virtio_ballloon_get_free_page_hints(void = *opaque) qemu_mutex_unlock(&dev->free_page_lock); virtio_notify(vdev, vq); /* - * Start to poll the vq once the reporting started. Otherwise, conti= nue + * Start to poll the vq once the hinting started. Otherwise, continue * only when there are entries on the vq, which need to be given bac= k. */ } while (continue_to_get_hints || - dev->free_page_report_status =3D=3D FREE_PAGE_REPORT_S_START); + dev->free_page_hint_status =3D=3D FREE_PAGE_HINT_S_START); virtio_queue_set_notification(vq, 1); } =20 @@ -595,14 +595,14 @@ static void virtio_balloon_free_page_start(VirtIOBall= oon *s) =20 qemu_mutex_lock(&s->free_page_lock); =20 - if (s->free_page_report_cmd_id =3D=3D UINT_MAX) { - s->free_page_report_cmd_id =3D - VIRTIO_BALLOON_FREE_PAGE_REPORT_CMD_ID_MIN; + if (s->free_page_hint_cmd_id =3D=3D UINT_MAX) { + s->free_page_hint_cmd_id =3D + VIRTIO_BALLOON_FREE_PAGE_HINT_CMD_ID_MIN; } else { - s->free_page_report_cmd_id++; + s->free_page_hint_cmd_id++; } =20 - s->free_page_report_status =3D FREE_PAGE_REPORT_S_REQUESTED; + s->free_page_hint_status =3D FREE_PAGE_HINT_S_REQUESTED; qemu_mutex_unlock(&s->free_page_lock); =20 virtio_notify_config(vdev); @@ -612,18 +612,18 @@ static void virtio_balloon_free_page_stop(VirtIOBallo= on *s) { VirtIODevice *vdev =3D VIRTIO_DEVICE(s); =20 - if (s->free_page_report_status !=3D FREE_PAGE_REPORT_S_STOP) { + if (s->free_page_hint_status !=3D FREE_PAGE_HINT_S_STOP) { /* * The lock also guarantees us that the * virtio_ballloon_get_free_page_hints exits after the - * free_page_report_status is set to S_STOP. + * free_page_hint_status is set to S_STOP. */ qemu_mutex_lock(&s->free_page_lock); /* - * The guest hasn't done the reporting, so host sends a notificati= on - * to the guest to actively stop the reporting. + * The guest isn't done hinting, so send a notification + * to the guest to actively stop the hinting. */ - s->free_page_report_status =3D FREE_PAGE_REPORT_S_STOP; + s->free_page_hint_status =3D FREE_PAGE_HINT_S_STOP; qemu_mutex_unlock(&s->free_page_lock); virtio_notify_config(vdev); } @@ -633,15 +633,15 @@ static void virtio_balloon_free_page_done(VirtIOBallo= on *s) { VirtIODevice *vdev =3D VIRTIO_DEVICE(s); =20 - s->free_page_report_status =3D FREE_PAGE_REPORT_S_DONE; + s->free_page_hint_status =3D FREE_PAGE_HINT_S_DONE; virtio_notify_config(vdev); } =20 static int -virtio_balloon_free_page_report_notify(NotifierWithReturn *n, void *data) +virtio_balloon_free_page_hint_notify(NotifierWithReturn *n, void *data) { VirtIOBalloon *dev =3D container_of(n, VirtIOBalloon, - free_page_report_notify); + free_page_hint_notify); VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); PrecopyNotifyData *pnd =3D data; =20 @@ -690,7 +690,7 @@ static size_t virtio_balloon_config_size(VirtIOBalloon = *s) if (virtio_has_feature(features, VIRTIO_BALLOON_F_FREE_PAGE_HINT)) { return offsetof(struct virtio_balloon_config, poison_val); } - return offsetof(struct virtio_balloon_config, free_page_report_cmd_id); + return offsetof(struct virtio_balloon_config, free_page_hint_cmd_id); } =20 static void virtio_balloon_get_config(VirtIODevice *vdev, uint8_t *config_= data) @@ -702,14 +702,14 @@ static void virtio_balloon_get_config(VirtIODevice *v= dev, uint8_t *config_data) config.actual =3D cpu_to_le32(dev->actual); config.poison_val =3D cpu_to_le32(dev->poison_val); =20 - if (dev->free_page_report_status =3D=3D FREE_PAGE_REPORT_S_REQUESTED) { - config.free_page_report_cmd_id =3D - cpu_to_le32(dev->free_page_report_cmd_id); - } else if (dev->free_page_report_status =3D=3D FREE_PAGE_REPORT_S_STOP= ) { - config.free_page_report_cmd_id =3D + if (dev->free_page_hint_status =3D=3D FREE_PAGE_HINT_S_REQUESTED) { + config.free_page_hint_cmd_id =3D + cpu_to_le32(dev->free_page_hint_cmd_id); + } else if (dev->free_page_hint_status =3D=3D FREE_PAGE_HINT_S_STOP) { + config.free_page_hint_cmd_id =3D cpu_to_le32(VIRTIO_BALLOON_CMD_ID_STOP); - } else if (dev->free_page_report_status =3D=3D FREE_PAGE_REPORT_S_DONE= ) { - config.free_page_report_cmd_id =3D + } else if (dev->free_page_hint_status =3D=3D FREE_PAGE_HINT_S_DONE) { + config.free_page_hint_cmd_id =3D cpu_to_le32(VIRTIO_BALLOON_CMD_ID_DONE); } =20 @@ -822,14 +822,14 @@ static int virtio_balloon_post_load_device(void *opaq= ue, int version_id) return 0; } =20 -static const VMStateDescription vmstate_virtio_balloon_free_page_report = =3D { +static const VMStateDescription vmstate_virtio_balloon_free_page_hint =3D { .name =3D "virtio-balloon-device/free-page-report", .version_id =3D 1, .minimum_version_id =3D 1, .needed =3D virtio_balloon_free_page_support, .fields =3D (VMStateField[]) { - VMSTATE_UINT32(free_page_report_cmd_id, VirtIOBalloon), - VMSTATE_UINT32(free_page_report_status, VirtIOBalloon), + VMSTATE_UINT32(free_page_hint_cmd_id, VirtIOBalloon), + VMSTATE_UINT32(free_page_hint_status, VirtIOBalloon), VMSTATE_END_OF_LIST() } }; @@ -856,7 +856,7 @@ static const VMStateDescription vmstate_virtio_balloon_= device =3D { VMSTATE_END_OF_LIST() }, .subsections =3D (const VMStateDescription * []) { - &vmstate_virtio_balloon_free_page_report, + &vmstate_virtio_balloon_free_page_hint, &vmstate_virtio_balloon_page_poison, NULL } @@ -895,7 +895,7 @@ static void virtio_balloon_device_realize(DeviceState *= dev, Error **errp) VIRTIO_BALLOON_F_FREE_PAGE_HINT)) { s->free_page_vq =3D virtio_add_queue(vdev, VIRTQUEUE_MAX_SIZE, virtio_balloon_handle_free_page= _vq); - precopy_add_notifier(&s->free_page_report_notify); + precopy_add_notifier(&s->free_page_hint_notify); =20 object_ref(OBJECT(s->iothread)); s->free_page_bh =3D aio_bh_new(iothread_get_aio_context(s->iothrea= d), @@ -919,7 +919,7 @@ static void virtio_balloon_device_unrealize(DeviceState= *dev) qemu_bh_delete(s->free_page_bh); object_unref(OBJECT(s->iothread)); virtio_balloon_free_page_stop(s); - precopy_remove_notifier(&s->free_page_report_notify); + precopy_remove_notifier(&s->free_page_hint_notify); } balloon_stats_destroy_timer(s); qemu_remove_balloon_handler(s); @@ -991,8 +991,8 @@ static void virtio_balloon_instance_init(Object *obj) =20 qemu_mutex_init(&s->free_page_lock); qemu_cond_init(&s->free_page_cond); - s->free_page_report_cmd_id =3D VIRTIO_BALLOON_FREE_PAGE_REPORT_CMD_ID_= MIN; - s->free_page_report_notify.notify =3D virtio_balloon_free_page_report_= notify; + s->free_page_hint_cmd_id =3D VIRTIO_BALLOON_FREE_PAGE_HINT_CMD_ID_MIN; + s->free_page_hint_notify.notify =3D virtio_balloon_free_page_hint_noti= fy; =20 object_property_add(obj, "guest-stats", "guest statistics", balloon_stats_get_all, NULL, NULL, s); diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-= balloon.h index d49fef00cef2..28fd2b396087 100644 --- a/include/hw/virtio/virtio-balloon.h +++ b/include/hw/virtio/virtio-balloon.h @@ -23,7 +23,7 @@ #define VIRTIO_BALLOON(obj) \ OBJECT_CHECK(VirtIOBalloon, (obj), TYPE_VIRTIO_BALLOON) =20 -#define VIRTIO_BALLOON_FREE_PAGE_REPORT_CMD_ID_MIN 0x80000000 +#define VIRTIO_BALLOON_FREE_PAGE_HINT_CMD_ID_MIN 0x80000000 =20 typedef struct virtio_balloon_stat VirtIOBalloonStat; =20 @@ -33,20 +33,20 @@ typedef struct virtio_balloon_stat_modern { uint64_t val; } VirtIOBalloonStatModern; =20 -enum virtio_balloon_free_page_report_status { - FREE_PAGE_REPORT_S_STOP =3D 0, - FREE_PAGE_REPORT_S_REQUESTED =3D 1, - FREE_PAGE_REPORT_S_START =3D 2, - FREE_PAGE_REPORT_S_DONE =3D 3, +enum virtio_balloon_free_page_hint_status { + FREE_PAGE_HINT_S_STOP =3D 0, + FREE_PAGE_HINT_S_REQUESTED =3D 1, + FREE_PAGE_HINT_S_START =3D 2, + FREE_PAGE_HINT_S_DONE =3D 3, }; =20 typedef struct VirtIOBalloon { VirtIODevice parent_obj; VirtQueue *ivq, *dvq, *svq, *free_page_vq, *reporting_vq; - uint32_t free_page_report_status; + uint32_t free_page_hint_status; uint32_t num_pages; uint32_t actual; - uint32_t free_page_report_cmd_id; + uint32_t free_page_hint_cmd_id; uint64_t stats[VIRTIO_BALLOON_S_NR]; VirtQueueElement *stats_vq_elem; size_t stats_vq_offset; @@ -55,7 +55,7 @@ typedef struct VirtIOBalloon { QEMUBH *free_page_bh; /* * Lock to synchronize threads to access the free page reporting relat= ed - * fields (e.g. free_page_report_status). + * fields (e.g. free_page_hint_status). */ QemuMutex free_page_lock; QemuCond free_page_cond; @@ -64,7 +64,7 @@ typedef struct VirtIOBalloon { * stopped. */ bool block_iothread; - NotifierWithReturn free_page_report_notify; + NotifierWithReturn free_page_hint_notify; int64_t stats_last_update; int64_t stats_poll_interval; uint32_t host_features;