From nobody Mon Feb 9 11:06:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594024492; cv=none; d=zohomail.com; s=zohoarc; b=JWJ3Ol4Wq7VKxwOLQSw3oZhCxeKmwpTrq9GX96XuL3csjP5wjohWWftm6XY9Ais7Wd037ieSiWk1lYKiMM9GEDNwdzCh1V3Py4eCJkTKk+6Qjd5dAc9S1yDzn3RfDNV5rDt1wLDEh7bkj/njAfXLcqkJA+UDDxbbGqo5NHhApKU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594024492; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EgAFWA7wNpNoL+bL42qXbLvUSaxv6EXpQY8ulUaL2Dc=; b=M+9j+gPD4u8+H+Na1hvIh7vaDN5xKGKNnml1PEX0LoLjoteMiKs8hOuGj8GUcc5ekqA6B919CACfbjnkhEmMa0skX0jnRSq//Zsxg4TubuaQ0Fml73qLGl5uLHrKafJkeZDSEIvUDV5kLhbSARTGdRXoHRUpOoEuAnDymAVfkTg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159402449232620.383312310398992; Mon, 6 Jul 2020 01:34:52 -0700 (PDT) Received: from localhost ([::1]:36616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsMaR-0003bp-15 for importer@patchew.org; Mon, 06 Jul 2020 04:34:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsMCz-0002nJ-Q9 for qemu-devel@nongnu.org; Mon, 06 Jul 2020 04:10:37 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:35525 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jsMCS-0003IO-Mj for qemu-devel@nongnu.org; Mon, 06 Jul 2020 04:10:37 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-NB2WXMGgOIWyhzxJecpzHw-1; Mon, 06 Jul 2020 04:10:00 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C0FC107ACCD; Mon, 6 Jul 2020 08:09:59 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18D2A73FE5; Mon, 6 Jul 2020 08:09:58 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9D35E1132F3B; Mon, 6 Jul 2020 10:09:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594023003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EgAFWA7wNpNoL+bL42qXbLvUSaxv6EXpQY8ulUaL2Dc=; b=B6J1RZTuyz+CqEC7hyoPy5RmC9JjVwVh/we9ZbwOdo82kxI5eCo3tFfYFT5WkE/UZ6fPv/ 6Q7cxmKTWs/mdW0sDzBOdTFH1QQyIerPV9+WoXHi6H18lHNlyFMlglPSCD34HWMaZOTaPz mTnWyxrpz7h+9KVj27Z0dB0dcBwaPCo= X-MC-Unique: NB2WXMGgOIWyhzxJecpzHw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v3 44/44] hmp: Ignore Error objects where the return value suffices Date: Mon, 6 Jul 2020 10:09:50 +0200 Message-Id: <20200706080950.403087-45-armbru@redhat.com> In-Reply-To: <20200706080950.403087-1-armbru@redhat.com> References: <20200706080950.403087-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/06 01:52:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, vsementsov@virtuozzo.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, groug@kaod.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" qdev_print_props() receives and throws away Error objects just to check for object_property_get_str() and object_property_print() failure. Unnecessary, both return suitable values, so use those instead. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qdev-monitor.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 96e52a9e81..31cc1f6564 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -694,22 +694,22 @@ static void qdev_print_props(Monitor *mon, DeviceStat= e *dev, Property *props, if (!props) return; for (; props->name; props++) { - Error *err =3D NULL; char *value; char *legacy_name =3D g_strdup_printf("legacy-%s", props->name); + if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) { - value =3D object_property_get_str(OBJECT(dev), legacy_name, &e= rr); + value =3D object_property_get_str(OBJECT(dev), legacy_name, NU= LL); } else { - value =3D object_property_print(OBJECT(dev), props->name, true= , &err); + value =3D object_property_print(OBJECT(dev), props->name, true, + NULL); } g_free(legacy_name); =20 - if (err) { - error_free(err); + if (!value) { continue; } qdev_printf("%s =3D %s\n", props->name, - value && *value ? value : ""); + *value ? value : ""); g_free(value); } } --=20 2.26.2