From nobody Mon Feb 9 10:29:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594024895; cv=none; d=zohomail.com; s=zohoarc; b=Qc25VC3AGrB2z7gB1Ng3uV7DxQgTydOLdPxy+TTwnKeespTPeR11VThJswbgRoLAhPvc8vLIo8r9VyiGoehs5J6ii+V95VN7KuWUCB1W7QF1qwgZBdWil794wHxRZKXs5s7XMUmb1V3irT//3NmxNd7+9hyjt+VZkzouKEabnpg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594024895; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2UkG/PCUo4x86BN+L72+dy8eEH/kExAxdxtzC/4CUIM=; b=fg/sWoRSy+3NxHGl4jqGdqlXj3z8+JNNRoAlHFZd5R46R6PpICpgVdxhuONEbZ1u49FNKwfzREBe5YTldEny9IQsoEAuM/qrTUwcW93WxPGPn/jVFuXt+kSKG25VroxglxSZxu1Seou+eN8yyPqfSwmrfa79EyryI+PdknLcObo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1594024895915118.33369474380993; Mon, 6 Jul 2020 01:41:35 -0700 (PDT) Received: from localhost ([::1]:49434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsMgw-0001US-Io for importer@patchew.org; Mon, 06 Jul 2020 04:41:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsMIC-0005II-1a for qemu-devel@nongnu.org; Mon, 06 Jul 2020 04:16:00 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:52156 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jsMI9-0004Rw-Ti for qemu-devel@nongnu.org; Mon, 06 Jul 2020 04:15:59 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-nKEeu4bBNzqQ5dotN97cLg-1; Mon, 06 Jul 2020 04:15:51 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A5121005510; Mon, 6 Jul 2020 08:15:50 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45A3B7B40E; Mon, 6 Jul 2020 08:15:50 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6888B113524E; Mon, 6 Jul 2020 10:09:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594023357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UkG/PCUo4x86BN+L72+dy8eEH/kExAxdxtzC/4CUIM=; b=O7ZHa+hxEXrnUKN5ti6jgdS3sre9p8vLqpcyxytU6fFSz1R0wLpqGqHUnGR5vwTrafXNvQ uD6vB9aBqfz6uGKnI7xh6hCor0+okR2ZKUkgBG1w/es7jGT6iO4ZBdf/pLoSkfvrExVL8m scPiEPd6zzKTZp/V9T1WIJq2mmt8OqE= X-MC-Unique: nKEeu4bBNzqQ5dotN97cLg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v3 37/44] block/parallels: Simplify parallels_open() after previous commit Date: Mon, 6 Jul 2020 10:09:43 +0200 Message-Id: <20200706080950.403087-38-armbru@redhat.com> In-Reply-To: <20200706080950.403087-1-armbru@redhat.com> References: <20200706080950.403087-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/06 01:59:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, vsementsov@virtuozzo.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, groug@kaod.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/parallels.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 180dd41e2b..cb5259ac44 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -842,6 +842,7 @@ static int parallels_open(BlockDriverState *bs, QDict *= options, int flags, &local_err); g_free(buf); if (local_err !=3D NULL) { + error_propagate(errp, local_err); goto fail_options; } =20 @@ -872,15 +873,11 @@ static int parallels_open(BlockDriverState *bs, QDict= *options, int flags, =20 fail_format: error_setg(errp, "Image not in Parallels format"); +fail_options: ret =3D -EINVAL; fail: qemu_vfree(s->header); return ret; - -fail_options: - error_propagate(errp, local_err); - ret =3D -EINVAL; - goto fail; } =20 =20 --=20 2.26.2