From nobody Mon Feb 9 16:18:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1594016535; cv=none; d=zohomail.com; s=zohoarc; b=iYBcRARiusc684/K/FirDx6hP/6h/wSJ1fG6d4RRbnt5dfzmvwf/lQtR/BonXIzoYPZ5Ow+htlVX9nN/uoLT7mnixNanab8OQ1v6Kn1cZHmnBvuRfp/7ckwGxzyAcxPGa5AMj4h7dlZ8jdQgu5g5sKnHzAhZk+1urp0f9m4swBc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594016535; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pemR7iWWdXgcnSPMqwp78SWesh4uA6RGZDBNuRa8PcI=; b=M/JGPIIiKatjZWPzPV1EiOk6a6MOLEA5ggTmeNDlypKU9TYsvDwQCwLtsH+O7gbeDWhCMcMWvFpweERTOIP3PcwFVypXMmdUhmcjxdYbcpTjkqmo9gRPGI1pDYWSi1WCbSxKJZAfI9w66NqVAjG5Sae+Ntswt/oCi+aO+4wg76c= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159401653579848.43555821653024; Sun, 5 Jul 2020 23:22:15 -0700 (PDT) Received: from localhost ([::1]:34660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsKW6-0007h7-ED for importer@patchew.org; Mon, 06 Jul 2020 02:22:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsKNx-0001t9-Jz; Mon, 06 Jul 2020 02:13:49 -0400 Received: from charlie.dont.surf ([128.199.63.193]:58140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsKNt-0000xB-OP; Mon, 06 Jul 2020 02:13:49 -0400 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id 9982EBF86A; Mon, 6 Jul 2020 06:13:18 +0000 (UTC) From: Klaus Jensen To: qemu-block@nongnu.org Subject: [PATCH v3 15/18] hw/block/nvme: reject invalid nsid values in active namespace id list Date: Mon, 6 Jul 2020 08:13:00 +0200 Message-Id: <20200706061303.246057-16-its@irrelevant.dk> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200706061303.246057-1-its@irrelevant.dk> References: <20200706061303.246057-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=128.199.63.193; envelope-from=its@irrelevant.dk; helo=charlie.dont.surf X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/06 02:13:11 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Dmitry Fomichev , Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Klaus Jensen , Keith Busch , Javier Gonzalez , Maxim Levitsky , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Klaus Jensen Reject the nsid broadcast value (0xffffffff) and 0xfffffffe in the Active Namespace ID list. Signed-off-by: Klaus Jensen Reviewed-by: Dmitry Fomichev Reviewed-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/nvme.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index fc58f3d76530..af39126cd8d1 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -992,6 +992,16 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, Nvme= Identify *c) =20 trace_pci_nvme_identify_nslist(min_nsid); =20 + /* + * Both 0xffffffff (NVME_NSID_BROADCAST) and 0xfffffffe are invalid va= lues + * since the Active Namespace ID List should return namespaces with ids + * *higher* than the NSID specified in the command. This is also speci= fied + * in the spec (NVM Express v1.3d, Section 5.15.4). + */ + if (min_nsid >=3D NVME_NSID_BROADCAST - 1) { + return NVME_INVALID_NSID | NVME_DNR; + } + list =3D g_malloc0(data_len); for (i =3D 0; i < n->num_namespaces; i++) { if (i < min_nsid) { --=20 2.27.0