[PATCH v4 00/10] hw/sd: convert legacy SDHCI devices to the SDBus API

Philippe Mathieu-Daudé posted 10 patches 3 years, 8 months ago
Test FreeBSD passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200705204630.4133-1-f4bug@amsat.org
include/hw/sd/sd.h            |  17 ------
include/hw/sd/sdcard_legacy.h |  50 +++++++++++++++
hw/arm/integratorcp.c         |  17 +++++-
hw/arm/realview.c             |  16 ++++-
hw/arm/versatilepb.c          |  28 ++++++++-
hw/arm/vexpress.c             |  15 ++++-
hw/sd/omap_mmc.c              |   2 +-
hw/sd/pl181.c                 | 111 +++++++++++++++++++---------------
hw/sd/sd.c                    |   3 +-
hw/sd/trace-events            |  10 +++
10 files changed, 193 insertions(+), 76 deletions(-)
create mode 100644 include/hw/sd/sdcard_legacy.h
[PATCH v4 00/10] hw/sd: convert legacy SDHCI devices to the SDBus API
Posted by Philippe Mathieu-Daudé 3 years, 8 months ago
Hi,

Since v3:
- rebased (was from Feb 2018)
- use named GPIOs
- addressed Peter review comment (adding TYPE_PL181_BUS object)
- convert DPRINF to trace events

Since v2:
- pl181: remove legacy sd_set_cb() (Peter)

Since v1:
- rebased on /master (Peter sdcard reset() patches)
- fix milkymist-mmc from previous seris using instance_init (Michael Walle)

This series convert 3 devices using the legacy SDCard API to the SDBus API:
- milkymist-mmc
- pl181
- ssi-sd

Then move the legacy API to a separate header "sdcard_legacy.h".

Now the OMAP MMC is the last device using the legacy API, but need to get
QOM'ified first.

Regards,

Phil.

v3: https://www.mail-archive.com/qemu-devel@nongnu.org/msg514645.html

Alistair Francis (1):
  hw/sd/pl181: Replace fprintf(stderr, "*\n") with error_report()

Philippe Mathieu-Daudé (9):
  hw/sd/pl181: Rename pl181_send_command() as pl181_do_command()
  hw/sd/pl181: Add TODO to use Fifo32 API
  hw/arm/versatilepb: Comment to remember some IRQs lines are left
    unwired
  hw/sd/pl181: Use named GPIOs
  hw/sd/pl181: Expose a SDBus and connect the SDCard to it
  hw/sd/pl181: Do not create SD card within the SDHCI controller
  hw/sd/pl181: Replace disabled fprintf()s by trace events
  hw/sd/sdcard: make sd_data_ready() static
  hw/sd: move sdcard legacy API to 'hw/sd/sdcard_legacy.h'

 include/hw/sd/sd.h            |  17 ------
 include/hw/sd/sdcard_legacy.h |  50 +++++++++++++++
 hw/arm/integratorcp.c         |  17 +++++-
 hw/arm/realview.c             |  16 ++++-
 hw/arm/versatilepb.c          |  28 ++++++++-
 hw/arm/vexpress.c             |  15 ++++-
 hw/sd/omap_mmc.c              |   2 +-
 hw/sd/pl181.c                 | 111 +++++++++++++++++++---------------
 hw/sd/sd.c                    |   3 +-
 hw/sd/trace-events            |  10 +++
 10 files changed, 193 insertions(+), 76 deletions(-)
 create mode 100644 include/hw/sd/sdcard_legacy.h

-- 
2.21.3


Re: [PATCH v4 00/10] hw/sd: convert legacy SDHCI devices to the SDBus API
Posted by Peter Maydell 3 years, 8 months ago
On Sun, 5 Jul 2020 at 21:46, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Hi,
>
> Since v3:
> - rebased (was from Feb 2018)
> - use named GPIOs
> - addressed Peter review comment (adding TYPE_PL181_BUS object)
> - convert DPRINF to trace events
>
> Since v2:
> - pl181: remove legacy sd_set_cb() (Peter)
>
> Since v1:
> - rebased on /master (Peter sdcard reset() patches)
> - fix milkymist-mmc from previous seris using instance_init (Michael Walle)
>
> This series convert 3 devices using the legacy SDCard API to the SDBus API:
> - milkymist-mmc
> - pl181
> - ssi-sd
>
> Then move the legacy API to a separate header "sdcard_legacy.h".

Hi; I had a couple of minor comments on a few patches. Alistair
has reviewed the rest. This is all for-5.2 material now, but did
you want to take it via your sd queue or should I take it via
target-arm.next ? I don't mind either way.

If you prefer the former you can have an
Acked-by: Peter Maydell <peter.maydell@linaro.org>
for the series.

thanks
-- PMM