[PULL 00/41] virtio,acpi: features, fixes, cleanups.

Michael S. Tsirkin posted 41 patches 3 years, 9 months ago
Test FreeBSD passed
Test docker-quick@centos7 passed
Test checkpatch failed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200703090252.368694-1-mst@redhat.com
Maintainers: Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Markus Armbruster <armbru@redhat.com>, Tony Krowiak <akrowiak@linux.ibm.com>, Juan Quintela <quintela@redhat.com>, Thomas Huth <thuth@redhat.com>, David Hildenbrand <david@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Hailiang Zhang <zhang.zhanghailiang@huawei.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Sergio Lopez <slp@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Eric Blake <eblake@redhat.com>, Jason Wang <jasowang@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Alex Williamson <alex.williamson@redhat.com>, Pierre Morel <pmorel@linux.ibm.com>, Richard Henderson <rth@twiddle.net>, Igor Mammedov <imammedo@redhat.com>
There is a newer version of this series
configure                                   |  21 +
qapi/misc.json                              |  64 +-
qapi/net.json                               |  28 +-
hw/virtio/virtio-mem-pci.h                  |  34 ++
include/exec/memory.h                       |  41 ++
include/hw/boards.h                         |   1 +
include/hw/pci/pci.h                        |   1 +
include/hw/vfio/vfio-common.h               |   4 +-
include/hw/virtio/vhost-backend.h           |  19 +-
include/hw/virtio/vhost-vdpa.h              |  26 +
include/hw/virtio/vhost.h                   |   7 +
include/hw/virtio/virtio-bus.h              |   4 +
include/hw/virtio/virtio-mem.h              |  86 +++
include/migration/colo.h                    |   2 +-
include/migration/misc.h                    |   2 +
include/net/net.h                           |   1 +
include/net/vhost-vdpa.h                    |  22 +
include/net/vhost_net.h                     |   5 +
include/sysemu/balloon.h                    |   2 -
net/clients.h                               |   2 +
tests/qtest/bios-tables-test-allowed-diff.h |  18 -
accel/kvm/kvm-all.c                         |   4 +-
balloon.c                                   |  17 -
exec.c                                      |  52 ++
hw/arm/virt.c                               |   2 +
hw/core/numa.c                              |  17 +-
hw/i386/microvm.c                           |   1 +
hw/i386/pc.c                                |  66 ++-
hw/i386/pc_piix.c                           |   1 +
hw/i386/pc_q35.c                            |   1 +
hw/net/vhost_net-stub.c                     |  11 +
hw/net/vhost_net.c                          |  45 +-
hw/net/virtio-net.c                         |  19 +
hw/s390x/s390-virtio-ccw.c                  |  22 +-
hw/vfio/ap.c                                |   8 +-
hw/vfio/ccw.c                               |  11 +-
hw/vfio/common.c                            |  53 +-
hw/vfio/pci.c                               |   6 +-
hw/virtio/vhost-backend.c                   |   6 +
hw/virtio/vhost-vdpa.c                      | 475 +++++++++++++++
hw/virtio/vhost.c                           |  52 +-
hw/virtio/virtio-balloon.c                  |  36 +-
hw/virtio/virtio-mem-pci.c                  | 157 +++++
hw/virtio/virtio-mem.c                      | 873 ++++++++++++++++++++++++++++
hw/virtio/virtio-pci.c                      |  13 +
hw/virtio/virtio.c                          |   6 +
migration/migration.c                       |  15 +-
migration/postcopy-ram.c                    |  23 -
migration/rdma.c                            |  18 +-
migration/savevm.c                          |  11 +-
monitor/hmp-cmds.c                          |  16 +
monitor/monitor.c                           |   1 +
net/net.c                                   |  10 +
net/vhost-vdpa.c                            | 228 ++++++++
target/i386/sev.c                           |   7 +
tests/qtest/migration-test.c                |   2 +-
MAINTAINERS                                 |  18 +
docs/interop/index.rst                      |   1 +
docs/interop/vhost-user.rst                 |  24 +
docs/interop/vhost-vdpa.rst                 |  17 +
hw/i386/Kconfig                             |   1 +
hw/virtio/Kconfig                           |  11 +
hw/virtio/Makefile.objs                     |   3 +
hw/virtio/trace-events                      |  10 +
net/Makefile.objs                           |   2 +-
qemu-options.hx                             |  12 +
tests/data/acpi/disassemle-aml.sh           |  52 ++
tests/data/acpi/rebuild-expected-aml.sh     |   1 +
68 files changed, 2640 insertions(+), 187 deletions(-)
create mode 100644 hw/virtio/virtio-mem-pci.h
create mode 100644 include/hw/virtio/vhost-vdpa.h
create mode 100644 include/hw/virtio/virtio-mem.h
create mode 100644 include/net/vhost-vdpa.h
create mode 100644 hw/virtio/vhost-vdpa.c
create mode 100644 hw/virtio/virtio-mem-pci.c
create mode 100644 hw/virtio/virtio-mem.c
create mode 100644 net/vhost-vdpa.c
create mode 100644 docs/interop/vhost-vdpa.rst
create mode 100755 tests/data/acpi/disassemle-aml.sh
[PULL 00/41] virtio,acpi: features, fixes, cleanups.
Posted by Michael S. Tsirkin 3 years, 9 months ago
The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:

  hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to 900ed7043750ae3cdf35c05da66e150a8821c3a0:

  vhost-vdpa: introduce vhost-vdpa net client (2020-07-03 04:59:13 -0400)

----------------------------------------------------------------
virtio,acpi: features, fixes, cleanups.

vdpa support
virtio-mem support
a handy script for disassembling acpi tables
misc fixes and cleanups

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Andrew Jones (1):
      tests/acpi: remove stale allowed tables

Cindy Lu (11):
      net: introduce qemu_get_peer
      vhost_net: use the function qemu_get_peer
      vhost: introduce new VhostOps vhost_dev_start
      vhost: implement vhost_dev_start method
      vhost: introduce new VhostOps vhost_vq_get_addr
      vhost: implement vhost_vq_get_addr method
      vhost: introduce new VhostOps vhost_force_iommu
      vhost: implement vhost_force_iommu method
      vhost_net: introduce set_config & get_config
      vhost-vdpa: introduce vhost-vdpa backend
      vhost-vdpa: introduce vhost-vdpa net client

David Hildenbrand (22):
      virtio-balloon: always indicate S_DONE when migration fails
      pc: Support coldplugging of virtio-pmem-pci devices on all buses
      exec: Introduce ram_block_discard_(disable|require)()
      vfio: Convert to ram_block_discard_disable()
      accel/kvm: Convert to ram_block_discard_disable()
      s390x/pv: Convert to ram_block_discard_disable()
      virtio-balloon: Rip out qemu_balloon_inhibit()
      target/i386: sev: Use ram_block_discard_disable()
      migration/rdma: Use ram_block_discard_disable()
      migration/colo: Use ram_block_discard_disable()
      virtio-mem: Paravirtualized memory hot(un)plug
      virtio-pci: Proxy for virtio-mem
      MAINTAINERS: Add myself as virtio-mem maintainer
      hmp: Handle virtio-mem when printing memory device info
      numa: Handle virtio-mem in NUMA stats
      pc: Support for virtio-mem-pci
      virtio-mem: Allow notifiers for size changes
      virtio-pci: Send qapi events when the virtio-mem size changes
      virtio-mem: Migration sanity checks
      virtio-mem: Add trace events
      virtio-mem: Exclude unplugged memory during migration
      numa: Auto-enable NUMA when any memory devices are possible

Jason Wang (3):
      virtio-bus: introduce queue_enabled method
      virtio-pci: implement queue_enabled method
      vhost: check the existence of vhost_set_iotlb_callback

Maxime Coquelin (1):
      docs: vhost-user: add Virtio status protocol feature

Michael S. Tsirkin (2):
      tests: disassemble-aml.sh: generate AML in readable format
      Revert "tests/migration: Reduce autoconverge initial bandwidth"

Peter Xu (1):
      MAINTAINERS: add VT-d entry

 configure                                   |  21 +
 qapi/misc.json                              |  64 +-
 qapi/net.json                               |  28 +-
 hw/virtio/virtio-mem-pci.h                  |  34 ++
 include/exec/memory.h                       |  41 ++
 include/hw/boards.h                         |   1 +
 include/hw/pci/pci.h                        |   1 +
 include/hw/vfio/vfio-common.h               |   4 +-
 include/hw/virtio/vhost-backend.h           |  19 +-
 include/hw/virtio/vhost-vdpa.h              |  26 +
 include/hw/virtio/vhost.h                   |   7 +
 include/hw/virtio/virtio-bus.h              |   4 +
 include/hw/virtio/virtio-mem.h              |  86 +++
 include/migration/colo.h                    |   2 +-
 include/migration/misc.h                    |   2 +
 include/net/net.h                           |   1 +
 include/net/vhost-vdpa.h                    |  22 +
 include/net/vhost_net.h                     |   5 +
 include/sysemu/balloon.h                    |   2 -
 net/clients.h                               |   2 +
 tests/qtest/bios-tables-test-allowed-diff.h |  18 -
 accel/kvm/kvm-all.c                         |   4 +-
 balloon.c                                   |  17 -
 exec.c                                      |  52 ++
 hw/arm/virt.c                               |   2 +
 hw/core/numa.c                              |  17 +-
 hw/i386/microvm.c                           |   1 +
 hw/i386/pc.c                                |  66 ++-
 hw/i386/pc_piix.c                           |   1 +
 hw/i386/pc_q35.c                            |   1 +
 hw/net/vhost_net-stub.c                     |  11 +
 hw/net/vhost_net.c                          |  45 +-
 hw/net/virtio-net.c                         |  19 +
 hw/s390x/s390-virtio-ccw.c                  |  22 +-
 hw/vfio/ap.c                                |   8 +-
 hw/vfio/ccw.c                               |  11 +-
 hw/vfio/common.c                            |  53 +-
 hw/vfio/pci.c                               |   6 +-
 hw/virtio/vhost-backend.c                   |   6 +
 hw/virtio/vhost-vdpa.c                      | 475 +++++++++++++++
 hw/virtio/vhost.c                           |  52 +-
 hw/virtio/virtio-balloon.c                  |  36 +-
 hw/virtio/virtio-mem-pci.c                  | 157 +++++
 hw/virtio/virtio-mem.c                      | 873 ++++++++++++++++++++++++++++
 hw/virtio/virtio-pci.c                      |  13 +
 hw/virtio/virtio.c                          |   6 +
 migration/migration.c                       |  15 +-
 migration/postcopy-ram.c                    |  23 -
 migration/rdma.c                            |  18 +-
 migration/savevm.c                          |  11 +-
 monitor/hmp-cmds.c                          |  16 +
 monitor/monitor.c                           |   1 +
 net/net.c                                   |  10 +
 net/vhost-vdpa.c                            | 228 ++++++++
 target/i386/sev.c                           |   7 +
 tests/qtest/migration-test.c                |   2 +-
 MAINTAINERS                                 |  18 +
 docs/interop/index.rst                      |   1 +
 docs/interop/vhost-user.rst                 |  24 +
 docs/interop/vhost-vdpa.rst                 |  17 +
 hw/i386/Kconfig                             |   1 +
 hw/virtio/Kconfig                           |  11 +
 hw/virtio/Makefile.objs                     |   3 +
 hw/virtio/trace-events                      |  10 +
 net/Makefile.objs                           |   2 +-
 qemu-options.hx                             |  12 +
 tests/data/acpi/disassemle-aml.sh           |  52 ++
 tests/data/acpi/rebuild-expected-aml.sh     |   1 +
 68 files changed, 2640 insertions(+), 187 deletions(-)
 create mode 100644 hw/virtio/virtio-mem-pci.h
 create mode 100644 include/hw/virtio/vhost-vdpa.h
 create mode 100644 include/hw/virtio/virtio-mem.h
 create mode 100644 include/net/vhost-vdpa.h
 create mode 100644 hw/virtio/vhost-vdpa.c
 create mode 100644 hw/virtio/virtio-mem-pci.c
 create mode 100644 hw/virtio/virtio-mem.c
 create mode 100644 net/vhost-vdpa.c
 create mode 100644 docs/interop/vhost-vdpa.rst
 create mode 100755 tests/data/acpi/disassemle-aml.sh


Re: [PULL 00/41] virtio,acpi: features, fixes, cleanups.
Posted by Michael S. Tsirkin 3 years, 8 months ago
On Fri, Jul 03, 2020 at 05:03:31AM -0400, Michael S. Tsirkin wrote:
> The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:
> 
>   hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> 
> for you to fetch changes up to 900ed7043750ae3cdf35c05da66e150a8821c3a0:
> 
>   vhost-vdpa: introduce vhost-vdpa net client (2020-07-03 04:59:13 -0400)

I fixed up cross-build on s390 and re-pushed the same tag:
New hash fbe08d0f39dacc996f202059a425beb13be09866
Sorry about the noise.

> ----------------------------------------------------------------
> virtio,acpi: features, fixes, cleanups.
> 
> vdpa support
> virtio-mem support
> a handy script for disassembling acpi tables
> misc fixes and cleanups
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> ----------------------------------------------------------------
> Andrew Jones (1):
>       tests/acpi: remove stale allowed tables
> 
> Cindy Lu (11):
>       net: introduce qemu_get_peer
>       vhost_net: use the function qemu_get_peer
>       vhost: introduce new VhostOps vhost_dev_start
>       vhost: implement vhost_dev_start method
>       vhost: introduce new VhostOps vhost_vq_get_addr
>       vhost: implement vhost_vq_get_addr method
>       vhost: introduce new VhostOps vhost_force_iommu
>       vhost: implement vhost_force_iommu method
>       vhost_net: introduce set_config & get_config
>       vhost-vdpa: introduce vhost-vdpa backend
>       vhost-vdpa: introduce vhost-vdpa net client
> 
> David Hildenbrand (22):
>       virtio-balloon: always indicate S_DONE when migration fails
>       pc: Support coldplugging of virtio-pmem-pci devices on all buses
>       exec: Introduce ram_block_discard_(disable|require)()
>       vfio: Convert to ram_block_discard_disable()
>       accel/kvm: Convert to ram_block_discard_disable()
>       s390x/pv: Convert to ram_block_discard_disable()
>       virtio-balloon: Rip out qemu_balloon_inhibit()
>       target/i386: sev: Use ram_block_discard_disable()
>       migration/rdma: Use ram_block_discard_disable()
>       migration/colo: Use ram_block_discard_disable()
>       virtio-mem: Paravirtualized memory hot(un)plug
>       virtio-pci: Proxy for virtio-mem
>       MAINTAINERS: Add myself as virtio-mem maintainer
>       hmp: Handle virtio-mem when printing memory device info
>       numa: Handle virtio-mem in NUMA stats
>       pc: Support for virtio-mem-pci
>       virtio-mem: Allow notifiers for size changes
>       virtio-pci: Send qapi events when the virtio-mem size changes
>       virtio-mem: Migration sanity checks
>       virtio-mem: Add trace events
>       virtio-mem: Exclude unplugged memory during migration
>       numa: Auto-enable NUMA when any memory devices are possible
> 
> Jason Wang (3):
>       virtio-bus: introduce queue_enabled method
>       virtio-pci: implement queue_enabled method
>       vhost: check the existence of vhost_set_iotlb_callback
> 
> Maxime Coquelin (1):
>       docs: vhost-user: add Virtio status protocol feature
> 
> Michael S. Tsirkin (2):
>       tests: disassemble-aml.sh: generate AML in readable format
>       Revert "tests/migration: Reduce autoconverge initial bandwidth"
> 
> Peter Xu (1):
>       MAINTAINERS: add VT-d entry
> 
>  configure                                   |  21 +
>  qapi/misc.json                              |  64 +-
>  qapi/net.json                               |  28 +-
>  hw/virtio/virtio-mem-pci.h                  |  34 ++
>  include/exec/memory.h                       |  41 ++
>  include/hw/boards.h                         |   1 +
>  include/hw/pci/pci.h                        |   1 +
>  include/hw/vfio/vfio-common.h               |   4 +-
>  include/hw/virtio/vhost-backend.h           |  19 +-
>  include/hw/virtio/vhost-vdpa.h              |  26 +
>  include/hw/virtio/vhost.h                   |   7 +
>  include/hw/virtio/virtio-bus.h              |   4 +
>  include/hw/virtio/virtio-mem.h              |  86 +++
>  include/migration/colo.h                    |   2 +-
>  include/migration/misc.h                    |   2 +
>  include/net/net.h                           |   1 +
>  include/net/vhost-vdpa.h                    |  22 +
>  include/net/vhost_net.h                     |   5 +
>  include/sysemu/balloon.h                    |   2 -
>  net/clients.h                               |   2 +
>  tests/qtest/bios-tables-test-allowed-diff.h |  18 -
>  accel/kvm/kvm-all.c                         |   4 +-
>  balloon.c                                   |  17 -
>  exec.c                                      |  52 ++
>  hw/arm/virt.c                               |   2 +
>  hw/core/numa.c                              |  17 +-
>  hw/i386/microvm.c                           |   1 +
>  hw/i386/pc.c                                |  66 ++-
>  hw/i386/pc_piix.c                           |   1 +
>  hw/i386/pc_q35.c                            |   1 +
>  hw/net/vhost_net-stub.c                     |  11 +
>  hw/net/vhost_net.c                          |  45 +-
>  hw/net/virtio-net.c                         |  19 +
>  hw/s390x/s390-virtio-ccw.c                  |  22 +-
>  hw/vfio/ap.c                                |   8 +-
>  hw/vfio/ccw.c                               |  11 +-
>  hw/vfio/common.c                            |  53 +-
>  hw/vfio/pci.c                               |   6 +-
>  hw/virtio/vhost-backend.c                   |   6 +
>  hw/virtio/vhost-vdpa.c                      | 475 +++++++++++++++
>  hw/virtio/vhost.c                           |  52 +-
>  hw/virtio/virtio-balloon.c                  |  36 +-
>  hw/virtio/virtio-mem-pci.c                  | 157 +++++
>  hw/virtio/virtio-mem.c                      | 873 ++++++++++++++++++++++++++++
>  hw/virtio/virtio-pci.c                      |  13 +
>  hw/virtio/virtio.c                          |   6 +
>  migration/migration.c                       |  15 +-
>  migration/postcopy-ram.c                    |  23 -
>  migration/rdma.c                            |  18 +-
>  migration/savevm.c                          |  11 +-
>  monitor/hmp-cmds.c                          |  16 +
>  monitor/monitor.c                           |   1 +
>  net/net.c                                   |  10 +
>  net/vhost-vdpa.c                            | 228 ++++++++
>  target/i386/sev.c                           |   7 +
>  tests/qtest/migration-test.c                |   2 +-
>  MAINTAINERS                                 |  18 +
>  docs/interop/index.rst                      |   1 +
>  docs/interop/vhost-user.rst                 |  24 +
>  docs/interop/vhost-vdpa.rst                 |  17 +
>  hw/i386/Kconfig                             |   1 +
>  hw/virtio/Kconfig                           |  11 +
>  hw/virtio/Makefile.objs                     |   3 +
>  hw/virtio/trace-events                      |  10 +
>  net/Makefile.objs                           |   2 +-
>  qemu-options.hx                             |  12 +
>  tests/data/acpi/disassemle-aml.sh           |  52 ++
>  tests/data/acpi/rebuild-expected-aml.sh     |   1 +
>  68 files changed, 2640 insertions(+), 187 deletions(-)
>  create mode 100644 hw/virtio/virtio-mem-pci.h
>  create mode 100644 include/hw/virtio/vhost-vdpa.h
>  create mode 100644 include/hw/virtio/virtio-mem.h
>  create mode 100644 include/net/vhost-vdpa.h
>  create mode 100644 hw/virtio/vhost-vdpa.c
>  create mode 100644 hw/virtio/virtio-mem-pci.c
>  create mode 100644 hw/virtio/virtio-mem.c
>  create mode 100644 net/vhost-vdpa.c
>  create mode 100644 docs/interop/vhost-vdpa.rst
>  create mode 100755 tests/data/acpi/disassemle-aml.sh
> 


Re: [PULL 00/41] virtio,acpi: features, fixes, cleanups.
Posted by Peter Maydell 3 years, 8 months ago
On Fri, 3 Jul 2020 at 10:03, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:
>
>   hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 900ed7043750ae3cdf35c05da66e150a8821c3a0:
>
>   vhost-vdpa: introduce vhost-vdpa net client (2020-07-03 04:59:13 -0400)
>
> ----------------------------------------------------------------
> virtio,acpi: features, fixes, cleanups.
>
> vdpa support
> virtio-mem support
> a handy script for disassembling acpi tables
> misc fixes and cleanups
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>

Hi; this fails to build on OSX and the BSDs:

In file included from /home/qemu/qemu-test.TcQYno/src/hw/net/vhost_net.c:23:
/home/qemu/qemu-test.TcQYno/src/linux-headers/linux/vhost.h:14:10:
fatal error: 'linux/vhost_types.h' file not found
#include <linux/vhost_types.h>
         ^~~~~~~~~~~~~~~~~~~~~
1 error generated.

thanks
-- PMM

Re: [PULL 00/41] virtio,acpi: features, fixes, cleanups.
Posted by Michael S. Tsirkin 3 years, 8 months ago
On Sat, Jul 04, 2020 at 03:05:19PM +0100, Peter Maydell wrote:
> On Fri, 3 Jul 2020 at 10:03, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:
> >
> >   hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 900ed7043750ae3cdf35c05da66e150a8821c3a0:
> >
> >   vhost-vdpa: introduce vhost-vdpa net client (2020-07-03 04:59:13 -0400)
> >
> > ----------------------------------------------------------------
> > virtio,acpi: features, fixes, cleanups.
> >
> > vdpa support
> > virtio-mem support
> > a handy script for disassembling acpi tables
> > misc fixes and cleanups
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> 
> Hi; this fails to build on OSX and the BSDs:
> 
> In file included from /home/qemu/qemu-test.TcQYno/src/hw/net/vhost_net.c:23:
> /home/qemu/qemu-test.TcQYno/src/linux-headers/linux/vhost.h:14:10:
> fatal error: 'linux/vhost_types.h' file not found
> #include <linux/vhost_types.h>
>          ^~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> 
> thanks
> -- PMM

My bad.  Send v2 fixing that. Thanks!

-- 
MST


Re: [PULL 00/41] virtio,acpi: features, fixes, cleanups.
Posted by no-reply@patchew.org 3 years, 9 months ago
Patchew URL: https://patchew.org/QEMU/20200703090252.368694-1-mst@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/41] virtio,acpi: features, fixes, cleanups.
Type: series
Message-id: 20200703090252.368694-1-mst@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200703090252.368694-1-mst@redhat.com -> patchew/20200703090252.368694-1-mst@redhat.com
Switched to a new branch 'test'
d326f4c vhost-vdpa: introduce vhost-vdpa net client
5b79506 vhost-vdpa: introduce vhost-vdpa backend
34e3d32 vhost_net: introduce set_config & get_config
45e1755 vhost: implement vhost_force_iommu method
521dda5 vhost: introduce new VhostOps vhost_force_iommu
cde3f4d vhost: implement vhost_vq_get_addr method
9ca7777 vhost: introduce new VhostOps vhost_vq_get_addr
46365ef vhost: implement vhost_dev_start method
258ef40 vhost: introduce new VhostOps vhost_dev_start
595fee8 vhost: check the existence of vhost_set_iotlb_callback
6d31611 virtio-pci: implement queue_enabled method
9d7cc7e virtio-bus: introduce queue_enabled method
63e1852 vhost_net: use the function qemu_get_peer
c14a63b0 net: introduce qemu_get_peer
ae02598 MAINTAINERS: add VT-d entry
e3da26d docs: vhost-user: add Virtio status protocol feature
11e69be tests/acpi: remove stale allowed tables
5495dd2 numa: Auto-enable NUMA when any memory devices are possible
03bbf1c virtio-mem: Exclude unplugged memory during migration
d06c835 virtio-mem: Add trace events
8e27aef virtio-mem: Migration sanity checks
c96ea1a virtio-pci: Send qapi events when the virtio-mem size changes
b36b37d virtio-mem: Allow notifiers for size changes
da08f51 pc: Support for virtio-mem-pci
118ff96 numa: Handle virtio-mem in NUMA stats
1bbdf6d hmp: Handle virtio-mem when printing memory device info
8e46b61 MAINTAINERS: Add myself as virtio-mem maintainer
2b74d63 virtio-pci: Proxy for virtio-mem
961edc2 virtio-mem: Paravirtualized memory hot(un)plug
4f15a29 migration/colo: Use ram_block_discard_disable()
bedd15d migration/rdma: Use ram_block_discard_disable()
170b21f target/i386: sev: Use ram_block_discard_disable()
04b1297 virtio-balloon: Rip out qemu_balloon_inhibit()
016195a s390x/pv: Convert to ram_block_discard_disable()
117712d accel/kvm: Convert to ram_block_discard_disable()
7a7ff33 vfio: Convert to ram_block_discard_disable()
e41bedd exec: Introduce ram_block_discard_(disable|require)()
7bf2f8b pc: Support coldplugging of virtio-pmem-pci devices on all buses
abff164 virtio-balloon: always indicate S_DONE when migration fails
cbb5a2c Revert "tests/migration: Reduce autoconverge initial bandwidth"
2f9d6c5 tests: disassemble-aml.sh: generate AML in readable format

=== OUTPUT BEGIN ===
1/41 Checking commit 2f9d6c5c8d4f (tests: disassemble-aml.sh: generate AML in readable format)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100755

WARNING: line over 80 characters
#30: FILE: tests/data/acpi/disassemle-aml.sh:10:
+        echo "Usage: ./tests/data/acpi/disassemle-aml.sh [-o <output-directory>]"

ERROR: line over 90 characters
#81: FILE: tests/data/acpi/rebuild-expected-aml.sh:39:
+echo "You can use ${SRC_PATH}/tests/data/acpi/disassemle-aml.sh to disassemble them to ASL."

total: 1 errors, 2 warnings, 59 lines checked

Patch 1/41 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/41 Checking commit cbb5a2c19835 (Revert "tests/migration: Reduce autoconverge initial bandwidth")
3/41 Checking commit abff1647fa36 (virtio-balloon: always indicate S_DONE when migration fails)
4/41 Checking commit 7bf2f8bc2dbe (pc: Support coldplugging of virtio-pmem-pci devices on all buses)
5/41 Checking commit e41bedd7874b (exec: Introduce ram_block_discard_(disable|require)())
6/41 Checking commit 7a7ff3317cec (vfio: Convert to ram_block_discard_disable())
7/41 Checking commit 117712d3f611 (accel/kvm: Convert to ram_block_discard_disable())
8/41 Checking commit 016195ab9045 (s390x/pv: Convert to ram_block_discard_disable())
9/41 Checking commit 04b12978b0c8 (virtio-balloon: Rip out qemu_balloon_inhibit())
10/41 Checking commit 170b21f22848 (target/i386: sev: Use ram_block_discard_disable())
11/41 Checking commit bedd15d37028 (migration/rdma: Use ram_block_discard_disable())
12/41 Checking commit 4f15a2930cd4 (migration/colo: Use ram_block_discard_disable())
13/41 Checking commit 961edc25d06d (virtio-mem: Paravirtualized memory hot(un)plug)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#150: 
new file mode 100644

WARNING: architecture specific defines should be avoided
#207: FILE: hw/virtio/virtio-mem.c:53:
+#if defined(__x86_64__)

total: 0 errors, 2 warnings, 879 lines checked

Patch 13/41 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/41 Checking commit 2b74d630ee23 (virtio-pci: Proxy for virtio-mem)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 176 lines checked

Patch 14/41 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/41 Checking commit 8e46b61efe75 (MAINTAINERS: Add myself as virtio-mem maintainer)
16/41 Checking commit 1bbdf6d8b6e7 (hmp: Handle virtio-mem when printing memory device info)
17/41 Checking commit 118ff96bc1c9 (numa: Handle virtio-mem in NUMA stats)
18/41 Checking commit da08f51266d7 (pc: Support for virtio-mem-pci)
19/41 Checking commit b36b37d7a07c (virtio-mem: Allow notifiers for size changes)
20/41 Checking commit c96ea1a4ece5 (virtio-pci: Send qapi events when the virtio-mem size changes)
21/41 Checking commit 8e27aef95749 (virtio-mem: Migration sanity checks)
22/41 Checking commit d06c835b4a5a (virtio-mem: Add trace events)
23/41 Checking commit 03bbf1c0428e (virtio-mem: Exclude unplugged memory during migration)
24/41 Checking commit 5495dd24c59f (numa: Auto-enable NUMA when any memory devices are possible)
25/41 Checking commit 11e69befe833 (tests/acpi: remove stale allowed tables)
26/41 Checking commit e3da26d54bf9 (docs: vhost-user: add Virtio status protocol feature)
27/41 Checking commit ae02598cd75f (MAINTAINERS: add VT-d entry)
28/41 Checking commit c14a63b00d64 (net: introduce qemu_get_peer)
29/41 Checking commit 63e185264f1c (vhost_net: use the function qemu_get_peer)
30/41 Checking commit 9d7cc7eabb9a (virtio-bus: introduce queue_enabled method)
31/41 Checking commit 6d31611fcbde (virtio-pci: implement queue_enabled method)
32/41 Checking commit 595fee8ac10c (vhost: check the existence of vhost_set_iotlb_callback)
33/41 Checking commit 258ef40cf760 (vhost: introduce new VhostOps vhost_dev_start)
34/41 Checking commit 46365ef774f6 (vhost: implement vhost_dev_start method)
35/41 Checking commit 9ca7777858bc (vhost: introduce new VhostOps vhost_vq_get_addr)
36/41 Checking commit cde3f4d30a57 (vhost: implement vhost_vq_get_addr method)
37/41 Checking commit 521dda5d542b (vhost: introduce new VhostOps vhost_force_iommu)
38/41 Checking commit 45e17553394c (vhost: implement vhost_force_iommu method)
39/41 Checking commit 34e3d323afa4 (vhost_net: introduce set_config & get_config)
40/41 Checking commit 5b795066e101 (vhost-vdpa: introduce vhost-vdpa backend)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#114: 
new file mode 100644

total: 0 errors, 1 warnings, 751 lines checked

Patch 40/41 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
41/41 Checking commit d326f4ca985f (vhost-vdpa: introduce vhost-vdpa net client)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 321 lines checked

Patch 41/41 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200703090252.368694-1-mst@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com