From nobody Mon Feb 9 17:37:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593706026; cv=none; d=zohomail.com; s=zohoarc; b=BXz47rr91ughtQW0nFEXDLHRKdQeAgRYko4VePK1iyMdAeG3BQWVx44pn5KKA+sCzftowTPgrveIdIFcKncm2aNGhLaXOHFMTL3b0kagog2ps5ukj/1sQBr5qW/rTPvPcitIT4vCt+B9kOfMigkMlq7V+Qd1J1CA8MXBKlDIh6s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593706026; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yt4kCoA1uRlrRy7PB3/zaYEiAODL/eRXasD+w/cK+gg=; b=HuccolbvloF4S3BWVDnXxIkwLoxvaoU2X7E1ykIG0GCKYA12FSGxo3zJl68naNajsozWxlTkj/Lcy/E1YYc+C6Zx9lWWomyPGyxEVegooqwK+YftrPE1Fqke0F/cveBSGIK6Ox3FjtQnrhg3u7DbGxmRNXhtQQQmI/dRHaSgwH0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159370602678143.03023962772181; Thu, 2 Jul 2020 09:07:06 -0700 (PDT) Received: from localhost ([::1]:34342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jr1jt-0003GF-JR for importer@patchew.org; Thu, 02 Jul 2020 12:07:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jr1Tz-0000ct-Vt for qemu-devel@nongnu.org; Thu, 02 Jul 2020 11:50:40 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:30267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jr1Tf-0004sw-NP for qemu-devel@nongnu.org; Thu, 02 Jul 2020 11:50:39 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-alwSvAoDO4O4M0EshWUVKg-1; Thu, 02 Jul 2020 11:50:10 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42BBE18FE864; Thu, 2 Jul 2020 15:50:09 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FB507167A; Thu, 2 Jul 2020 15:50:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4867E1132FDD; Thu, 2 Jul 2020 17:50:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593705012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yt4kCoA1uRlrRy7PB3/zaYEiAODL/eRXasD+w/cK+gg=; b=N5n8Qi4eeRfWFox+GOr1TpHuOqCDX0m0F6YvxWhYiEjBcHJ+ladBX3ZtfqQyRb3vqirate 41uPFUb6mETzA3lF5zw2QfOdYiUzfCzRTs4lAXAHtH1CSV55Gh7CAy2H0z/+rn0C21WoeD YT6nzcZhCOmO6NkSrRw66LchL1X4Hz0= X-MC-Unique: alwSvAoDO4O4M0EshWUVKg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v2 43/44] qdev: Ignore Error objects where the return value suffices Date: Thu, 2 Jul 2020 17:49:59 +0200 Message-Id: <20200702155000.3455325-44-armbru@redhat.com> In-Reply-To: <20200702155000.3455325-1-armbru@redhat.com> References: <20200702155000.3455325-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/02 04:18:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, vsementsov@virtuozzo.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- hw/core/qdev-properties.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index e1ad147339..8eb4283a56 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -653,7 +653,6 @@ static void set_pci_devfn(Object *obj, Visitor *v, cons= t char *name, Property *prop =3D opaque; int32_t value, *ptr =3D qdev_get_prop_ptr(dev, prop); unsigned int slot, fn, n; - Error *local_err =3D NULL; char *str; =20 if (dev->realized) { @@ -661,9 +660,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, cons= t char *name, return; } =20 - if (!visit_type_str(v, name, &str, &local_err)) { - error_free(local_err); - local_err =3D NULL; + if (!visit_type_str(v, name, &str, NULL)) { if (!visit_type_int32(v, name, &value, errp)) { return; } --=20 2.26.2