From nobody Mon Feb 9 14:38:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593616117; cv=none; d=zohomail.com; s=zohoarc; b=QvB3RkzadNDbZiEZmjNEtqeUe/jk5EUrOZ0Dk1xlFyhybUOf8LTVGruLmxYOC2tNizsIT5XafNDAYXnRO8C/YDjXQI9SoDMexh2r3h1iBRWyF9LJ5oEbbqRk0TyZ9eL+1q6AVVgvCOg4wzD6Z28p+XH5Y/jc3jAx/1IwBoojtuY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593616117; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=o8Cqh+HphbjUac1JtCJY2sQJPe5CO2XSD8Gqj9m0lnM=; b=QEseF7ui4EGMDsLNatI8RUwmm3XVbnFw05vynCZ+kJlQ7Sqw+1RV+8QYhCjopChcZLWQJkzw03Tz1yMce4pkoJif4I5xjGZtqtLp95kyeTz7vj/tqqcFEfdN101MYpG1pr3BNr0grRFg3Ztq4S1Z/Ydj4jF67unCV+IH6V33gAk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593616117446610.4796900192506; Wed, 1 Jul 2020 08:08:37 -0700 (PDT) Received: from localhost ([::1]:57744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqeLk-0000CV-3D for importer@patchew.org; Wed, 01 Jul 2020 11:08:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqeHt-0003Df-4U for qemu-devel@nongnu.org; Wed, 01 Jul 2020 11:04:37 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:54432 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jqeHq-0001AX-SQ for qemu-devel@nongnu.org; Wed, 01 Jul 2020 11:04:36 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-NEJGlMDpPTuTf8ONoHnk_w-1; Wed, 01 Jul 2020 11:04:32 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 09E2C107B768; Wed, 1 Jul 2020 15:04:31 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-62.ams2.redhat.com [10.36.112.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id A836E5C1B0; Wed, 1 Jul 2020 15:04:30 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7E90131E3F; Wed, 1 Jul 2020 17:04:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593615874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o8Cqh+HphbjUac1JtCJY2sQJPe5CO2XSD8Gqj9m0lnM=; b=dLUbWaAwHv7HK/N+Z7rjyqnbmuzN5giOrDF3AX+YyNCkBvUc81vbpwJg79J/TiwjKOM+SJ oyhlhQuTOurG0ornS49CKvZxktSO66UqtIg7EL11R9uAcSQ5JUOENRZItWdqcHQb+4rnq0 9c1Sy0IzSh5HpHzd3CsYnFn7FlVELBU= X-MC-Unique: NEJGlMDpPTuTf8ONoHnk_w-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 06/13] sm501: Use stn_he_p/ldn_he_p instead of switch/case Date: Wed, 1 Jul 2020 17:04:18 +0200 Message-Id: <20200701150425.13739-7-kraxel@redhat.com> In-Reply-To: <20200701150425.13739-1-kraxel@redhat.com> References: <20200701150425.13739-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/01 01:29:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: BALATON Zoltan Instead of open coding op with different sizes using a switch and type casting it can be written more compactly using stn_he_p/ldn_he_p. Suggested-by: Peter Maydell Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: e2f649cb286f0735a10ec87c1b36a7ae081acb61.1592686588.git.balaton= @eik.bme.hu Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 2098e6981014..6349f31e6491 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -766,17 +766,7 @@ static void sm501_2d_operation(SM501State *s) for (y =3D 0; y < height; y++) { i =3D (dst_x + (dst_y + y) * dst_pitch) * bypp; for (x =3D 0; x < width; x++, i +=3D bypp) { - switch (format) { - case 0: - d[i] =3D ~d[i]; - break; - case 1: - *(uint16_t *)&d[i] =3D ~*(uint16_t *)&d[i]; - break; - case 2: - *(uint32_t *)&d[i] =3D ~*(uint32_t *)&d[i]; - break; - } + stn_he_p(&d[i], bypp, ~ldn_he_p(&d[i], bypp)); } } } else { --=20 2.18.4