From nobody Mon Oct 6 18:09:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593520582; cv=none; d=zohomail.com; s=zohoarc; b=cXDEZHBtY5BvVikW8fcB8MqX5jzrFkINztw+Vqe0v0lZom8gAAaZmLnZ5X41YemWDNsXd8Np7STB7zE+f4MTpHq078x3LWuMisSywgDyyDrbIgcdmGKvmpKU/4fom4R1TtfPK4h6LPYAF6OKP+zmj8iRsb2YBfg8v3GJ5CDyJUY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593520582; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ov1jLUdvXIGnRIWFa0ql9vtSUGoOJxabVDi0h7uTGDE=; b=PePQoGDjWDIkCZPARyAI4SjgRNd15k+Xu6vKmkK+hEIXKCLtVr4CfUfhqT42j2DFCm6BG3wKN8wtFqnECaX4dvXC2ow9vsdUmXK2H43eMLM85S9cHCxuKbTFfROk2zqwEWWST4mpAwKyvnOjEhVC50BekcbXwyftXKW0Clb2EJk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593520582267215.81851792279133; Tue, 30 Jun 2020 05:36:22 -0700 (PDT) Received: from localhost ([::1]:59242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqFUq-0003A4-Rf for importer@patchew.org; Tue, 30 Jun 2020 08:36:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqFQ4-0005Gn-Pb for qemu-devel@nongnu.org; Tue, 30 Jun 2020 08:31:25 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:20845 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jqFQ2-0003kU-MU for qemu-devel@nongnu.org; Tue, 30 Jun 2020 08:31:24 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-cy1kuH-HPFiQwy5xg28kBA-1; Tue, 30 Jun 2020 08:31:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C7A9D19324B2; Tue, 30 Jun 2020 12:31:10 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.192.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 007925C1C5; Tue, 30 Jun 2020 12:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593520282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ov1jLUdvXIGnRIWFa0ql9vtSUGoOJxabVDi0h7uTGDE=; b=PZ1gnrb6FC5EU2VLUQyewaatdBf+pgZ6LcQ1QyoiChonf8kyMmXBNCvbDUM/DL2yp/N/n8 s3qN3SBxA0UaT7ookugBUkdATE4WlLTrS6kvD2MLxhmuPeKTldGR0fcP4XGh7YFyuVEXbx DmSJEvkLnb/1u/nWJJt+xvNYYLE7VjU= X-MC-Unique: cy1kuH-HPFiQwy5xg28kBA-1 From: P J P To: Paolo Bonzini Subject: [PATCH v3 9/9] memory: assert MemoryRegionOps callbacks are defined Date: Tue, 30 Jun 2020 17:57:10 +0530 Message-Id: <20200630122710.1119158-10-ppandit@redhat.com> In-Reply-To: <20200630122710.1119158-1-ppandit@redhat.com> References: <20200630122710.1119158-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ppandit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=ppandit@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/30 01:11:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Prasad J Pandit , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Qiang , QEMU Developers , Lei Sun , Alex Williamson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit When registering a MemoryRegionOps object, assert that its read/write callback methods are defined. This avoids potential guest crash via a NULL pointer dereference. Suggested-by: Peter Maydell Reviewed-by: Li Qiang Signed-off-by: Prasad J Pandit Reviewed-by: Peter Maydell --- memory.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) Update v3: Add Reviewed-by: ... -> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg09467.html diff --git a/memory.c b/memory.c index 9200b20130..5e22bce326 100644 --- a/memory.c +++ b/memory.c @@ -1485,7 +1485,13 @@ void memory_region_init_io(MemoryRegion *mr, uint64_t size) { memory_region_init(mr, owner, name, size); - mr->ops =3D ops ? ops : &unassigned_mem_ops; + if (ops) { + assert(ops->read || ops->read_with_attrs); + assert(ops->write || ops->write_with_attrs); + mr->ops =3D ops; + } else { + mr->ops =3D &unassigned_mem_ops; + } mr->opaque =3D opaque; mr->terminates =3D true; } @@ -1663,6 +1669,8 @@ void memory_region_init_rom_device_nomigrate(MemoryRe= gion *mr, { Error *err =3D NULL; assert(ops); + assert(ops->read || ops->read_with_attrs); + assert(ops->write || ops->write_with_attrs); memory_region_init(mr, owner, name, size); mr->ops =3D ops; mr->opaque =3D opaque; --=20 2.26.2