From nobody Fri Apr 26 08:40:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1593490856; cv=none; d=zohomail.com; s=zohoarc; b=YVhjNjy/jdSlpLjYIds5IB658FmGO0oX+Prrb1Yu5H/Mso07LQzMZgxvMaPGjeqUKBVHigDjTUt5T13bSMXmyVRhwld1tu2sJ1DQyb9gICepZX447AfPv+hL7LXA+GZNMS03rohhgIdu2dwR5ReHQoOk+LjU1rMp/boxcH5yEPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593490856; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=s7FEbCglz7G1DaegVScOpMWVQshCT+0WJ4MSvUGMfKo=; b=CAvWeBIHbEiv+jK625NbYQrLjPOI0jWAQn3sBhzMU0Qw1XYWaFwX/AxgE/Am89DlB8a6VtxhE5agAzgh5Nad8SmzdW1kIkpg56D+QauWi6Uk0vDRg8ct487c/4h1aK64bHWIAo/qyHeS9BsRiekr3gJxPAt7qrxUlOscart5dV0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593490856512244.4489756855728; Mon, 29 Jun 2020 21:20:56 -0700 (PDT) Received: from localhost ([::1]:57434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jq7lP-0002yc-96 for importer@patchew.org; Tue, 30 Jun 2020 00:20:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jq7ki-0002PS-LW; Tue, 30 Jun 2020 00:20:12 -0400 Received: from charlie.dont.surf ([128.199.63.193]:47024) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jq7kg-0002fK-NG; Tue, 30 Jun 2020 00:20:12 -0400 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id C308EBF670; Tue, 30 Jun 2020 04:20:08 +0000 (UTC) From: Klaus Jensen To: qemu-block@nongnu.org Subject: [PATCH] hw/block/nvme: make lba data size configurable Date: Tue, 30 Jun 2020 06:19:56 +0200 Message-Id: <20200630041956.1304473-1-its@irrelevant.dk> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=128.199.63.193; envelope-from=its@irrelevant.dk; helo=charlie.dont.surf X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/30 00:09:10 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Klaus Jensen , Keith Busch , Maxim Levitsky , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Klaus Jensen Allos the LBA data size (lbads) to be set between 9 and 12. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Based-on: <20200629214051.1282060-1-its@irrelevant.dk> ("[PATCH v2 0/4] hw/block/nvme: support multiple namespaces") hw/block/nvme-ns.c | 8 +++++++- hw/block/nvme-ns.h | 1 + hw/block/nvme.c | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c index 28ce5e011568..d6ec55860a5e 100644 --- a/hw/block/nvme-ns.c +++ b/hw/block/nvme-ns.c @@ -32,7 +32,7 @@ static void nvme_ns_init(NvmeNamespace *ns) { NvmeIdNs *id_ns =3D &ns->id_ns; =20 - id_ns->lbaf[0].ds =3D BDRV_SECTOR_BITS; + id_ns->lbaf[0].ds =3D ns->params.lbads; =20 id_ns->nsze =3D cpu_to_le64(nvme_ns_nlbas(ns)); =20 @@ -92,6 +92,11 @@ static int nvme_ns_check_constraints(NvmeNamespace *ns, = Error **errp) return -1; } =20 + if (ns->params.lbads < 9 || ns->params.lbads > 12) { + error_setg(errp, "unsupported lbads (supported: 9-12)"); + return -1; + } + return 0; } =20 @@ -130,6 +135,7 @@ static void nvme_ns_realize(DeviceState *dev, Error **e= rrp) static Property nvme_ns_props[] =3D { DEFINE_PROP_DRIVE("drive", NvmeNamespace, blk), DEFINE_PROP_UINT32("nsid", NvmeNamespace, params.nsid, 0), + DEFINE_PROP_UINT8("lbads", NvmeNamespace, params.lbads, BDRV_SECTOR_BI= TS), DEFINE_PROP_END_OF_LIST(), }; =20 diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h index 16fa8b1e3fb9..bee46b32efa5 100644 --- a/hw/block/nvme-ns.h +++ b/hw/block/nvme-ns.h @@ -21,6 +21,7 @@ =20 typedef struct NvmeNamespaceParams { uint32_t nsid; + uint8_t lbads; } NvmeNamespaceParams; =20 typedef struct NvmeNamespace { diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 164c5e294d06..9e512c88656d 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -2877,6 +2877,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **= errp) if (n->namespace.blk) { ns =3D &n->namespace; ns->params.nsid =3D 1; + ns->params.lbads =3D BDRV_SECTOR_BITS; =20 if (nvme_ns_setup(n, ns, errp)) { return; --=20 2.27.0