From nobody Mon Apr 29 00:32:53 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1593327068; cv=none; d=zohomail.com; s=zohoarc; b=E53KskxRJc2gBsVFGvrH7GNl9BAp3tp4bf583WEn883FOPlBbK9QC9LX7iSwHvrBD0jaGerbhM1LZ5M0c4pjo4+fAsp3JMwIHwpGVILTb4L+WhRkb2Dzya93jdA7maZ+XOFG/yUJhn6pOLMqSfPbc3fJNbfskBlQnPKau86OD5k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593327068; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/HlRsjVf7T2AQ13Zj1+IwCHgaASqBjKPrEIy/qJXwRg=; b=Ca4CVwPxuLC2kq+D/0o8UGFfKr1Fe0GFa1FX9sdSRfInj7ME0V26arwHRvw8wovJKdvkwKrXyTqXs+Ngw4kN/duvGcA13DGrVQRVc79chm1capgIB5qIIvVG2QojOwhTDJolVJ8LrxWebwfLCN6yLoLVy9z5E8RudqZfJMdwBpM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593327068758986.5345942219085; Sat, 27 Jun 2020 23:51:08 -0700 (PDT) Received: from localhost ([::1]:57348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpR9e-0007Zw-Fv for importer@patchew.org; Sun, 28 Jun 2020 02:51:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpR8a-0006w4-PB; Sun, 28 Jun 2020 02:50:00 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3715 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpR8Y-0000oX-KP; Sun, 28 Jun 2020 02:50:00 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 235214851E26FC420DB6; Sun, 28 Jun 2020 14:49:43 +0800 (CST) Received: from DESKTOP-5IS4806.china.huawei.com (10.174.187.22) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Sun, 28 Jun 2020 14:49:33 +0800 From: Keqian Zhu To: , Subject: [PATCH] migration: Assign current_migration as NULL after migration Date: Sun, 28 Jun 2020 14:49:23 +0800 Message-ID: <20200628064923.13192-1-zhukeqian1@huawei.com> X-Mailer: git-send-email 2.8.4.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.187.22] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhukeqian1@huawei.com; helo=huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/28 02:49:45 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wanghaibin.wang@huawei.com, Keqian Zhu , "Dr . David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In migration_shutdown, global var current_migration is freed but not assigned to NULL, which may cause heap-use-after-free problem if the following code logic is abnormal. Signed-off-by: Keqian Zhu --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration.c b/migration/migration.c index 481a590f72..effffd7332 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -189,6 +189,7 @@ void migration_shutdown(void) */ migrate_fd_cancel(current_migration); object_unref(OBJECT(current_migration)); + current_migration =3D NULL; } =20 /* For outgoing */ --=20 2.19.1