From nobody Tue May 7 10:41:25 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593112695; cv=none; d=zohomail.com; s=zohoarc; b=mPLoWbz2qfRLgFDNGI/L0hpxm6oT/gpfMBVk1ihNtJwdYzk9u8SFMkGEZHWzUZY96FJ3oTNkGmCdovWByBQ4xTlrG2f/1EK21yjfPrg8FthxFNbLxgsiLU9o3tcdqJ3eB4nWm6RLQhYbqidhbBct8imB+K0lvR/lLumPinxTQUo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593112695; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=l5Sqnb1Joi1fqGAHa0mURL2LJiuQDUWCxBOE3t4IBnQ=; b=dxr7Qh0Se2daCUzjs8lBOHxccheJvEItsL8g7h9R8vuQuXQUBkcNpT/3+LxKhh0FYfufR9rJRNAt/Ex+x0NPJZoXLRbEV99B3dQf5avoI9xVFyqISjy8rix3Iu5qZt6aedpd00s/gQTKEh2nuRPSfMyJNGwCHmoDCHoKUYORX3M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593112695863176.0016185456068; Thu, 25 Jun 2020 12:18:15 -0700 (PDT) Received: from localhost ([::1]:58760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joXO2-00085a-NM for importer@patchew.org; Thu, 25 Jun 2020 15:18:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joXN5-0007Cl-2j for qemu-devel@nongnu.org; Thu, 25 Jun 2020 15:17:15 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:28442 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joXN3-0003ew-0e for qemu-devel@nongnu.org; Thu, 25 Jun 2020 15:17:14 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-250-s1Z_mXMXOX2Y5oSVvunFrg-1; Thu, 25 Jun 2020 15:17:04 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DEF99EC1A3; Thu, 25 Jun 2020 19:17:03 +0000 (UTC) Received: from eperezma.remote.csb (ovpn-113-130.ams2.redhat.com [10.36.113.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3211179303; Thu, 25 Jun 2020 19:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593112631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l5Sqnb1Joi1fqGAHa0mURL2LJiuQDUWCxBOE3t4IBnQ=; b=RX0bpJgHGZDbbFo6IiWsLS5lzt75IIizohfZP1pdqoPdau93neuDhwYMbuAA4RqmYEoTCO hmaowiuL4Ov90z+l9v2jhukqq5RFCoA3ZsUmM0DY4R1F9XI/xfZ5gl4/PVmAASxTpw6Uyt bmC5N6Vjle4EfDqtTHO1tjblqOcT+Ss= X-MC-Unique: s1Z_mXMXOX2Y5oSVvunFrg-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Subject: [RFC 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier Date: Thu, 25 Jun 2020 21:16:51 +0200 Message-Id: <20200625191651.5817-2-eperezma@redhat.com> In-Reply-To: <20200625191651.5817-1-eperezma@redhat.com> References: <20200625191651.5817-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=eperezma@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/25 00:45:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Juan Quintela , Jason Wang , Peter Xu , Avi Kivity , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Bug reference: https://bugs.launchpad.net/qemu/+bug/1885175 It is possible to hit this assertion on rhel7 guests if iommu is properly enabled. Signed-off-by: Eugenio P=C3=A9rez --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 2f15a4b250..4db609b843 100644 --- a/memory.c +++ b/memory.c @@ -1915,7 +1915,7 @@ void memory_region_notify_one(IOMMUNotifier *notifier, return; } =20 - assert(entry->iova >=3D notifier->start && entry_end <=3D notifier->en= d); + // assert(entry->iova >=3D notifier->start && entry_end <=3D notifier-= >end); =20 if (entry->perm & IOMMU_RW) { request_flags =3D IOMMU_NOTIFIER_MAP; --=20 2.18.1