From nobody Sat Nov 15 04:14:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593098690; cv=none; d=zohomail.com; s=zohoarc; b=Xsr3v57gIlNBcBZjQoIJ9dR8MxmhXKD5w3tTG4yA9ptVB5/vtq3NQ/8at+zZQNVU/vHReuz4ZVsCXm1iNv8XeQMlKDbH/c/yOvzsKHZeol+SJst1FMRGIqXlNSCWoTWcu5/aIXwYgGwQk1vnODjWoHnIQ3Wd934lW0CVHd+r/lw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593098690; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SGreytvX6x6DdPG/somvNhsK9PYRN+q+t2R2x2o2HhU=; b=G/YHvcxb7rsHMveQ/gjuW6y3IhEEHlJjupbtb5s5NZe9szH3a2wqcU7fFLMfpUPjDF55rMW+t4tqSgz5qdq4J2fv6yxQB1z4ZuapQEgPHoTiNiGcWs1R0sXgeU3jk3rzqoEdwHIVyXhp9IE6Y94iVASuFZ5HBr+rThcgkVsqlUA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593098690623110.35607732973278; Thu, 25 Jun 2020 08:24:50 -0700 (PDT) Received: from localhost ([::1]:58144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joTk9-0007HK-9m for importer@patchew.org; Thu, 25 Jun 2020 11:24:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joThv-000574-Po for qemu-devel@nongnu.org; Thu, 25 Jun 2020 11:22:31 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:38592 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joTht-0000UR-3e for qemu-devel@nongnu.org; Thu, 25 Jun 2020 11:22:31 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-222-Y5SxmXsnMFe3JiAw3VvRiQ-1; Thu, 25 Jun 2020 11:22:25 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38E2D1800D4A; Thu, 25 Jun 2020 15:22:24 +0000 (UTC) Received: from localhost (ovpn-113-182.ams2.redhat.com [10.36.113.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CEC987554F; Thu, 25 Jun 2020 15:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593098547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SGreytvX6x6DdPG/somvNhsK9PYRN+q+t2R2x2o2HhU=; b=dDuDFBfhPRSmlz1O5JegZJRRdgRyRnbl4ZmqWtE0ng3bM9bMw+TIIPyewvh+vfGiWsAW+i efTWFZ7wEUCpt2qksiHWwegM1Ojlub4Qy2aqvk0K3Q8TmGsdsbtnzwqFCfgBBxck/OphB3 KC9OtFlqB2vvGzs9NsZ8MOvJm3ZDTFo= X-MC-Unique: Y5SxmXsnMFe3JiAw3VvRiQ-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v7 03/47] block: bdrv_cow_child() for bdrv_has_zero_init() Date: Thu, 25 Jun 2020 17:21:31 +0200 Message-Id: <20200625152215.941773-4-mreitz@redhat.com> In-Reply-To: <20200625152215.941773-1-mreitz@redhat.com> References: <20200625152215.941773-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/25 00:45:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" bdrv_has_zero_init() and the related bdrv_unallocated_blocks_are_zero() should use bdrv_cow_child() if they want to check whether the given BDS has a COW backing file. Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 0a0b855261..f3e2aae49c 100644 --- a/block.c +++ b/block.c @@ -5394,7 +5394,7 @@ int bdrv_has_zero_init(BlockDriverState *bs) =20 /* If BS is a copy on write image, it is initialized to the contents of the base image, which may not be zeroes. */ - if (bs->backing) { + if (bdrv_cow_child(bs)) { return 0; } if (bs->drv->bdrv_has_zero_init) { @@ -5412,7 +5412,7 @@ bool bdrv_unallocated_blocks_are_zero(BlockDriverStat= e *bs) { BlockDriverInfo bdi; =20 - if (bs->backing) { + if (bdrv_cow_child(bs)) { return false; } =20 --=20 2.26.2