From nobody Sat Nov 15 04:18:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593099722; cv=none; d=zohomail.com; s=zohoarc; b=J23JhEpFAsk3VSpSgMk4yS38X41qE7Q3j08DvNIFTPUB7Ysme8OVbDplGP2T1swnf3H995LiBNtiTHkIDc6tKNK4bsxA2QZSqidxKoykpA0TncfPKIqcD9czZq4mvVL7QdHcS3Quub7O+VwQ3r21qPtq0nzuEtx85R78P8CbLYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593099722; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RoOduJqwAcCCbtswbUqZ/O4h3JjrgT0wbvxEWac1X0U=; b=RzAQuTmUKQugyIEC0Zs+avVkNs6OS/CFcZlF1k5z91KWqU5rPlXc24rtt77hQPzCDsnmCxnw7j/TS7fOw8tm2mORmvTGjDtab49qlmy9f20imMhsacUpLKi8e/l6BWNk+k8l1XeaRjwoTMu2NUQuq8S1/q1Ee/NaD9NkZsXopDQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593099722415375.23325156359294; Thu, 25 Jun 2020 08:42:02 -0700 (PDT) Received: from localhost ([::1]:58776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joU0m-0007Z2-Qe for importer@patchew.org; Thu, 25 Jun 2020 11:42:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joTiz-0006L9-G6 for qemu-devel@nongnu.org; Thu, 25 Jun 2020 11:23:37 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:54821 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joTip-0001Hw-Uu for qemu-devel@nongnu.org; Thu, 25 Jun 2020 11:23:36 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-474-eAV4fmnfNiGvwElwWwlIPQ-1; Thu, 25 Jun 2020 11:23:23 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA68F107ACCD; Thu, 25 Jun 2020 15:23:22 +0000 (UTC) Received: from localhost (ovpn-113-182.ams2.redhat.com [10.36.113.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A7C51A913; Thu, 25 Jun 2020 15:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593098605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RoOduJqwAcCCbtswbUqZ/O4h3JjrgT0wbvxEWac1X0U=; b=DqV/pA/VqtP1OKmhek2HNzgQDwRlHQAe2RtDAMZPlz78fWE9CKbilIt28bV/WpMfoDwXpB afYtX9em70WdLnwrh54ijgi3Xo9qJBj8mcB3cqyOqvCAZ87KLkDdtH0lIUERTcjDhjFbGs z5lKz7ThOdyNM/huoLcnTZWG7+TT5BM= X-MC-Unique: eAV4fmnfNiGvwElwWwlIPQ-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v7 29/47] blockdev: Use CAF in external_snapshot_prepare() Date: Thu, 25 Jun 2020 17:21:57 +0200 Message-Id: <20200625152215.941773-30-mreitz@redhat.com> In-Reply-To: <20200625152215.941773-1-mreitz@redhat.com> References: <20200625152215.941773-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/25 00:45:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This allows us to differentiate between filters and nodes with COW backing files: Filters cannot be used as overlays at all (for this function). Signed-off-by: Max Reitz Reviewed-by: Andrey Shinkevich --- blockdev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 1eb0fcdea2..aabe51036d 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1549,7 +1549,12 @@ static void external_snapshot_prepare(BlkActionState= *common, goto out; } =20 - if (state->new_bs->backing !=3D NULL) { + if (state->new_bs->drv->is_filter) { + error_setg(errp, "Filters cannot be used as overlays"); + goto out; + } + + if (bdrv_cow_child(state->new_bs)) { error_setg(errp, "The overlay already has a backing image"); goto out; } --=20 2.26.2