From nobody Mon Feb 9 23:42:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593025868; cv=none; d=zohomail.com; s=zohoarc; b=NDErct9Lxvn1HxMncssDAbzQAlUuCc+f7eUdEIsh6X2Z6PMkc5cRcI+t9sP2vJ93cbxo1MTMpRshlyIrLQmCInU/oCMXeBy1ZtBCpMYpYgqAjb/V96MX4rRBDR13yCcgs1SGobVvSw+uaEVLkP75tVfI8vzfgvgvHRsC/EKh2E0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593025868; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PJsRBGUOb73DHRmjtLDJwi3qY0lfc6VGkHzLnBs0AxE=; b=Amqn2SiGmWzggu1tFxcJgt3yWhPwZVyu2zCCAwd8aS9iNMlob1uDO6Czwv8aIzHg3zj6afexk/hRf2y546mdQYQHhUhyhbEzFQSCONSr6e2gh4OKbZkH6+kmC9Nl1tk8DguFMexToGxqBEglK4hl16pdjVGZyW7+RyZyFIH+U2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593025868242594.662091094867; Wed, 24 Jun 2020 12:11:08 -0700 (PDT) Received: from localhost ([::1]:44540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joAna-0001PV-No for importer@patchew.org; Wed, 24 Jun 2020 15:11:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joAeK-0005BU-Ou for qemu-devel@nongnu.org; Wed, 24 Jun 2020 15:01:32 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53222 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1joAeH-0004ma-Ut for qemu-devel@nongnu.org; Wed, 24 Jun 2020 15:01:31 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-0O0ggHP6MkinPsI-cYQxMg-1; Wed, 24 Jun 2020 14:58:26 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EECE310059A6; Wed, 24 Jun 2020 18:58:24 +0000 (UTC) Received: from localhost.localdomain (unknown [10.74.8.251]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01AAD79305; Wed, 24 Jun 2020 18:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593025289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PJsRBGUOb73DHRmjtLDJwi3qY0lfc6VGkHzLnBs0AxE=; b=gjsMuznSX648NertV8MqgHzPIREuKDaZhX5F1uvEe9czVyF+RW4kJQ8iWGhgo3bKfC08nx HDa8wuMJgcmRYSEfW1APieToPkRTFIf/VS/FC39nkEivn5SSpD6qz21mcI3n7CWnxUvUcV PhFXaW9VCm4+QxTD52PZ+0t4+rDiGyk= X-MC-Unique: 0O0ggHP6MkinPsI-cYQxMg-1 From: P J P To: Paolo Bonzini Subject: [PATCH v2 6/9] spapr_pci: add spapr msi read method Date: Thu, 25 Jun 2020 00:25:20 +0530 Message-Id: <20200624185523.762240-7-ppandit@redhat.com> In-Reply-To: <20200624185523.762240-1-ppandit@redhat.com> References: <20200624185523.762240-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=ppandit@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/24 03:27:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Prasad J Pandit , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Li Qiang , QEMU Developers , Lei Sun , Alex Williamson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit Add spapr msi mmio read method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Signed-off-by: Prasad J Pandit Acked-by: David Gibson Reviewed-by: Li Qiang --- hw/ppc/spapr_pci.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 329002ac04..7033352834 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -52,6 +52,7 @@ #include "sysemu/kvm.h" #include "sysemu/hostmem.h" #include "sysemu/numa.h" +#include "qemu/log.h" =20 /* Copied from the kernel arch/powerpc/platforms/pseries/msi.c */ #define RTAS_QUERY_FN 0 @@ -738,6 +739,12 @@ static PCIINTxRoute spapr_route_intx_pin_to_irq(void *= opaque, int pin) return route; } =20 +static uint64_t spapr_msi_read(void *opaque, hwaddr addr, unsigned size) +{ + qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__); + return 0; +} + /* * MSI/MSIX memory region implementation. * The handler handles both MSI and MSIX. @@ -755,8 +762,10 @@ static void spapr_msi_write(void *opaque, hwaddr addr, } =20 static const MemoryRegionOps spapr_msi_ops =3D { - /* There is no .read as the read result is undefined by PCI spec */ - .read =3D NULL, + /* .read result is undefined by PCI spec + * define .read method to avoid assert failure in memory_region_init_io + */ + .read =3D spapr_msi_read, .write =3D spapr_msi_write, .endianness =3D DEVICE_LITTLE_ENDIAN }; --=20 2.26.2