From nobody Fri Dec 19 17:51:27 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593018838; cv=none; d=zohomail.com; s=zohoarc; b=brZop2tpb17oPDkSEMinhxeHeHneS+KLzX2XDnqcvCD928Ech8ikDdS/9GBW1+zxI1acwOqVQ1pbQx2jpyBpGKpMyA3AT/zWWNyehujEg8Lq/kQ2B85ttWd1suObqr6FSY9ZmLovDOWOZh6baupDo5s/uulwWwBXuZs+LDoA3QA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593018838; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Kp1vfexx7WPBqjR7fuIpou+illDjvMfyvZqxabrbF5g=; b=Xcvt1SMEF+2usL0iZYxQkFdpFrFEXIsv+9iUHLCkgtY6Zk2SaR82WIcSYx0dPv/efKPNV2A2PwfkYJsTpywWra3C6f8UQbwIr9ozixP5kd23v9axGOEYv7+aYr2ih+DqpePHGdEvdffoUi+/UtvoCXFafeVqK5yDRvYTeE2QAw8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1593018838081599.0070208967627; Wed, 24 Jun 2020 10:13:58 -0700 (PDT) Received: from localhost ([::1]:42224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jo8yC-0005hu-RE for importer@patchew.org; Wed, 24 Jun 2020 13:13:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jo8Vm-0004W9-5T for qemu-devel@nongnu.org; Wed, 24 Jun 2020 12:44:34 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53480 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jo8VD-00059E-QY for qemu-devel@nongnu.org; Wed, 24 Jun 2020 12:44:33 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-HHtxom14P8ytcpHH1wOF7w-1; Wed, 24 Jun 2020 12:43:53 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F12F107ACF8; Wed, 24 Jun 2020 16:43:52 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BED65D9C5; Wed, 24 Jun 2020 16:43:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7D8C21138496; Wed, 24 Jun 2020 18:43:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593017037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kp1vfexx7WPBqjR7fuIpou+illDjvMfyvZqxabrbF5g=; b=EC8ihwkucvYaLMD2FGZaxubTfcBC0t4VXElZJTV/Fdz91N4zLOLjNmhAHdT9szH7TMrkCz NrqgBKGtaHTWiJmVLWcj1+xOdmZP7XcKl7TY2CZ2FYz5inAEIwH7MBrBMnpwew+r4qMKBS EcW5TpcRevB1WiwdOk5Vw7vJSXV7kLQ= X-MC-Unique: HHtxom14P8ytcpHH1wOF7w-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 41/46] qdev: Make functions taking Error ** return bool, not void Date: Wed, 24 Jun 2020 18:43:39 +0200 Message-Id: <20200624164344.3778251-42-armbru@redhat.com> In-Reply-To: <20200624164344.3778251-1-armbru@redhat.com> References: <20200624164344.3778251-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/24 02:33:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, vsementsov@virtuozzo.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" See recent commit "error: Document Error API usage rules" for rationale. Signed-off-by: Markus Armbruster --- include/hw/qdev-properties.h | 4 ++-- hw/core/qdev-properties-system.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h index 49c6cd2460..f12ab9e6bc 100644 --- a/include/hw/qdev-properties.h +++ b/include/hw/qdev-properties.h @@ -236,8 +236,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width; /* * Set properties between creation and realization. */ -void qdev_prop_set_drive_err(DeviceState *dev, const char *name, - BlockBackend *value, Error **errp); +bool qdev_prop_set_drive_err(DeviceState *dev, const char *name, + BlockBackend *value, Error **errp); =20 /* * Set properties between creation and realization. diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-sys= tem.c index abd851656f..3e4f16fc21 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -413,7 +413,7 @@ const PropertyInfo qdev_prop_audiodev =3D { .set =3D set_audiodev, }; =20 -void qdev_prop_set_drive_err(DeviceState *dev, const char *name, +bool qdev_prop_set_drive_err(DeviceState *dev, const char *name, BlockBackend *value, Error **errp) { const char *ref =3D ""; @@ -428,7 +428,7 @@ void qdev_prop_set_drive_err(DeviceState *dev, const ch= ar *name, } } =20 - object_property_set_str(OBJECT(dev), name, ref, errp); + return object_property_set_str(OBJECT(dev), name, ref, errp); } =20 void qdev_prop_set_drive(DeviceState *dev, const char *name, --=20 2.26.2