From nobody Mon May 6 14:19:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592995904; cv=none; d=zohomail.com; s=zohoarc; b=TYVjX6jnYT1j+e9JPcPWGYObXoWlmpOkU53yxjdWKlVSok52aRp/SG7PSRin01sGkL65dFC963tD6U8+0Vyuqcc+oDSKdeJsHrF27MLm7OJUlfWfkYAKe9rXs4exERdHrfY+ZZ+0wll0efZSAVHUoFT03DiLPkVVGCLrSsPJzug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592995904; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xIcB8vduAfxdk/tQiglXPIEDhcVUHNx19z45fvg25z4=; b=Mllr/vTcgMVG8GBmHeUeeJ5o2noauZX/Qqh+oN7H178YwgFhRMP47kzySyAKks/Ty8HEXSS+Fpcc5WAVheGYWVSVyJDWNYR1qtMEct7Oii6kiZGkmRboVRQOaTAKxbIg2nvvpQyQ83nLTMHkHYXATR8OY9onI0duUKiAN0EQOoU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592995904943972.6507974489336; Wed, 24 Jun 2020 03:51:44 -0700 (PDT) Received: from localhost ([::1]:48306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jo30J-0001WK-Jq for importer@patchew.org; Wed, 24 Jun 2020 06:51:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jo2yd-0007Oj-HP for qemu-devel@nongnu.org; Wed, 24 Jun 2020 06:49:59 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:48060 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jo2yb-0000mu-AK for qemu-devel@nongnu.org; Wed, 24 Jun 2020 06:49:59 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-jhP20RJZOXqhzorcSV0fHQ-1; Wed, 24 Jun 2020 06:49:54 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C59B364AD0; Wed, 24 Jun 2020 10:49:53 +0000 (UTC) Received: from localhost (ovpn-114-150.ams2.redhat.com [10.36.114.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C2FF7CADE; Wed, 24 Jun 2020 10:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592995796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xIcB8vduAfxdk/tQiglXPIEDhcVUHNx19z45fvg25z4=; b=U+2Tet0xEzgplkJabxmKP+EDaJOW7/pvaDWBeN6w++s9XiJ50CKlHoqQ9FYCBuqOrdqJL9 thbRks11RaIgaHb3sSXuJ1c+Guz2uRzSPUQslB7XTzWkVsyJRjoANdOWQGasAqvBCCIlPU hGZFBwK4+H4G50oIi5nHuAp+nYMGu3Y= X-MC-Unique: jhP20RJZOXqhzorcSV0fHQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL 1/2] scripts/tracetool: Update maintainer email address Date: Wed, 24 Jun 2020 11:49:34 +0100 Message-Id: <20200624104935.61329-2-stefanha@redhat.com> In-Reply-To: <20200624104935.61329-1-stefanha@redhat.com> References: <20200624104935.61329-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/24 01:59:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , John Snow , Gerd Hoffmann , Stefan Hajnoczi , Cleber Rosa , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 There is an effort in progress to generate a QEMU Python package. As I'm not sure this old email is still valid, update it to not produce package with broken maintainer email. Patch created mechanically by running: $ sed -i 's,\(__email__ *=3D "\)stefanha@linux.vnet.ibm.com",\1stefanha@re= dhat.com",' \ $(git grep -l 'email.*stefanha@linux.vnet.ibm.com') Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: John Snow Message-id: 20200511082816.696-1-philmd@redhat.com Signed-off-by: Stefan Hajnoczi --- scripts/tracetool.py | 2 +- scripts/tracetool/__init__.py | 2 +- scripts/tracetool/backend/__init__.py | 2 +- scripts/tracetool/backend/dtrace.py | 2 +- scripts/tracetool/backend/log.py | 2 +- scripts/tracetool/backend/simple.py | 2 +- scripts/tracetool/backend/ust.py | 2 +- scripts/tracetool/format/__init__.py | 2 +- scripts/tracetool/format/c.py | 2 +- scripts/tracetool/format/d.py | 2 +- scripts/tracetool/format/h.py | 2 +- scripts/tracetool/format/stap.py | 2 +- scripts/tracetool/format/tcg_h.py | 2 +- scripts/tracetool/format/tcg_helper_c.py | 2 +- scripts/tracetool/format/tcg_helper_h.py | 2 +- scripts/tracetool/format/tcg_helper_wrapper_h.py | 2 +- scripts/tracetool/transform.py | 2 +- scripts/tracetool/vcpu.py | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index 264cc9eecc..31146242b7 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -10,7 +10,7 @@ __copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilan= ova " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 import sys diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 13d29f1e42..3ccfa1e116 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2017, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 import re diff --git a/scripts/tracetool/backend/__init__.py b/scripts/tracetool/back= end/__init__.py index 54cab2c4de..7bfcc86cc5 100644 --- a/scripts/tracetool/backend/__init__.py +++ b/scripts/tracetool/backend/__init__.py @@ -50,7 +50,7 @@ __copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilan= ova " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 import os diff --git a/scripts/tracetool/backend/dtrace.py b/scripts/tracetool/backen= d/dtrace.py index 638990db79..5711892ba0 100644 --- a/scripts/tracetool/backend/dtrace.py +++ b/scripts/tracetool/backend/dtrace.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2017, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/backend/log.py b/scripts/tracetool/backend/l= og.py index 23b274c0fd..877222bbe9 100644 --- a/scripts/tracetool/backend/log.py +++ b/scripts/tracetool/backend/log.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2017, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backen= d/simple.py index b650c262b5..a74d61fcd6 100644 --- a/scripts/tracetool/backend/simple.py +++ b/scripts/tracetool/backend/simple.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2017, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/backend/ust.py b/scripts/tracetool/backend/u= st.py index a772a3b53b..6c0a5f8d68 100644 --- a/scripts/tracetool/backend/ust.py +++ b/scripts/tracetool/backend/ust.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2017, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/format/__init__.py b/scripts/tracetool/forma= t/__init__.py index aba2f7a441..2dc46f3dd9 100644 --- a/scripts/tracetool/format/__init__.py +++ b/scripts/tracetool/format/__init__.py @@ -32,7 +32,7 @@ __copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilan= ova " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 import os diff --git a/scripts/tracetool/format/c.py b/scripts/tracetool/format/c.py index 78af8aff72..23d82ea861 100644 --- a/scripts/tracetool/format/c.py +++ b/scripts/tracetool/format/c.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/format/d.py b/scripts/tracetool/format/d.py index d3980b914b..0afb5f3f47 100644 --- a/scripts/tracetool/format/d.py +++ b/scripts/tracetool/format/d.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py index 83e1a2f355..e94f0be7da 100644 --- a/scripts/tracetool/format/h.py +++ b/scripts/tracetool/format/h.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2017, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/format/stap.py b/scripts/tracetool/format/st= ap.py index 8fc808f2ef..a218b0445c 100644 --- a/scripts/tracetool/format/stap.py +++ b/scripts/tracetool/format/stap.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2014, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/format/tcg_h.py b/scripts/tracetool/format/t= cg_h.py index 0180e3d76c..33cf6a31b3 100644 --- a/scripts/tracetool/format/tcg_h.py +++ b/scripts/tracetool/format/tcg_h.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2017, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out, Arguments diff --git a/scripts/tracetool/format/tcg_helper_c.py b/scripts/tracetool/f= ormat/tcg_helper_c.py index 6527b69afd..2db6317f3c 100644 --- a/scripts/tracetool/format/tcg_helper_c.py +++ b/scripts/tracetool/format/tcg_helper_c.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2017, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import Arguments, out diff --git a/scripts/tracetool/format/tcg_helper_h.py b/scripts/tracetool/f= ormat/tcg_helper_h.py index 98ebe52f18..08554fbc85 100644 --- a/scripts/tracetool/format/tcg_helper_h.py +++ b/scripts/tracetool/format/tcg_helper_h.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2016, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/format/tcg_helper_wrapper_h.py b/scripts/tra= cetool/format/tcg_helper_wrapper_h.py index 6adeab74df..0c5a9797d1 100644 --- a/scripts/tracetool/format/tcg_helper_wrapper_h.py +++ b/scripts/tracetool/format/tcg_helper_wrapper_h.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2016, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import out diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py index 8fd4dcf20d..ea8b27799d 100644 --- a/scripts/tracetool/transform.py +++ b/scripts/tracetool/transform.py @@ -9,7 +9,7 @@ __copyright__ =3D "Copyright 2012-2016, Llu=C3=ADs Vilanov= a " __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 def _transform_type(type_, trans): diff --git a/scripts/tracetool/vcpu.py b/scripts/tracetool/vcpu.py index 0b104e4f15..b54e4f4e7a 100644 --- a/scripts/tracetool/vcpu.py +++ b/scripts/tracetool/vcpu.py @@ -10,7 +10,7 @@ __copyright__ =3D "Copyright 2016, Llu=C3=ADs Vilanova <= vilanova@ac.upc.edu>" __license__ =3D "GPL version 2 or (at your option) any later version" =20 __maintainer__ =3D "Stefan Hajnoczi" -__email__ =3D "stefanha@linux.vnet.ibm.com" +__email__ =3D "stefanha@redhat.com" =20 =20 from tracetool import Arguments, try_import --=20 2.26.2 From nobody Mon May 6 14:19:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592995907; cv=none; d=zohomail.com; s=zohoarc; b=W4F5gzp3aaAf5B2fA1UUOMXaklLEUUa5+1wUNx4Fo5frs5rTUbqm0hB8A+vXQcYVeiJ3gA4ondurAPl3ZClFGtplNN5Uin5QLylFMtzrK2BVeObj3sySue6dolzGmmeHmqQDX2SYh52QamVYgRFP+DX0OtvA8yRNehKJ53TO12g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592995907; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PbJOg/nv+ZCE+TPgqIsQ1ilmNbbkdoUQ+wuzW+cmF4g=; b=O6YTIU3P1jHza/nRh87VENZ17nX9eJLxibSE5aVaF1YQLqquj2RY7rNDE9u/yT4HCNlooBNAVciOsgvtqVDZhYCyTE8H3VtvQytmhvOVlV7Qg6RExl+pE7lsS5D+gN7PTnbj84tLZppVPF+g5QgEMtABZFi/BY+ctgm0yIcY4IE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592995907024761.9332296854145; Wed, 24 Jun 2020 03:51:47 -0700 (PDT) Received: from localhost ([::1]:48526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jo30L-0001c2-Np for importer@patchew.org; Wed, 24 Jun 2020 06:51:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jo2yi-0007YR-0Z for qemu-devel@nongnu.org; Wed, 24 Jun 2020 06:50:07 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:47300 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jo2yg-0000oo-C6 for qemu-devel@nongnu.org; Wed, 24 Jun 2020 06:50:03 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-BotcB8MVOpWNTEDaeWvXeA-1; Wed, 24 Jun 2020 06:49:59 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C0551005513; Wed, 24 Jun 2020 10:49:58 +0000 (UTC) Received: from localhost (ovpn-114-150.ams2.redhat.com [10.36.114.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 326FF61981; Wed, 24 Jun 2020 10:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592995801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PbJOg/nv+ZCE+TPgqIsQ1ilmNbbkdoUQ+wuzW+cmF4g=; b=TUlrlUM9Q7z7GvJKdoE3UB9ix1BvwuQ6O7/hxVN4Nx3HDGPAAHqK9d9XBuszmihsLqEy0K Tn3DniAllIiSqO5fTLivp1HzymoYPz6x0g+vp+8g+CZNMOMb40hujgTRjprFRE4DMSdxKW 6xUzTMSUJO0OXW5c37Lx2WiEq2PSzTk= X-MC-Unique: BotcB8MVOpWNTEDaeWvXeA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL 2/2] trace/simple: Fix unauthorized enable Date: Wed, 24 Jun 2020 11:49:35 +0100 Message-Id: <20200624104935.61329-3-stefanha@redhat.com> In-Reply-To: <20200624104935.61329-1-stefanha@redhat.com> References: <20200624104935.61329-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=stefanha@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/24 03:27:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Markus Armbruster , Gerd Hoffmann , Stefan Hajnoczi , Cleber Rosa , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Markus Armbruster st_set_trace_file() accidentally enables tracing. It's called unconditionally during startup, which is why QEMU built with the simple trace backend always writes a trace file "trace-$PID". This has been broken for quite a while. I didn't track down the exact commit. Fix st_set_trace_file() to restore the state. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20200527065613.25322-1-armbru@redhat.com Signed-off-by: Stefan Hajnoczi --- trace/simple.h | 2 +- trace/simple.c | 20 ++++++++++++++------ 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/trace/simple.h b/trace/simple.h index 5771a0634f..26ccbc8b8a 100644 --- a/trace/simple.h +++ b/trace/simple.h @@ -12,7 +12,7 @@ #define TRACE_SIMPLE_H =20 void st_print_trace_file_status(void); -void st_set_trace_file_enabled(bool enable); +bool st_set_trace_file_enabled(bool enable); void st_set_trace_file(const char *file); bool st_init(void); void st_flush_trace_buffer(void); diff --git a/trace/simple.c b/trace/simple.c index fc7106ec49..9cd2ed1fb3 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -302,10 +302,17 @@ static int st_write_event_mapping(void) return 0; } =20 -void st_set_trace_file_enabled(bool enable) +/** + * Enable / disable tracing, return whether it was enabled. + * + * @enable: enable if %true, else disable. + */ +bool st_set_trace_file_enabled(bool enable) { + bool was_enabled =3D trace_fp; + if (enable =3D=3D !!trace_fp) { - return; /* no change */ + return was_enabled; /* no change */ } =20 /* Halt trace writeout */ @@ -323,14 +330,14 @@ void st_set_trace_file_enabled(bool enable) =20 trace_fp =3D fopen(trace_file_name, "wb"); if (!trace_fp) { - return; + return was_enabled; } =20 if (fwrite(&header, sizeof header, 1, trace_fp) !=3D 1 || st_write_event_mapping() < 0) { fclose(trace_fp); trace_fp =3D NULL; - return; + return was_enabled; } =20 /* Resume trace writeout */ @@ -340,6 +347,7 @@ void st_set_trace_file_enabled(bool enable) fclose(trace_fp); trace_fp =3D NULL; } + return was_enabled; } =20 /** @@ -350,7 +358,7 @@ void st_set_trace_file_enabled(bool enable) */ void st_set_trace_file(const char *file) { - st_set_trace_file_enabled(false); + bool saved_enable =3D st_set_trace_file_enabled(false); =20 g_free(trace_file_name); =20 @@ -361,7 +369,7 @@ void st_set_trace_file(const char *file) trace_file_name =3D g_strdup_printf("%s", file); } =20 - st_set_trace_file_enabled(true); + st_set_trace_file_enabled(saved_enable); } =20 void st_print_trace_file_status(void) --=20 2.26.2