From nobody Tue Feb 10 21:59:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592946299; cv=none; d=zohomail.com; s=zohoarc; b=VkPNRcYZvt9R/XvktY5z//YyZfIF5g/qVi4i2NHQJhI0gkmeEfb9Mh9QbSXHrjuXZRg4gXYXOxjZpLtKjL0/Y1EaBq6SMNE/b602AjcwsoARp++ZlOUfyKVn6VVd06UYpwk4WIR2KfJdDFTxAQOzOcF3rLddTf4fZ4ZTLOSv9tQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592946299; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H8FYF8uwzls5xQ9gKnr6eUFWG4YuDemo+KDL6EPah04=; b=DJL3NaGIEqFVh49zRHnM+CaNA6qDWp84ZlF49I/+UjSkmpXS7Ab8IhY/AfrtnE4NR18kKYbxR+BP+W2EwXVgMawCdjy4Qae9uEeuw+th8wEM4iRxeELNUJTgHY9Cw41Cd/kGJ80FAe8l3u7UoS3ysaG6XbIgOnbGrpPmUAwcrkU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159294629903241.531328354769244; Tue, 23 Jun 2020 14:04:59 -0700 (PDT) Received: from localhost ([::1]:33002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnq6D-00046G-JT for importer@patchew.org; Tue, 23 Jun 2020 17:04:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnpsu-0005Q4-Bv; Tue, 23 Jun 2020 16:51:12 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:56470 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnpss-000226-QZ; Tue, 23 Jun 2020 16:51:12 -0400 Received: from host86-158-109-79.range86-158.btcentralplus.com ([86.158.109.79] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnpsq-0007T1-QM; Tue, 23 Jun 2020 21:51:12 +0100 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, laurent@vivier.eu, fthain@telegraphics.com.au Date: Tue, 23 Jun 2020 21:49:31 +0100 Message-Id: <20200623204936.24064-18-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200623204936.24064-1-mark.cave-ayland@ilande.co.uk> References: <20200623204936.24064-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.158.109.79 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH v2 17/22] pmu: add adb_autopoll_block() and adb_autopoll_unblock() functions X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Ensure that the PMU buffer is protected from autopoll requests overwriting its contents whilst existing PMU requests are in progress. Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain --- hw/misc/macio/pmu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/macio/pmu.c b/hw/misc/macio/pmu.c index 01d49e6695..598d8e7517 100644 --- a/hw/misc/macio/pmu.c +++ b/hw/misc/macio/pmu.c @@ -517,6 +517,7 @@ static void pmu_update(PMUState *s) { MOS6522PMUState *mps =3D &s->mos6522_pmu; MOS6522State *ms =3D MOS6522(mps); + ADBBusState *adb_bus =3D &s->adb_bus; =20 /* Only react to changes in reg B */ if (ms->b =3D=3D s->last_b) { @@ -578,6 +579,7 @@ static void pmu_update(PMUState *s) s->cmd_rsp_pos =3D 0; s->cmd_state =3D pmu_state_cmd; =20 + adb_autopoll_block(adb_bus); trace_pmu_debug_protocol_cmd(s->cmd, s->cmdlen, s->rsplen); break; =20 @@ -636,6 +638,7 @@ static void pmu_update(PMUState *s) if (s->cmd_state =3D=3D pmu_state_rsp && s->rsplen =3D=3D s->cmd_rsp_p= os) { trace_pmu_debug_protocol_cmd_resp_complete(ms->ier); =20 + adb_autopoll_unblock(adb_bus); s->cmd_state =3D pmu_state_idle; } } --=20 2.20.1