From nobody Thu May 2 07:45:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592942854; cv=none; d=zohomail.com; s=zohoarc; b=ktbkM4/WOYHK1Fl4SKbXv1fdiFNdXLA1akBeZhJHA0kOVYiIfz9ED3W5lGKmM0fA9PnFtQfoKY+MfF5DEpuKu0q2+B3RZWR56k2yeurZ0lA0Z/NbTlstKuV0jWlqjwX9DsSk0vVj7L5Rl7+jtVR91GLKpaNNhoH2/tWV7CG8Cjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592942854; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5IU006YQ88d5veC791l8custkvzJFLj9YkpXAZ+R5j4=; b=FVRtzT35uVmNg3Ir8VZIY/c6KmXCd1c459sGD0DOJtRvp1D0KbFv9nORW+m+anWyVfNgzmALU7SfUTYJjqq8+CS17JZMAppGoCnTY6xgbQRHf/5vfnmy3Yq8SFl97hBMIrQ7nk4Ley91TqxuBtY9R3ApDV86juEKYj897UhDAkU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592942854072477.45798328365754; Tue, 23 Jun 2020 13:07:34 -0700 (PDT) Received: from localhost ([::1]:48480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnpCe-0006PD-Pv for importer@patchew.org; Tue, 23 Jun 2020 16:07:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnp0J-00048e-LX for qemu-devel@nongnu.org; Tue, 23 Jun 2020 15:54:47 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:56007 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jnp0I-0007dB-0s for qemu-devel@nongnu.org; Tue, 23 Jun 2020 15:54:47 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-V60IVn-LNiyFLUtTgUgG4g-1; Tue, 23 Jun 2020 15:54:43 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DBA51005512 for ; Tue, 23 Jun 2020 19:54:42 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3205910013C0; Tue, 23 Jun 2020 19:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592942084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5IU006YQ88d5veC791l8custkvzJFLj9YkpXAZ+R5j4=; b=CBfRVFu2EdBtRaHeMfZfX/HaTaslrlUir24IJlXogm1giRmnYOHrmrKEmnzUlE8E38Nmdv hpBDvwwsymmhFg2Tjoi6tDX+bReSu4hhTR21WAbOdxQYGmsvbnsleecULllvDZQqBZE9ky 9S4vFn/K/WOpaJ75Uc9gWVVFc+4kLXs= X-MC-Unique: V60IVn-LNiyFLUtTgUgG4g-1 From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH] ibex_uart: fix XOR-as-pow Date: Tue, 23 Jun 2020 15:54:41 -0400 Message-Id: <20200623195441.14646-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/23 01:55:08 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The xor-as-pow warning in clang actually detected a genuine bug. Fix it. Signed-off-by: Paolo Bonzini Reviewed-by: Alistair Francis Reviewed-by: Eric Blake --- hw/char/ibex_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c index 3e0dd9968e..45cd724998 100644 --- a/hw/char/ibex_uart.c +++ b/hw/char/ibex_uart.c @@ -331,7 +331,7 @@ static void ibex_uart_write(void *opaque, hwaddr addr, if (value & UART_CTRL_NCO) { uint64_t baud =3D ((value & UART_CTRL_NCO) >> 16); baud *=3D 1000; - baud /=3D 2 ^ 20; + baud >>=3D 20; =20 s->char_tx_time =3D (NANOSECONDS_PER_SECOND / baud) * 10; } --=20 2.26.2