[PULL 00/16] Qdev patches for 2020-06-23

Markus Armbruster posted 16 patches 3 years, 9 months ago
Test FreeBSD passed
Test docker-quick@centos7 passed
Test checkpatch failed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200623142326.2349416-1-armbru@redhat.com
Maintainers: John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Max Reitz <mreitz@redhat.com>, Markus Armbruster <armbru@redhat.com>
docs/qdev-device-use.txt            |  17 +-
docs/system/deprecated.rst          |  34 ++
include/hw/block/fdc.h              |   2 +-
include/hw/qdev-properties.h        |  18 +-
include/sysemu/blockdev.h           |   2 +
blockdev.c                          |  27 +-
hw/arm/aspeed.c                     |  16 +-
hw/arm/cubieboard.c                 |   2 +-
hw/arm/exynos4210.c                 |   2 +-
hw/arm/imx25_pdk.c                  |   2 +-
hw/arm/mcimx6ul-evk.c               |   2 +-
hw/arm/mcimx7d-sabre.c              |   2 +-
hw/arm/msf2-som.c                   |   4 +-
hw/arm/nseries.c                    |   4 +-
hw/arm/orangepi.c                   |   2 +-
hw/arm/raspi.c                      |   2 +-
hw/arm/sabrelite.c                  |   6 +-
hw/arm/vexpress.c                   |   3 +-
hw/arm/xilinx_zynq.c                |   7 +-
hw/arm/xlnx-versal-virt.c           |   2 +-
hw/arm/xlnx-zcu102.c                |  10 +-
hw/block/fdc.c                      |  82 +++--
hw/block/nand.c                     |   2 +-
hw/block/pflash_cfi01.c             |   6 +-
hw/block/pflash_cfi02.c             |   2 +-
hw/core/qdev-properties-system.c    | 151 +++++----
hw/core/qdev-properties.c           |  17 +
hw/i386/pc.c                        |   8 +-
hw/ide/qdev.c                       |   4 +-
hw/isa/isa-superio.c                |  18 +-
hw/m68k/q800.c                      |   3 +-
hw/microblaze/petalogix_ml605_mmu.c |   5 +-
hw/ppc/pnv.c                        |   3 +-
hw/ppc/spapr.c                      |   4 +-
hw/scsi/scsi-bus.c                  |   2 +-
hw/sd/milkymist-memcard.c           |   2 +-
hw/sd/pxa2xx_mmci.c                 |  15 +-
hw/sd/sd.c                          |   2 +-
hw/sd/ssi-sd.c                      |   3 +-
hw/sparc64/sun4u.c                  |   9 +-
hw/xtensa/xtfpga.c                  |   3 +-
softmmu/vl.c                        |   8 +
tests/qemu-iotests/172              |  27 +-
tests/qemu-iotests/172.out          | 656 ++++++++++++++++++++++++++++++++----
44 files changed, 928 insertions(+), 270 deletions(-)
[PULL 00/16] Qdev patches for 2020-06-23
Posted by Markus Armbruster 3 years, 9 months ago
The following changes since commit 61fee7f45955cd0bf9b79be9fa9c7ebabb5e6a85:

  Merge remote-tracking branch 'remotes/philmd-gitlab/tags/acceptance-testing-20200622' into staging (2020-06-22 20:50:10 +0100)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-qdev-2020-06-23

for you to fetch changes up to 953cd66139b6e28fdc7cdbf28065a0a98ce7877c:

  sd/milkymist-memcard: Fix error API violation (2020-06-23 16:07:21 +0200)

----------------------------------------------------------------
Qdev patches for 2020-06-23

* Reject clash between -drive if=floppy and -global isa-fdc
* Deprecate configuring floppies with -global isa-fdc
* Deprecate -drive with bogus interface type
* Reject drive property override instead of screwing up
* Reject chardev property override instead of screwing up
* Various error handling improvements
* Extend iotests/172

----------------------------------------------------------------
Markus Armbruster (16):
      iotests/172: Include "info block" in test output
      iotests/172: Cover empty filename and multiple use of drives
      iotests/172: Cover -global floppy.drive=...
      fdc: Reject clash between -drive if=floppy and -global isa-fdc
      fdc: Open-code fdctrl_init_isa()
      fdc: Deprecate configuring floppies with -global isa-fdc
      docs/qdev-device-use.txt: Update section "Default Devices"
      blockdev: Deprecate -drive with bogus interface type
      qdev: Eliminate get_pointer(), set_pointer()
      qdev: Improve netdev property override error a bit
      qdev: Reject drive property override
      qdev: Reject chardev property override
      qdev: Make qdev_prop_set_drive() match the other helpers
      arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp
      sd/pxa2xx_mmci: Don't crash on pxa2xx_mmci_init() error
      sd/milkymist-memcard: Fix error API violation

 docs/qdev-device-use.txt            |  17 +-
 docs/system/deprecated.rst          |  34 ++
 include/hw/block/fdc.h              |   2 +-
 include/hw/qdev-properties.h        |  18 +-
 include/sysemu/blockdev.h           |   2 +
 blockdev.c                          |  27 +-
 hw/arm/aspeed.c                     |  16 +-
 hw/arm/cubieboard.c                 |   2 +-
 hw/arm/exynos4210.c                 |   2 +-
 hw/arm/imx25_pdk.c                  |   2 +-
 hw/arm/mcimx6ul-evk.c               |   2 +-
 hw/arm/mcimx7d-sabre.c              |   2 +-
 hw/arm/msf2-som.c                   |   4 +-
 hw/arm/nseries.c                    |   4 +-
 hw/arm/orangepi.c                   |   2 +-
 hw/arm/raspi.c                      |   2 +-
 hw/arm/sabrelite.c                  |   6 +-
 hw/arm/vexpress.c                   |   3 +-
 hw/arm/xilinx_zynq.c                |   7 +-
 hw/arm/xlnx-versal-virt.c           |   2 +-
 hw/arm/xlnx-zcu102.c                |  10 +-
 hw/block/fdc.c                      |  82 +++--
 hw/block/nand.c                     |   2 +-
 hw/block/pflash_cfi01.c             |   6 +-
 hw/block/pflash_cfi02.c             |   2 +-
 hw/core/qdev-properties-system.c    | 151 +++++----
 hw/core/qdev-properties.c           |  17 +
 hw/i386/pc.c                        |   8 +-
 hw/ide/qdev.c                       |   4 +-
 hw/isa/isa-superio.c                |  18 +-
 hw/m68k/q800.c                      |   3 +-
 hw/microblaze/petalogix_ml605_mmu.c |   5 +-
 hw/ppc/pnv.c                        |   3 +-
 hw/ppc/spapr.c                      |   4 +-
 hw/scsi/scsi-bus.c                  |   2 +-
 hw/sd/milkymist-memcard.c           |   2 +-
 hw/sd/pxa2xx_mmci.c                 |  15 +-
 hw/sd/sd.c                          |   2 +-
 hw/sd/ssi-sd.c                      |   3 +-
 hw/sparc64/sun4u.c                  |   9 +-
 hw/xtensa/xtfpga.c                  |   3 +-
 softmmu/vl.c                        |   8 +
 tests/qemu-iotests/172              |  27 +-
 tests/qemu-iotests/172.out          | 656 ++++++++++++++++++++++++++++++++----
 44 files changed, 928 insertions(+), 270 deletions(-)

-- 
2.26.2


Re: [PULL 00/16] Qdev patches for 2020-06-23
Posted by no-reply@patchew.org 3 years, 9 months ago
Patchew URL: https://patchew.org/QEMU/20200623142326.2349416-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/16] Qdev patches for 2020-06-23
Type: series
Message-id: 20200623142326.2349416-1-armbru@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200623142326.2349416-1-armbru@redhat.com -> patchew/20200623142326.2349416-1-armbru@redhat.com
Switched to a new branch 'test'
ac67def sd/milkymist-memcard: Fix error API violation
76b782c sd/pxa2xx_mmci: Don't crash on pxa2xx_mmci_init() error
086cf2b arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp
6bd670c qdev: Make qdev_prop_set_drive() match the other helpers
7eeac9e qdev: Reject chardev property override
ce015be qdev: Reject drive property override
4add9a8 qdev: Improve netdev property override error a bit
cb55c6b qdev: Eliminate get_pointer(), set_pointer()
6047192 blockdev: Deprecate -drive with bogus interface type
a895f7e docs/qdev-device-use.txt: Update section "Default Devices"
b16a9dd fdc: Deprecate configuring floppies with -global isa-fdc
21ae90a fdc: Open-code fdctrl_init_isa()
7f28ea2 fdc: Reject clash between -drive if=floppy and -global isa-fdc
32abd1e iotests/172: Cover -global floppy.drive=...
94d87e4 iotests/172: Cover empty filename and multiple use of drives
e86ed08 iotests/172: Include "info block" in test output

=== OUTPUT BEGIN ===
1/16 Checking commit e86ed08dd590 (iotests/172: Include "info block" in test output)
2/16 Checking commit 94d87e4b70d9 (iotests/172: Cover empty filename and multiple use of drives)
ERROR: trailing whitespace
#49: FILE: tests/qemu-iotests/172.out:190:
+Testing: -fdb $

total: 1 errors, 0 warnings, 86 lines checked

Patch 2/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/16 Checking commit 32abd1e271de (iotests/172: Cover -global floppy.drive=...)
4/16 Checking commit 7f28ea2d0fb3 (fdc: Reject clash between -drive if=floppy and -global isa-fdc)
5/16 Checking commit 21ae90a939a0 (fdc: Open-code fdctrl_init_isa())
6/16 Checking commit b16a9dd79300 (fdc: Deprecate configuring floppies with -global isa-fdc)
7/16 Checking commit a895f7e560a7 (docs/qdev-device-use.txt: Update section "Default Devices")
8/16 Checking commit 6047192a60b6 (blockdev: Deprecate -drive with bogus interface type)
9/16 Checking commit cb55c6b9560c (qdev: Eliminate get_pointer(), set_pointer())
10/16 Checking commit 4add9a82e120 (qdev: Improve netdev property override error a bit)
11/16 Checking commit ce015be44e23 (qdev: Reject drive property override)
12/16 Checking commit 7eeac9e4aac8 (qdev: Reject chardev property override)
13/16 Checking commit 6bd670c596a9 (qdev: Make qdev_prop_set_drive() match the other helpers)
14/16 Checking commit 086cf2b3fbe7 (arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp)
15/16 Checking commit 76b782c8fe16 (sd/pxa2xx_mmci: Don't crash on pxa2xx_mmci_init() error)
16/16 Checking commit ac67def4dfa7 (sd/milkymist-memcard: Fix error API violation)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200623142326.2349416-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL 00/16] Qdev patches for 2020-06-23
Posted by Peter Maydell 3 years, 9 months ago
On Tue, 23 Jun 2020 at 15:24, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit 61fee7f45955cd0bf9b79be9fa9c7ebabb5e6a85:
>
>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/acceptance-testing-20200622' into staging (2020-06-22 20:50:10 +0100)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-qdev-2020-06-23
>
> for you to fetch changes up to 953cd66139b6e28fdc7cdbf28065a0a98ce7877c:
>
>   sd/milkymist-memcard: Fix error API violation (2020-06-23 16:07:21 +0200)
>
> ----------------------------------------------------------------
> Qdev patches for 2020-06-23
>
> * Reject clash between -drive if=floppy and -global isa-fdc
> * Deprecate configuring floppies with -global isa-fdc
> * Deprecate -drive with bogus interface type
> * Reject drive property override instead of screwing up
> * Reject chardev property override instead of screwing up
> * Various error handling improvements
> * Extend iotests/172
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.

-- PMM