[PATCH v3 0/2] target/arm: Fix using pmu=on on KVM

Philippe Mathieu-Daudé posted 2 patches 3 years, 9 months ago
Test FreeBSD passed
Test asan passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200623090622.30365-1-philmd@redhat.com
target/arm/kvm_arm.h           | 21 ++++++++-----------
target/arm/cpu.c               |  2 +-
target/arm/cpu64.c             | 10 ++++-----
target/arm/kvm.c               |  4 ++--
target/arm/kvm64.c             | 14 +++++--------
tests/qtest/arm-cpu-features.c | 38 ++++++++++++++++++++++++++++++----
6 files changed, 56 insertions(+), 33 deletions(-)
[PATCH v3 0/2] target/arm: Fix using pmu=on on KVM
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago
Since v2:
- include Drew test fix (addressed Peter review comments)
- addressed Drew review comments
- collected R-b/A-b

Andrew Jones (1):
  tests/qtest/arm-cpu-features: Add feature setting tests

Philippe Mathieu-Daudé (1):
  target/arm: Check supported KVM features globally (not per vCPU)

 target/arm/kvm_arm.h           | 21 ++++++++-----------
 target/arm/cpu.c               |  2 +-
 target/arm/cpu64.c             | 10 ++++-----
 target/arm/kvm.c               |  4 ++--
 target/arm/kvm64.c             | 14 +++++--------
 tests/qtest/arm-cpu-features.c | 38 ++++++++++++++++++++++++++++++----
 6 files changed, 56 insertions(+), 33 deletions(-)

-- 
2.21.3


Re: [PATCH v3 0/2] target/arm: Fix using pmu=on on KVM
Posted by Andrew Jones 3 years, 9 months ago
On Tue, Jun 23, 2020 at 11:06:20AM +0200, Philippe Mathieu-Daudé wrote:
> Since v2:
> - include Drew test fix (addressed Peter review comments)
> - addressed Drew review comments
> - collected R-b/A-b
> 
> Andrew Jones (1):
>   tests/qtest/arm-cpu-features: Add feature setting tests
> 
> Philippe Mathieu-Daudé (1):
>   target/arm: Check supported KVM features globally (not per vCPU)
> 
>  target/arm/kvm_arm.h           | 21 ++++++++-----------
>  target/arm/cpu.c               |  2 +-
>  target/arm/cpu64.c             | 10 ++++-----
>  target/arm/kvm.c               |  4 ++--
>  target/arm/kvm64.c             | 14 +++++--------
>  tests/qtest/arm-cpu-features.c | 38 ++++++++++++++++++++++++++++++----
>  6 files changed, 56 insertions(+), 33 deletions(-)
> 
> -- 
> 2.21.3
> 
>

Hi Phil,

Thanks for including the test patch. To avoid breaking bisection, if one
were to use qtest to bisect something, then the order of patches should
be reversed. I guess Peter can apply them that way without a repost
though.

Thanks,
drew 


Re: [PATCH v3 0/2] target/arm: Fix using pmu=on on KVM
Posted by Peter Maydell 3 years, 9 months ago
On Tue, 23 Jun 2020 at 10:18, Andrew Jones <drjones@redhat.com> wrote:
>
> On Tue, Jun 23, 2020 at 11:06:20AM +0200, Philippe Mathieu-Daudé wrote:
> > Since v2:
> > - include Drew test fix (addressed Peter review comments)
> > - addressed Drew review comments
> > - collected R-b/A-b
> >
> > Andrew Jones (1):
> >   tests/qtest/arm-cpu-features: Add feature setting tests
> >
> > Philippe Mathieu-Daudé (1):
> >   target/arm: Check supported KVM features globally (not per vCPU)
> >
> >  target/arm/kvm_arm.h           | 21 ++++++++-----------
> >  target/arm/cpu.c               |  2 +-
> >  target/arm/cpu64.c             | 10 ++++-----
> >  target/arm/kvm.c               |  4 ++--
> >  target/arm/kvm64.c             | 14 +++++--------
> >  tests/qtest/arm-cpu-features.c | 38 ++++++++++++++++++++++++++++++----
> >  6 files changed, 56 insertions(+), 33 deletions(-)
> >
> > --
> > 2.21.3
> >
> >
>
> Hi Phil,
>
> Thanks for including the test patch. To avoid breaking bisection, if one
> were to use qtest to bisect something, then the order of patches should
> be reversed. I guess Peter can apply them that way without a repost
> though.

Yeah, I can just flip the order.

thanks
-- PMM

Re: [PATCH v3 0/2] target/arm: Fix using pmu=on on KVM
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago
On 6/23/20 11:19 AM, Peter Maydell wrote:
> On Tue, 23 Jun 2020 at 10:18, Andrew Jones <drjones@redhat.com> wrote:
>>
>> On Tue, Jun 23, 2020 at 11:06:20AM +0200, Philippe Mathieu-Daudé wrote:
>>> Since v2:
>>> - include Drew test fix (addressed Peter review comments)
>>> - addressed Drew review comments
>>> - collected R-b/A-b
>>>
>>> Andrew Jones (1):
>>>   tests/qtest/arm-cpu-features: Add feature setting tests
>>>
>>> Philippe Mathieu-Daudé (1):
>>>   target/arm: Check supported KVM features globally (not per vCPU)
>>>
>>>  target/arm/kvm_arm.h           | 21 ++++++++-----------
>>>  target/arm/cpu.c               |  2 +-
>>>  target/arm/cpu64.c             | 10 ++++-----
>>>  target/arm/kvm.c               |  4 ++--
>>>  target/arm/kvm64.c             | 14 +++++--------
>>>  tests/qtest/arm-cpu-features.c | 38 ++++++++++++++++++++++++++++++----
>>>  6 files changed, 56 insertions(+), 33 deletions(-)
>>>
>>> --
>>> 2.21.3
>>>
>>>
>>
>> Hi Phil,
>>
>> Thanks for including the test patch. To avoid breaking bisection, if one
>> were to use qtest to bisect something, then the order of patches should
>> be reversed.

Oops :)

>> I guess Peter can apply them that way without a repost
>> though.
> 
> Yeah, I can just flip the order.

Thanks both!


Re: [PATCH v3 0/2] target/arm: Fix using pmu=on on KVM
Posted by Peter Maydell 3 years, 9 months ago
On Tue, 23 Jun 2020 at 10:06, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Since v2:
> - include Drew test fix (addressed Peter review comments)
> - addressed Drew review comments
> - collected R-b/A-b
>
> Andrew Jones (1):
>   tests/qtest/arm-cpu-features: Add feature setting tests
>
> Philippe Mathieu-Daudé (1):
>   target/arm: Check supported KVM features globally (not per vCPU)

Applied to target-arm.next, thanks. I dropped the Analyzed-by
tag from one patch because I think we ought to stick to a
standard set of reviewed-by/signed-off-by/acked-by tags.

-- PMM