From nobody Mon Feb 9 19:13:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592746297; cv=none; d=zohomail.com; s=zohoarc; b=FEAjV8YMeUeXn8sLqSoPWJrOdx0dJSJOaYXLseiGCUUVyGvLpMfeteIDFp19ksAfVKvwD69dMEF9No3b+VJDC5H4bTvuWgVeFjhiYknx9TlwqbJ+UlW+fVYpD2FddN6xmPITKL4vUmBZCZsq3pNGeZc80gS2wt62+697dpbwrEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592746297; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=alj94sWoHVZTpza1Yhyx2JKc6Ymur55PclIDiPG3WhI=; b=I8b0cZYjBJGFLTvhtFiS+ynQ3tPwrs7Ym1dwLFoPhWtckV7v279sru0v20Phw/mSMZWI01L6xhbB4iMVVDIPPt0+4tr1MAiW3F8xMKgndJ6THD4bWTsxZUpt/kBjVyDde/ngLRKTiwKJWtFDpXzgx8FKMrCVnu9SpaRquCeBkrQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592746297696431.6823269379736; Sun, 21 Jun 2020 06:31:37 -0700 (PDT) Received: from localhost ([::1]:43462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jn04N-0002xI-Dg for importer@patchew.org; Sun, 21 Jun 2020 09:31:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jn03R-0002SJ-HS for qemu-devel@nongnu.org; Sun, 21 Jun 2020 09:30:39 -0400 Received: from mxfz.ruijie.com.cn ([120.35.11.201]:60319 helo=FZEX3.ruijie.com.cn) by eggs.gnu.org with esmtps (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jn03N-0008O1-DJ for qemu-devel@nongnu.org; Sun, 21 Jun 2020 09:30:35 -0400 Received: from localhost.localdomain.localdomain (172.30.216.210) by FZEX3.ruijie.com.cn (192.168.58.89) with Microsoft SMTP Server id 14.3.123.3; Sun, 21 Jun 2020 21:30:21 +0800 From: lichun To: Subject: [PATCH v2] chardev/tcp: fix error message double free error Date: Mon, 22 Jun 2020 05:30:17 +0800 Message-ID: <20200621213017.17978-1-lichun@ruijie.com.cn> X-Mailer: git-send-email 2.18.4 MIME-Version: 1.0 X-Originating-IP: [172.30.216.210] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=120.35.11.201; envelope-from=lichun@ruijie.com.cn; helo=FZEX3.ruijie.com.cn X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/21 09:30:25 X-ACL-Warn: Detected OS = Windows 7 or 8 [fuzzy] X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_06_12=1.947, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, lichun , qemu-devel@nongnu.org, 706701795@qq.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: lichun Reviewed-by: Markus Armbruster --- chardev/char-socket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index afebeec5c3..569d54c144 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -142,6 +142,8 @@ static void check_report_connect_error(Chardev *chr, "Unable to connect character device %s: ", chr->label); s->connect_err_reported =3D true; + } else { + error_free(err); } qemu_chr_socket_restart_timer(chr); } @@ -1086,7 +1088,6 @@ static void qemu_chr_socket_connected(QIOTask *task, = void *opaque) if (qio_task_propagate_error(task, &err)) { tcp_chr_change_state(s, TCP_CHARDEV_STATE_DISCONNECTED); check_report_connect_error(chr, err); - error_free(err); goto cleanup; } =20 --=20 2.18.4