From nobody Tue Feb 10 05:41:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592694077; cv=none; d=zohomail.com; s=zohoarc; b=nQQLbQ3OKN1Eu6vHfYXtYXxRVGMoDmpXUnB+5TSiMWUnw1Jyuh087vXOFBrmGlwBEXtW2GYzSq6jZJs91sBIGT8RERwI1e6ZZXIeh6VIzO5H2DsS++aGf5gdVg1QY/cIr2IXAlV4h4dLjsaoEvC6MYw8rGWoe+0v1X20LQCD5t4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592694077; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gvoEXdIxYQqhIJHdWM52DnB0B20B8eCcffJMhifuxRg=; b=a44OUI7/D8DU4ociVcLVFEXUnx4Zxc5i8Ghd5GAi2qDz+/T0uYqEyAsiOh5V+SAa0yXXQ3hahmfiihHQ17huXUQ7K4s1ZEjM83YNBILRvirw3WNzkrqsj6fq1qWP63EN6mAszfy8GXub0qT1kNRDfs6wUxkP3p3EzqyHSzVxIk4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159269407761451.46540194423983; Sat, 20 Jun 2020 16:01:17 -0700 (PDT) Received: from localhost ([::1]:39828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmmU8-0004WT-9s for importer@patchew.org; Sat, 20 Jun 2020 19:01:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmmS6-00010E-9J; Sat, 20 Jun 2020 18:59:10 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:41156) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmmS4-0000yq-K1; Sat, 20 Jun 2020 18:59:09 -0400 Received: by mail-wr1-x443.google.com with SMTP id q2so10709641wrv.8; Sat, 20 Jun 2020 15:59:07 -0700 (PDT) Received: from localhost.localdomain (1.red-83-51-162.dynamicip.rima-tde.net. [83.51.162.1]) by smtp.gmail.com with ESMTPSA id x18sm11147127wmi.35.2020.06.20.15.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2020 15:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gvoEXdIxYQqhIJHdWM52DnB0B20B8eCcffJMhifuxRg=; b=jUM2UYrQRb++KYNo5KCjYsGLt0ZR3JYJx1g5W8pI+dSxzP4+AN0mLswLtC1oPPWI5l FK2qqgj8qmBdd3/RXT3WYVMW6UJsg0QnjWGHKbRvyRX1YyUPVEjGJUOqwGvr2KTTehMF zFOIGUlfv54q8RfbzEUYi/mlb6a3jV3wlgYqfdCa5wIPgG3VckVq3a0krdyi5+bZq4fO hHuHKehONT1RsX8/bCuWjyQ8k8VLUBpaHzAIQrWf8ZaoSGhrmgbn8oDInnTpFRfeaHXH hzVP01c8oV4Q0jRLE6Klyu6TZ4mwVyPa7yFTy0ALd8yP/64lQSZxSiOUpLVgWGmXNpgP jChQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gvoEXdIxYQqhIJHdWM52DnB0B20B8eCcffJMhifuxRg=; b=svs6RdtY3FG3sPFiqglHmr4hYqJ2sGjnKIvT8wEPLhTUWChUnEZTT44wzxxuHWYFdT BNa7yYMWPYqI1IUMLHAAJyWHkK+UlWGdeP32i63r02jKlnteGb3duDtE9d8faaWCcsDy yN9/ZLt38n0IbYx9fVFxAMl+Gc/gOOjUjNyGP/AUM+yHJCByh3EEbM2voXhR5V/yTq8j T0xKlkuCGKDG7CAASZXAX37i1llnF1s8JaGMvgnkBDGNFFMZCb8EKxysGekorvlRfULQ V2oJETb6/arydbZv1NuG7yWl3nVNQk6rNINqyXdGKuFL+/P8HOUgLnlN2YP3wjLR6YiD DmSw== X-Gm-Message-State: AOAM5330QQnVyYqy+jrcDEWSrETXWXONdza6QU5OoUePiDv1yg6u+bbY Ug4+DuyUjoCTA3WpQXtOhU3RsPgc X-Google-Smtp-Source: ABdhPJxhiT/TdPY2DkLujKZ8ZcSIh45y/h8z6weh4VKdLlcWUS+CUaSplRQ+PXFITP8ctN29yJaRjg== X-Received: by 2002:adf:ed49:: with SMTP id u9mr10893120wro.414.1592693946775; Sat, 20 Jun 2020 15:59:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 7/8] hw/misc/pca9552: Trace GPIO change events Date: Sun, 21 Jun 2020 00:58:53 +0200 Message-Id: <20200620225854.31160-8-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200620225854.31160-1-f4bug@amsat.org> References: <20200620225854.31160-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Peter Maydell , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Joel Stanley Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Emit a trace event when a GPIO change its state. Example booting obmc-phosphor-image: $ qemu-system-arm -M witherspoon-bmc -trace pca9552_gpio_change 1592690552.687372:pca9552_gpio_change pca1 GPIO id:0 status: 0 -> 1 1592690552.690169:pca9552_gpio_change pca1 GPIO id:1 status: 0 -> 1 1592690552.691673:pca9552_gpio_change pca1 GPIO id:2 status: 0 -> 1 1592690552.696886:pca9552_gpio_change pca1 GPIO id:3 status: 0 -> 1 1592690552.698614:pca9552_gpio_change pca1 GPIO id:13 status: 0 -> 1 1592690552.699833:pca9552_gpio_change pca1 GPIO id:14 status: 0 -> 1 1592690552.700842:pca9552_gpio_change pca1 GPIO id:15 status: 0 -> 1 1592690683.841921:pca9552_gpio_change pca1 GPIO id:14 status: 1 -> 0 1592690683.861660:pca9552_gpio_change pca1 GPIO id:14 status: 0 -> 1 1592690684.371460:pca9552_gpio_change pca1 GPIO id:14 status: 1 -> 0 1592690684.882115:pca9552_gpio_change pca1 GPIO id:14 status: 0 -> 1 1592690685.391411:pca9552_gpio_change pca1 GPIO id:14 status: 1 -> 0 1592690685.901391:pca9552_gpio_change pca1 GPIO id:14 status: 0 -> 1 1592690686.411678:pca9552_gpio_change pca1 GPIO id:14 status: 1 -> 0 1592690686.921279:pca9552_gpio_change pca1 GPIO id:14 status: 0 -> 1 We notice the GPIO #14 (front-power LED) starts to blink. This LED is described in the witherspoon device-tree [*]: front-power { retain-state-shutdown; default-state =3D "keep"; gpios =3D <&pca0 14 GPIO_ACTIVE_LOW>; }; [*] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts?id=3Db1f9be9392f0#n140 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/pca9552.c | 15 +++++++++++++++ hw/misc/trace-events | 1 + 2 files changed, 16 insertions(+) diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c index f0d435e310..85557b78d9 100644 --- a/hw/misc/pca9552.c +++ b/hw/misc/pca9552.c @@ -60,6 +60,21 @@ static void pca9552_display_pins_status(PCA9552State *s) buf[i] =3D '\0'; trace_pca9552_gpio_status(s->description, buf); } + if (trace_event_get_state_backends(TRACE_PCA9552_GPIO_CHANGE)) { + for (i =3D 0; i < s->nr_leds; i++) { + if (extract32(pins_changed, i, 1)) { + unsigned new_state =3D extract32(pins_status, i, 1); + + /* + * We display the state using the PCA logic ("active-high"= ). + * This is not the state of the LED, which signal might be + * wired "active-low" on the board. + */ + trace_pca9552_gpio_change(s->description, i, + !new_state, new_state); + } + } + } } =20 static void pca9552_update_pin_input(PCA9552State *s) diff --git a/hw/misc/trace-events b/hw/misc/trace-events index 7630e59652..805d2110e0 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -209,3 +209,4 @@ grlib_apb_pnp_read(uint64_t addr, uint32_t value) "APB = PnP read addr:0x%03"PRIx6 =20 # pca9552.c pca9552_gpio_status(const char *description, const char *buf) "%s GPIOs 0-= 15 [%s]" +pca9552_gpio_change(const char *description, unsigned id, unsigned prev_st= ate, unsigned current_state) "%s GPIO id:%u status: %u -> %u" --=20 2.21.3