From nobody Fri Oct 10 09:39:03 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592573054; cv=none; d=zohomail.com; s=zohoarc; b=PBhjsIsoK147ocFH7IzApJsi/q3kh2VlDxEYa7xllCWhGXSQQDtwCzfUf6DZ+AkwZvYfvTwpAiP82Fc3stS/zO4cV0dctnoOGqR3g+FvDXRPmJCiSmwiGnJLG1KoRiUJpLrY9LdB2Ug9lwmvJMa0GULsVpjxOKGXgl32BhLV8n8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592573054; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=ThA4PcGmHPjm0a2hIhKL6GKElc9TuBBquvXBGHtlg3o=; b=BasRmXkvB44posqdaDBL5QJ8kLPr7STBuylbm6zatIGNdnAsjsa8c4AEoPIeIi3o7UZqeJQS8b4o/ZuBZwQ+/g+1b95DeMZa2IlFyAy9/hOT0CNmjseDRjgd6Y+qpGRgCtVCo6GIMdu5MGtu1pYvlELYhrAJEj7IFVC1k7Rydzg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592573054927945.9499028537562; Fri, 19 Jun 2020 06:24:14 -0700 (PDT) Received: from localhost ([::1]:52854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmH0A-0003jH-2d for importer@patchew.org; Fri, 19 Jun 2020 09:24:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmGu1-0001sh-4Y for qemu-devel@nongnu.org; Fri, 19 Jun 2020 09:17:53 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:32638 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jmGtz-00037j-FX for qemu-devel@nongnu.org; Fri, 19 Jun 2020 09:17:52 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-8BfNKi7zPiamzpPfHnG41g-1; Fri, 19 Jun 2020 09:17:48 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 87CD3EC1A2; Fri, 19 Jun 2020 13:17:47 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-67.ams2.redhat.com [10.36.112.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3B897C1E5; Fri, 19 Jun 2020 13:17:46 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 845CC9D8F; Fri, 19 Jun 2020 15:17:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592572670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ThA4PcGmHPjm0a2hIhKL6GKElc9TuBBquvXBGHtlg3o=; b=LnI3BHKCdn4NXaYEFbg7sJCN3c+GxK00oR8GLYLI7JC3g5+R6xE1+Ir9YCiNCyzn0mTIgq zMMmDbqSfuU0nhRDdfNOVXMwMWqY+uPNP1rM/t2ekP1ldn6m6p6ZD1oGikF2iznZfS+nZa KkA4vL4GVU+iM+bLvxyS6jrS1Tt/p4E= X-MC-Unique: 8BfNKi7zPiamzpPfHnG41g-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 4/7] audio/jack: do not remove ports when finishing Date: Fri, 19 Jun 2020 15:17:38 +0200 Message-Id: <20200619131741.10857-5-kraxel@redhat.com> In-Reply-To: <20200619131741.10857-1-kraxel@redhat.com> References: <20200619131741.10857-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/19 02:45:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geoffrey McRae , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Geoffrey McRae This fixes a hang when there is a communications issue with the JACK server. Simply closing the connection is enough to completely clean up and as such we do not need to remove the ports first. As JACK uses a socket based protocol that relies on the `select` call, if there is a communication breakdown with the server the client library waits forever for a response to the unregister request. Signed-off-by: Geoffrey McRae Message-id: 20200613040518.38172-5-geoff@hostfission.com Signed-off-by: Gerd Hoffmann --- audio/jackaudio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/audio/jackaudio.c b/audio/jackaudio.c index 58c73444977e..249cbd3265c5 100644 --- a/audio/jackaudio.c +++ b/audio/jackaudio.c @@ -548,9 +548,6 @@ static void qjack_client_fini(QJackClient *c) { switch (c->state) { case QJACK_STATE_RUNNING: - for (int i =3D 0; i < c->nchannels; ++i) { - jack_port_unregister(c->client, c->port[i]); - } jack_deactivate(c->client); /* fallthrough */ =20 --=20 2.18.4