From nobody Fri Oct 10 09:38:29 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592572822; cv=none; d=zohomail.com; s=zohoarc; b=OY1iKvwxjP/qYK4lkEjdzrFIbPgy410kGRB0uipPc18ZgRX+S4atX7nfssbX7uxzC0bKLmg57oYGZKChm7NuGwWsvLxpdc1py1Kkcdtv9rZeK7+vtmREm21uZTlHD0XRJIz/dTbCbUsk91SU0mtCQM37mhcOKDOe1LzeNqkD19Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592572822; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=2spzZp7YNxUHSDFw+hg2vvBDafbe+cjYmHrIRcCA8uY=; b=JOzWbj17I1Fgzq2YFnmN+YPBwoy3CXXMJ8rlr/Z/t9/TqfUEF9Qwe54lH0fIdg/c4yaepcv691S5zKqpjh3yjJir6g9GC7I8Jg9Rir2IT265WT/y2zbUCY2pkWaBXLiwV8o3j77vqjiqIWdHcnzSfUtcnwZumGYzpSq4zKhqclk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592572822456483.61360662554773; Fri, 19 Jun 2020 06:20:22 -0700 (PDT) Received: from localhost ([::1]:38636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmGwO-0004jC-Uw for importer@patchew.org; Fri, 19 Jun 2020 09:20:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmGtz-0001qZ-QA for qemu-devel@nongnu.org; Fri, 19 Jun 2020 09:17:51 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:24976 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jmGty-00037Z-5C for qemu-devel@nongnu.org; Fri, 19 Jun 2020 09:17:51 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-38-g22U_K4kO3ymlOGpDdQA8Q-1; Fri, 19 Jun 2020 09:17:46 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F39FA835B41; Fri, 19 Jun 2020 13:17:45 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-67.ams2.redhat.com [10.36.112.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF87960BE1; Fri, 19 Jun 2020 13:17:42 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7B67E1753D; Fri, 19 Jun 2020 15:17:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592572669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=2spzZp7YNxUHSDFw+hg2vvBDafbe+cjYmHrIRcCA8uY=; b=LMZWBRNubuYGH6tcId+iMW/HzFbomKFaTX5s+x4vsoEh2i1ex0MlkiSsArwlyoiPwP6AJL Os8Ey+9jEEgkx8YO+myYEhG1e3SjE59gLSD+RZ+REk5kGzHISS/CBYM/gPFIC6rFAYFAh8 AItWpZyJNXt4fMO62FOOvYL8H13D5rI= X-MC-Unique: g22U_K4kO3ymlOGpDdQA8Q-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 3/7] audio/jack: remove invalid set of input support bool Date: Fri, 19 Jun 2020 15:17:37 +0200 Message-Id: <20200619131741.10857-4-kraxel@redhat.com> In-Reply-To: <20200619131741.10857-1-kraxel@redhat.com> References: <20200619131741.10857-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/19 02:45:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geoffrey McRae , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Geoffrey McRae Initial code for JACK did not support audio input and as such this boolean was set to let QEMU know, however JACK ended up including input support making this invalid. Further investigation shows it was invalid to set it in the first instance anyway due to a failure on my part understand properly what this was for when the audodev was initially developed. Signed-off-by: Geoffrey McRae Message-id: 20200613040518.38172-4-geoff@hostfission.com Signed-off-by: Gerd Hoffmann --- audio/jackaudio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/audio/jackaudio.c b/audio/jackaudio.c index fb8efd7af7c7..58c73444977e 100644 --- a/audio/jackaudio.c +++ b/audio/jackaudio.c @@ -607,9 +607,6 @@ static int qjack_thread_creator(jack_native_thread_t *t= hread, static void *qjack_init(Audiodev *dev) { assert(dev->driver =3D=3D AUDIODEV_DRIVER_JACK); - - dev->u.jack.has_in =3D false; - return dev; } =20 --=20 2.18.4