From nobody Fri Oct 10 23:41:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592561640; cv=none; d=zohomail.com; s=zohoarc; b=O0UPhzpgchRFbNFeGAI3YW6Qu3O8PIkuH0Af38q+B2Qia0NrKvLglDmTvhta7EguWRHFBn9IxCbYOLsIpkMYANwuTHl5bjb6N9nVTakaxE5lXZu4gktYgNQcFZFLN/Sae1tkrNd7NeF9UoVvJMUh/TCmgzHbcPhRDU0ETc3Eg40= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592561640; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tvUusN2KT2/dP9oHEXmn3+NtCB5T7EoWy8EJVdJdMj0=; b=YYydMoZCZ4VS+t7qdcnrLexWq2gwDhJdP9sbCWN9wkTJnfTIxKBg6WpLknzgnAif4+3v897/fw0vv1FYgWEB3J+qtPXnmQCWWDmQOmKijwNl7Hf2q0TT1etB/63dYtACsjiqlhibqo9xZA8PkJhEnduqOzH4rsZYEzoyy/neBjw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592561640183362.4468201930109; Fri, 19 Jun 2020 03:14:00 -0700 (PDT) Received: from localhost ([::1]:48222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmE22-0006jp-UY for importer@patchew.org; Fri, 19 Jun 2020 06:13:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmDzt-0003r0-SK for qemu-devel@nongnu.org; Fri, 19 Jun 2020 06:11:45 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49348 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jmDzs-0004AS-8Q for qemu-devel@nongnu.org; Fri, 19 Jun 2020 06:11:45 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-UY1yfVY3PoSGfjQDR1wP5Q-1; Fri, 19 Jun 2020 06:11:42 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E6DA1800D4A; Fri, 19 Jun 2020 10:11:41 +0000 (UTC) Received: from localhost (ovpn-113-212.ams2.redhat.com [10.36.113.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 128D15C1D0; Fri, 19 Jun 2020 10:11:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592561503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvUusN2KT2/dP9oHEXmn3+NtCB5T7EoWy8EJVdJdMj0=; b=Hts+6BREmnk/A17KsVr6gQSskf4bfNINw5k2VJS2IEjPOyFP61VrKW9xgcf0SEE1w8O0l3 cyXF91/CWCpJh8iveAwkLbJQk4ceBYnvpc71Y8Z71mOPkgBL16fIl5cHkDEUoFImk9aKR1 X4VjHM0nfx9CyjvRxPYaxm6mBxhuLFc= X-MC-Unique: UY1yfVY3PoSGfjQDR1wP5Q-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 1/2] qemu-storage-daemon: remember to add qemu_object_opts Date: Fri, 19 Jun 2020 11:11:31 +0100 Message-Id: <20200619101132.2401756-2-stefanha@redhat.com> In-Reply-To: <20200619101132.2401756-1-stefanha@redhat.com> References: <20200619101132.2401756-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=stefanha@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/19 05:19:18 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The --object option is supported by qemu-storage-daemon but the qemu_object_opts QemuOptsList wasn't being added. As a result calls to qemu_find_opts("object") failed with "There is no option group 'object'". This patch fixes the object-del QMP command. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- qemu-storage-daemon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-storage-daemon.c b/qemu-storage-daemon.c index 9e7adfe3a6..a01cbd6371 100644 --- a/qemu-storage-daemon.c +++ b/qemu-storage-daemon.c @@ -316,6 +316,7 @@ int main(int argc, char *argv[]) =20 module_call_init(MODULE_INIT_QOM); module_call_init(MODULE_INIT_TRACE); + qemu_add_opts(&qemu_object_opts); qemu_add_opts(&qemu_trace_opts); qcrypto_init(&error_fatal); bdrv_init(); --=20 2.26.2 From nobody Fri Oct 10 23:41:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592561582; cv=none; d=zohomail.com; s=zohoarc; b=YOuq51hMqgGT3SnYMd1MkaIWMI+3BrK6PNYarUux7ZjLykmlELsHoM8Lz4Fuhrt5ULAVKQbj+DY6mW0k8pi04nhUbuPnHNLHC0NDbjIQMdLbJT2G8SQ+HwdhUZgM4EgM/ABLxCeBUWk9cwiflIycseIDXaMJ+QhhO5rGvyhqNWU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592561582; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=t9au4Bo0lrPIuddH5h6MeuUxlanlAkfnwONHYJw6PTQ=; b=KepEHsqdh8KOIOoFesi02PUu7bQSNJqm/N0D3KZV8dbnaSTIvXojDuHmN1sMTxUW9MaY/FLHLYdnYGkU4W0qUdQ0ususHeQjMFXUQK8CWLc98oQhASpWEGk+N8yYPGBg0Jyjrap5Cix8NzbGB6VzvoSJsE2oxrS1Ai9qwGZFxVc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592561582164221.90091442623475; Fri, 19 Jun 2020 03:13:02 -0700 (PDT) Received: from localhost ([::1]:44654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmE16-0005Fw-S2 for importer@patchew.org; Fri, 19 Jun 2020 06:13:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmDzz-0003wg-8k for qemu-devel@nongnu.org; Fri, 19 Jun 2020 06:11:51 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:28697 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jmDzx-0004BS-KU for qemu-devel@nongnu.org; Fri, 19 Jun 2020 06:11:50 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-bTO-4uQRMWK-oWPpFXYeNw-1; Fri, 19 Jun 2020 06:11:47 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4705A107ACCD; Fri, 19 Jun 2020 10:11:46 +0000 (UTC) Received: from localhost (ovpn-113-212.ams2.redhat.com [10.36.113.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id F1CD510013C4; Fri, 19 Jun 2020 10:11:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592561508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t9au4Bo0lrPIuddH5h6MeuUxlanlAkfnwONHYJw6PTQ=; b=bw7Fvz55DvGzFqABXCh65i7T+oI11mzcqU1GTgaG3iSgreXfVIIDQ7hbN+Dtx3wOL2OPOu fb5VhH2CrVVZGNf5lILrmSUf0FhKS+dbcu890IetKlnVmjs+628l2UX1NKch6HzMEhjjhe qUWrCBylcvHg3lDTPS4+q0FFwsgswIc= X-MC-Unique: bTO-4uQRMWK-oWPpFXYeNw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 2/2] qemu-storage-daemon: add missing cleanup calls Date: Fri, 19 Jun 2020 11:11:32 +0100 Message-Id: <20200619101132.2401756-3-stefanha@redhat.com> In-Reply-To: <20200619101132.2401756-1-stefanha@redhat.com> References: <20200619101132.2401756-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/19 02:45:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Several components used by qemu-storage-daemon have cleanup functions that aren't called. Keep the "valgrind --leak-check=3Dfull" as clean as possible by invoking the necessary cleanup functions. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- qemu-storage-daemon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qemu-storage-daemon.c b/qemu-storage-daemon.c index a01cbd6371..7e9b0e0d3f 100644 --- a/qemu-storage-daemon.c +++ b/qemu-storage-daemon.c @@ -335,5 +335,9 @@ int main(int argc, char *argv[]) main_loop_wait(false); } =20 + monitor_cleanup(); + qemu_chr_cleanup(); + user_creatable_cleanup(); + return EXIT_SUCCESS; } --=20 2.26.2