From nobody Mon Feb 9 20:11:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592372872; cv=none; d=zohomail.com; s=zohoarc; b=Ueafh0ZwQCJ8tZzIrhCAjxg+2r3tYfbT26HC2UZSQROGe/SGjv7rBBDTs/HvFY5uoHBpk0E1dQh9uHzp/cISVCI9BW2XpdTM8GfGxspzUh3aerTxeGwk7b5HYZGAe0Cm+gozVRN+KwUPD8Y3WoWFP4JrnpyuHYZKyWussaoWL/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592372872; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mL4yiHRVyGUjZw4VEYH3AemwfXJwLjo65tErGUGUNr4=; b=GekJqlbia5jJ8Co5MUqcgjIGzqfDdk+vT2gTDbyMiEi8iuIVZ9fguY+yqsXE6seDSGZFPTH5W6KWrF8a7CSFOIk01dUsqACyEZwNSrXe9Yc7cr2PH8UHKrCAVVjmhqypLSFLgUANjyBbjRewZXVQ2/z/KjjOJH/3Oe8pN0Rjhls= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592372872507727.9601848670775; Tue, 16 Jun 2020 22:47:52 -0700 (PDT) Received: from localhost ([::1]:54658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlQvP-0008Ok-A1 for importer@patchew.org; Wed, 17 Jun 2020 01:47:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlQqS-0001md-Ib for qemu-devel@nongnu.org; Wed, 17 Jun 2020 01:42:45 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:25704 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jlQqR-000306-1s for qemu-devel@nongnu.org; Wed, 17 Jun 2020 01:42:44 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-Qb5FJo9GPey4gMw2zaN2WA-1; Wed, 17 Jun 2020 01:42:37 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2DDD6107B476; Wed, 17 Jun 2020 05:42:35 +0000 (UTC) Received: from localhost.localdomain (vpn2-54-83.bne.redhat.com [10.64.54.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6FF4919D61; Wed, 17 Jun 2020 05:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592372562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mL4yiHRVyGUjZw4VEYH3AemwfXJwLjo65tErGUGUNr4=; b=C8Vcg8QBAQj4FCyfwwanboBjj0SDjG/HlVTrwebV5Jt6DkeIbpCat24qwbEJOpOdTx4/Tc it4Y8nrSY33ywTop9kMd7KuW1eykI/spMSdsFMMsh8Nim0v3Z0NQKvxXXy/ciOgzZzNZbP 5eQkHvMlR9zaSkkQLHhHaZzSQhmG79Q= X-MC-Unique: Qb5FJo9GPey4gMw2zaN2WA-1 From: P J P To: Peter Maydell Subject: [PATCH 5/6] nvram: add nrf51_soc flash read method Date: Wed, 17 Jun 2020 11:09:32 +0530 Message-Id: <20200617053934.122642-6-ppandit@redhat.com> In-Reply-To: <20200617053934.122642-1-ppandit@redhat.com> References: <20200617053934.122642-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=ppandit@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/17 01:42:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prasad J Pandit , QEMU Developers , Lei Sun , Alex Williamson , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit Add nrf51_soc mmio read method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Signed-off-by: Prasad J Pandit --- hw/nvram/nrf51_nvm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/nvram/nrf51_nvm.c b/hw/nvram/nrf51_nvm.c index f2283c1a8d..e813c7ec72 100644 --- a/hw/nvram/nrf51_nvm.c +++ b/hw/nvram/nrf51_nvm.c @@ -274,6 +274,12 @@ static const MemoryRegionOps io_ops =3D { }; =20 =20 +static uint64_t flash_read(void *opaque, hwaddr addr, unsigned size) +{ + qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__); + return 0; +} + static void flash_write(void *opaque, hwaddr offset, uint64_t value, unsigned int size) { @@ -300,6 +306,7 @@ static void flash_write(void *opaque, hwaddr offset, ui= nt64_t value, =20 =20 static const MemoryRegionOps flash_ops =3D { + .read =3D flash_read, .write =3D flash_write, .valid.min_access_size =3D 4, .valid.max_access_size =3D 4, --=20 2.26.2