From nobody Mon Feb 9 12:26:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592318498; cv=none; d=zohomail.com; s=zohoarc; b=ePP8d5kVWA7CYF//9Nye+oUIyLC4WdJi+aIDdW6MJ38RLhqzaI7hqq7O4JvM7T7pA2GcP4/wohChw5x34q1VZYxh8C5V/N9HFLBaJHhn8I4oQUzzSVk3Yh5DrinwT/Bqr6Lt8rgAhkFLtE9jO9l+mkh3G2YjyEs7n8X/OvGgwpI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592318498; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=wXGzXtnYVU6jrvJg29PeDu0tkOnyv8mwvCmy2U31qtA=; b=eNikOiosXdZ2ugwiKqQUD4VwGV+dbXJlmZvzKl8wFpu0+29NYA4RENTdguwoJlgIvz6pjKgj5rmD/cfnsyga1BoruYDLLoMCz8fwZT/O+dqtJ0j2eiPridSETPj2U4q2urhihgWnKFIaz9T0HT5DvdAfZyheI3NTFew2sr45eho= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592318498019138.49365995443452; Tue, 16 Jun 2020 07:41:38 -0700 (PDT) Received: from localhost ([::1]:59424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlCmO-0001yi-Su for importer@patchew.org; Tue, 16 Jun 2020 10:41:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlCQ8-0002n4-Nu; Tue, 16 Jun 2020 10:18:37 -0400 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]:40784) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlCQ6-0006nk-2c; Tue, 16 Jun 2020 10:18:36 -0400 Received: by mail-ot1-x32e.google.com with SMTP id s13so16033014otd.7; Tue, 16 Jun 2020 07:18:32 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id w5sm4081384otb.38.2020.06.16.07.18.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jun 2020 07:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=wXGzXtnYVU6jrvJg29PeDu0tkOnyv8mwvCmy2U31qtA=; b=JMyL4062p7Ya3b44mu8H4BWUcHgQBV3krFnzhEpw3zuqPbOsTM6fkxCkdtMgkECXJR gHoS/QP9hrGaHrd3ZUJZuyFedZD+6DX+XKJSi7nbKmMJjDtRA/8WmBEyGrl8l7HqcumC NAwxNICd4pOvsKgRmHZ8Eq4Qa/Koafg5kkz8/wCtIev36hBF2toSZP3EC5ZtUsSTXJEY ZR8Rois0q4L2amVni3bIyJTY4p/6/IPpjw+HPCVkIe4WMIP5Ay3fqebnMN2rKbwII3qQ obkWmsTb9fshAuzzLKv0F3myUttZRm1DdeT4c8/hR1kQlCTi0C6yYpKk6DrUGOsFFdXj bCCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=wXGzXtnYVU6jrvJg29PeDu0tkOnyv8mwvCmy2U31qtA=; b=WVRY0Kc5RWZi+XSTG/mcjNYi1IYX0brCbPCLm52sIkJ6tRRtOlq3/2tnsvjMzSFtxp U58bx+3VadTZm2evT+Ip+c5SnPO/yaEqDikhEfa/CRxgrY+7PBHJXYlSuwYv2LQZ/xzR +QbY5tlFyKS1G5JyUdek8wRcUqjtGW2JhamUbEun7CaqNmMWc3tQhIGN3iY5cdy8vCPr ZooIKFKhXmZdY3Ox890MAqqaZGmEtOB/V3PI2w4Dn2FFKUvHVvg3DQEmBpvPLUlT728z U//11os+/1shjIpzgCKwGWYOnSdWd9Rpl67nvj++acPoJe/LAKKLUDWRxcTnbw0y4im5 UudQ== X-Gm-Message-State: AOAM533e1qRUx++IdxXfCnFOe0H0q6MXir7NYSS8Y04wkThvgwdX/egK tMnz3++6GfxdHYQR2+U9ZsAWuhO0 X-Google-Smtp-Source: ABdhPJyseph+9oblm6gVqU8XIoCwHoe8uANq5BFAg/pp1+Yfy/Q8jNWUkfgp8P3M2U+SdTxjFrgGEA== X-Received: by 2002:a9d:5190:: with SMTP id y16mr2631839otg.68.1592317110163; Tue, 16 Jun 2020 07:18:30 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Subject: [PATCH 41/78] s390/sclp: improve special wait psw logic Date: Tue, 16 Jun 2020 09:15:10 -0500 Message-Id: <20200616141547.24664-42-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200616141547.24664-1-mdroth@linux.vnet.ibm.com> References: <20200616141547.24664-1-mdroth@linux.vnet.ibm.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::32e; envelope-from=flukshun@gmail.com; helo=mail-ot1-x32e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , Cornelia Huck , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Christian Borntraeger There is a special quiesce PSW that we check for "shutdown". Otherwise disa= bled wait is detected as "crashed". Architecturally we must only check PSW bits 116-127. Fix this. Cc: qemu-stable@nongnu.org Signed-off-by: Christian Borntraeger Message-Id: <1582204582-22995-1-git-send-email-borntraeger@de.ibm.com> Reviewed-by: David Hildenbrand Acked-by: Janosch Frank Signed-off-by: Cornelia Huck (cherry picked from commit 8b51c0961cc13e55b26bb6665ec3a341abdc7658) Signed-off-by: Michael Roth --- target/s390x/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/helper.c b/target/s390x/helper.c index a3a49164e4..6808dfda01 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -89,7 +89,7 @@ hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr v= addr) static inline bool is_special_wait_psw(uint64_t psw_addr) { /* signal quiesce */ - return psw_addr =3D=3D 0xfffUL; + return (psw_addr & 0xfffUL) =3D=3D 0xfffUL; } =20 void s390_handle_wait(S390CPU *cpu) --=20 2.17.1